[jitsi-dev] Removing ice4j RTP loss code

Archive
#1

Hey,

Ice4j's DelegatingDatagramSocket and DelegatingSocket contain code that
tries to measure the number of lost RTP packets, and logs messages such
as these:
RTP lost > 5%: 0.3082500489907897

The code is currently broken (since the addition of bundle), and results
in messages constantly being printed even when there is no packet loss.
These comprised 46% of the lines of the first log file that I tried.

I don't understand why the code exists at all. Does anyone see a reason
not to completely remove it? That is, remove the RTP-specific code, and
keep the code that logs packets to a pcap.

Regards,
Boris

#2

This should definitely not be in ice4j

···

On Monday, March 30, 2015, Boris Grozev <boris@jitsi.org> wrote:

Hey,

Ice4j's DelegatingDatagramSocket and DelegatingSocket contain code that
tries to measure the number of lost RTP packets, and logs messages such
as these:
RTP lost > 5%: 0.3082500489907897

The code is currently broken (since the addition of bundle), and results
in messages constantly being printed even when there is no packet loss.
These comprised 46% of the lines of the first log file that I tried.

I don't understand why the code exists at all. Does anyone see a reason
not to completely remove it? That is, remove the RTP-specific code, and
keep the code that logs packets to a pcap.

Regards,
Boris

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
--sent from my mobile

#3

It's removed now (some of it is moved to Jitsi where it was being used (for the same reason of logging losses)).

Boris

···

On 30/03/15 10:49, Emil Ivov wrote:

This should definitely not be in ice4j