[jitsi-dev] Re: run.exe -c creates a log dir when it shouldn't


#1

The attached patch should fix this issue.

Vieri

SIPCommunicator.java.diff (1.6 KB)

···

--- On Wed, 6/6/12, Vieri <rentorbuy@yahoo.com> wrote:

--- On Tue, 6/5/12, Vieri <rentorbuy@yahoo.com> > wrote:

> Sorry for cross-posting but it seems
> I'm not receiving e-mails from the users mailing list.
The
> dev list seems to work OK and besides, the issue I
posted
> here:
>
> http://java.net/nonav/projects/jitsi/lists/users/archive/2012-06/message/49
>
> is more of a dev question.

SIPCommunicator.java seems to set the home dir (config dir)
BEFORE parsing the args... then of course, setting it again,
this time correctly.

So I think that the section
" //first - pass the arguments to
our arg handler"
should be called BEFORE "setScHomeDir(osName);".
Otherwise, not only the empty "log" subdir will be created
in the wrong folder but the "DNS lookup" code will also be
compromised.

Vieri


#2

Hi,

Sorry to remind the list about this but it's a simple fix to a small bug.

Vieri

···

--- On Wed, 6/6/12, Vieri <rentorbuy@yahoo.com> wrote:

The attached patch should fix this
issue.

Vieri

--- On Wed, 6/6/12, Vieri <rentorbuy@yahoo.com> > wrote:
> --- On Tue, 6/5/12, Vieri <rentorbuy@yahoo.com> > > wrote:
>
> > Sorry for cross-posting but it seems
> > I'm not receiving e-mails from the users mailing
list.
> The
> > dev list seems to work OK and besides, the issue
I
> posted
> > here:
> >
> > http://java.net/nonav/projects/jitsi/lists/users/archive/2012-06/message/49
> >
> > is more of a dev question.
>
> SIPCommunicator.java seems to set the home dir (config
dir)
> BEFORE parsing the args... then of course, setting it
again,
> this time correctly.
>
> So I think that the section
> " //first - pass the arguments to
> our arg handler"
> should be called BEFORE "setScHomeDir(osName);".
> Otherwise, not only the empty "log" subdir will be
created
> in the wrong folder but the "DNS lookup" code will also
be
> compromised.
>
> Vieri
>
>


#3

Yup, thanks, it has not been forgotten :wink:

--sent from my mobile

···

On Aug 1, 2012 11:04 PM, "Vieri" <rentorbuy@yahoo.com> wrote:

Hi,

Sorry to remind the list about this but it's a simple fix to a small bug.

Vieri

--- On Wed, 6/6/12, Vieri <rentorbuy@yahoo.com> wrote:

> The attached patch should fix this
> issue.
>
> Vieri
>
> --- On Wed, 6/6/12, Vieri <rentorbuy@yahoo.com> > > wrote:
> > --- On Tue, 6/5/12, Vieri <rentorbuy@yahoo.com> > > > wrote:
> >
> > > Sorry for cross-posting but it seems
> > > I'm not receiving e-mails from the users mailing
> list.
> > The
> > > dev list seems to work OK and besides, the issue
> I
> > posted
> > > here:
> > >
> > >
http://java.net/nonav/projects/jitsi/lists/users/archive/2012-06/message/49
> > >
> > > is more of a dev question.
> >
> > SIPCommunicator.java seems to set the home dir (config
> dir)
> > BEFORE parsing the args... then of course, setting it
> again,
> > this time correctly.
> >
> > So I think that the section
> > " //first - pass the arguments to
> > our arg handler"
> > should be called BEFORE "setScHomeDir(osName);".
> > Otherwise, not only the empty "log" subdir will be
> created
> > in the wrong folder but the "DNS lookup" code will also
> be
> > compromised.
> >
> > Vieri
> >
> >