[jitsi-dev] Re: [jtisi-git] [jitsi/jitsi] e7467d: Adds new methods to AlertUIServiceImpl that show a...


#1

Hey Hristo

  Branch: refs/heads/master
  Home: https://github.com/jitsi/jitsi
  Commit: e7467d8a84fe412d57b1dbf591b83bc1f4affbb9

It's been a while since I've had my fingers on the NotificationService, but the methods in your new AlertService seem to be almost the same as in the good old NotificationService. Why can't we just use that?

Thanks,
Ingo


#2

Hi Hristo, Ingo,

The whole idea of the AlertUIService is that it's about UI. That's why it contained methods like showAlertDialog(), which allowed us to have too different user interface implementations for android and for desktop.

We've discussed this off-list with Hristo and maybe I've misguided him, but now when looking at the new methods, I also think they fit better in the NotificationService as Ingo suggests. We can define a new register method that takes a SystrayPopupMessageListener as a parameter. Then if we need an utility method that shows the notification, we'll best put it in the NotificationManager where we've already defined a lot of these. Hristo, does this make sense?

Cheers,
Yana

···

On May 8, 2013, at 9:40 PM, Ingo Bauersachs <ingo@jitsi.org> wrote:

Hey Hristo

Branch: refs/heads/master
Home: https://github.com/jitsi/jitsi
Commit: e7467d8a84fe412d57b1dbf591b83bc1f4affbb9

It's been a while since I've had my fingers on the NotificationService, but the methods in your new AlertService seem to be almost the same as in the good old NotificationService. Why can't we just use that?

Thanks,
Ingo