[jitsi-dev] Re: [jitsi~svn:9663] Stops flipping the local video display when dealing with a desktop sharin


#1

На 20.06.12 19:09, vincent_lucas@java.net написа:

Project: jitsi
Repository: svn
Revision: 9663
Author: vincent_lucas
Date: 2012-06-20 16:09:29 UTC
Link:

Log Message:
------------
Stops flipping the local video display when dealing with a desktop sharing.

Vincent, could you please explain why this is being done given that the local video display for desktop streaming/sharing is just an icon which is not being flipped? I mean the code shouldn't even pass through where the newly introduced flipped flag is read in the case of desktop streaming/sharing.


#2

Hey Lubo,

На 20.06.12 19:09, vincent_lucas@java.net написа:

Project: jitsi
Repository: svn
Revision: 9663
Author: vincent_lucas
Date: 2012-06-20 16:09:29 UTC
Link:

Log Message:
------------
Stops flipping the local video display when dealing with a desktop sharing.

Vincent, could you please explain why this is being done given that the
local video display for desktop streaming/sharing is just an icon which
is not being flipped? I mean the code shouldn't even pass through where
the newly introduced flipped flag is read in the case of desktop
streaming/sharing.

I've personally been seeing the preview for a while now and I was also
wondering why the icon had gone. Still, seeing the preview allowed me to
detect a bug that caused the whole screen to be shared during region
sharing in cases where one of the shared region's borders were outside
the screen boundaries.

In other words: I was seeing that my whole screen was being shared while
I only meant to share a small part. I am hence now wondering if we
shouldn't keep the preview in there.

Thoughts?

Emil

···

On 23.06.12 16:50, Lyubomir Marinov wrote:


#3

Hi Lyubomir,

Concerning the local video display, I had always been seeing the desktop video stream and was not aware that was a desktop icon.

Thus until today, since commit #9674 (imgstreaming/DataSource becomes SourceCloneable and is no more encapsulated into a CloneableCaptureDevicePullBufferDataSource) which by side effect re-enables the icon as the local video display.

Thereby, commit #9663 may be reverted.

Regards,
Vincent

···

On 06/25/2012 12:52 PM, Emil Ivov wrote:

Hey Lubo,

On 23.06.12 16:50, Lyubomir Marinov wrote:

На 20.06.12 19:09, vincent_lucas@java.net написа:

Project: jitsi
Repository: svn
Revision: 9663
Author: vincent_lucas
Date: 2012-06-20 16:09:29 UTC
Link:

Log Message:
------------
Stops flipping the local video display when dealing with a desktop sharing.

Vincent, could you please explain why this is being done given that the
local video display for desktop streaming/sharing is just an icon which
is not being flipped? I mean the code shouldn't even pass through where
the newly introduced flipped flag is read in the case of desktop
streaming/sharing.

I've personally been seeing the preview for a while now and I was also
wondering why the icon had gone. Still, seeing the preview allowed me to
detect a bug that caused the whole screen to be shared during region
sharing in cases where one of the shared region's borders were outside
the screen boundaries.

In other words: I was seeing that my whole screen was being shared while
I only meant to share a small part. I am hence now wondering if we
shouldn't keep the preview in there.

Thoughts?

Emil

--
Vincent Lucas, Ph.D. Jitsi developer
chenzo@jitsi.org http://jitsi.org