[jitsi-dev] Re: [jitsi~svn:9280] Avoids failing builds in case time server is down when signing windows fi


#1

Hey

I think Damian mentioned that the files simply have no timestamp when the timestamping server times out. Does it indeed fail?

Regards,
Ingo

···

On 29.12.2011, at 14:09, "yanas@java.net" <yanas@java.net> wrote:

Project: jitsi
Repository: svn
Revision: 9280
Author: yanas
Date: 2011-12-29 13:07:19 UTC
Link:

Log Message:
------------
Avoids failing builds in case time server is down when signing windows files.

Revisions:
----------
9280

Modified Paths:
---------------
trunk/resources/install/build.xml

Diffs:
------
Index: trunk/resources/install/build.xml

--- trunk/resources/install/build.xml (revision 9279)
+++ trunk/resources/install/build.xml (revision 9280)
@@ -887,7 +887,7 @@

    <target name="wix-sign-file" if="sign.cert.file">
        <exec executable="\{inst\.resrc\}/windows/signtool\.exe&quot; \- failonerror=&quot;true&quot;&gt; \+ failonerror=&quot;false&quot;&gt; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&lt;arg value=&quot;sign&quot; /&gt; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&lt;arg value=&quot;/d&quot; /&gt; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&lt;arg value=&quot;{application.name}" />


#2

Yes, it happend this night. Although there was a warning which I saw
and have mentioned, seems the binary returns error code which I
haven't checked and the build process stops. When I was checking this
I saw successful message and decided it is ok, but seems its not.

Regards
damencho

···

On Thu, Dec 29, 2011 at 4:50 PM, Bauersachs Ingo <ingo.bauersachs@fhnw.ch> wrote:

I think Damian mentioned that the files simply have no timestamp when the timestamping server times out. Does it indeed fail?


#3

Ah okay, thanks for the explanation.
It's not important for the dev/nightly-builds, but we should probably check now whether the timestamp is indeed present for the stable builds before putting them into the auto-updater.

Regards,
Ingo

···

On 29.12.2011, at 15:58, "Damian Minkov" <damencho@jitsi.org> wrote:

Yes, it happend this night. Although there was a warning which I saw
and have mentioned, seems the binary returns error code which I
haven't checked and the build process stops. When I was checking this
I saw successful message and decided it is ok, but seems its not.

Regards
damencho

On Thu, Dec 29, 2011 at 4:50 PM, Bauersachs Ingo > <ingo.bauersachs@fhnw.ch> wrote:

I think Damian mentioned that the files simply have no timestamp when the timestamping server times out. Does it indeed fail?