[jitsi-dev] Re: [jitsi~svn:9038] Loads the Java VM into Jitsi's run.exe in order to fix issue #963: Starti


#1

Hey Lyubo

Thanks for finishing this! I see you still had lots of work to do, sorry about that.

I just updated to the latest version and it crashes at startup. I think it's because of the missing JNICALL in the typedef of the create VM function. At least the VC crash handler mentions an invalid calling convention, and indeed, when the typedef looks like this:

typedef jint (JNICALL *JNICreateJavaVMFunc)(JavaVM **, void **, void *);

it's OK again.

Could please you take a look at this again?

Regards,
Ingo

···

@@ -1311,11 +1390,82 @@
static DWORD
Run_runJavaFromRuntimeLib(LPCTSTR runtimeLib, BOOL *searchForJava)
{
- if (Run_isFile(runtimeLib))
+ HMODULE hRuntimeLib
+ = Run_isFile(runtimeLib) ? LoadLibrary(runtimeLib) : NULL;
+ DWORD error;
+
+ if (hRuntimeLib)
     {
- /* TODO Auto-generated method stub */
+ typedef jint (*JNICreateJavaVMFunc)(JavaVM **, void **, void *);


#2

Ingo, thank you very much! I have not personally experienced such a
crash but I'm sure you are right. Please find your patch applied in
r9049.

···

2011/10/24 Bauersachs Ingo <ingo.bauersachs@fhnw.ch>:

I just updated to the latest version and it crashes at startup. I think it's because of the missing JNICALL in the typedef of the create VM function. At least the VC crash handler mentions an invalid calling convention, and indeed, when the typedef looks like this:


#3

I just updated to the latest version and it crashes at startup. I think
it's because of the missing JNICALL in the typedef of the create VM function.
At least the VC crash handler mentions an invalid calling convention, and
indeed, when the typedef looks like this:

Ingo, thank you very much! I have not personally experienced such a
crash but I'm sure you are right. Please find your patch applied in
r9049.

It's working again. Thanks!

Regards,
Ingo