[jitsi-dev] Re: [jitsi~svn:10542] Fixes crashes in the Outlook contact integration related to calling conve


#1

Thanks Lyubo, thats definitely better. However there's apparently still something wrong with the 32bit variant: as soon as it is one of the newer versions, I get "java.lang.UnsatisfiedLinkError: no LocalhostRetriever in java.library.path" exceptions... :frowning:

Ingo

路路路

-----Original Message-----
From: lubomir_m@java.net [mailto:lubomir_m@java.net]
Sent: Donnerstag, 28. Februar 2013 21:53
To: commits@jitsi.java.net
Subject: [jitsi~svn:10542] Fixes crashes in the Outlook contact integration
related to calling conve
Project: jitsi
Repository: svn
Revision: 10542
Author: lubomir_m
Date: 2013-02-28 20:53:13 UTC
Link:

Log Message: ------------ Fixes crashes in the Outlook contact
integration related to calling conventions.

Revisions:
----------
10542


#2

Thank you very much! I don't have that exception, I'm probably not doing the testing right. The problem could be that mapi32.dll changes the current directory which we used to have a fix for. I'll look into it asap.

路路路

-----Original Message-----
From: Ingo Bauersachs [mailto:ingo@sip-communicator.org] On Behalf Of

Thanks Lyubo, thats definitely better. However there's apparently still
something wrong with the 32bit variant: as soon as it is one of the newer
versions, I get "java.lang.UnsatisfiedLinkError: no LocalhostRetriever in
java.library.path" exceptions... :frowning:


#3

Hello Ingo, Lyubomir,

Thank you to both of you for the help.
Ingo has provided a patch to correct this change of directory. It is committed with Jisti r10545. It works on my different version of Windows 32 and 64 bits. Thus, please give it a try.

Regards,
Vincent

路路路

On 2/28/13 10:15 PM, Lyubomir Marinov wrote:

-----Original Message-----
From: Ingo Bauersachs [mailto:ingo@sip-communicator.org] On Behalf Of

Thanks Lyubo, thats definitely better. However there's apparently still
something wrong with the 32bit variant: as soon as it is one of the newer
versions, I get "java.lang.UnsatisfiedLinkError: no LocalhostRetriever in
java.library.path" exceptions... :frowning:

Thank you very much! I don't have that exception, I'm probably not doing the testing right. The problem could be that mapi32.dll changes the current directory which we used to have a fix for. I'll look into it asap.

--
Vincent Lucas, Ph.D. Jitsi developer
chenzo@jitsi.org http://jitsi.org


#4

Seems to work on Office 2010 32bit.

Not sure if this was introduced by your changes Vincent, but I find it a bit weird to get Firstname, Lastname and Company as options to call a found contact...
Also I have some contacts with E-Mail-addresses in their LDAP/Exchange format (/o=Company/ou=Exchange Administrative Group (FYD...)/cn=Recipients/cn=Displayname/). This happens when the contact was created from a GAL entry and the account is later deleted in Exchange/AD. Although this is valid E-Mail-address for Exchange, it's nothing Jitsi can handle. We shouldn't list it.

Ingo

路路路

-----Original Message-----
From: Vincent Lucas [mailto:chenzo@jitsi.org]
Thank you to both of you for the help.
Ingo has provided a patch to correct this change of directory. It is
committed with Jisti r10545. It works on my different version of Windows
32 and 64 bits. Thus, please give it a try.


#5

It appears to work for me on 64-bit Windows 8 with 32-bit Outlook 2013.

路路路

-----Original Message-----
From: Vincent Lucas [mailto:chenzo@jitsi.org]

Ingo has provided a patch to correct this change of directory. It is committed
with Jisti r10545. It works on my different version of Windows
32 and 64 bits. Thus, please give it a try.


#6

Enabling/Disabling the Outlook-Plugin multiple times in the Contact Sources options causes a JVM crash. Logs are attached.

Ingo

hs_err_pid23592.log (20.6 KB)

hs_err_pid26604.log (26.1 KB)

路路路

-----Original Message-----
From: Vincent Lucas [mailto:chenzo@jitsi.org]
Sent: Freitag, 1. M盲rz 2013 20:36
To: dev@jitsi.java.net
Subject: [jitsi-dev] Re: [jitsi~svn:10542] Fixes crashes in the Outlook
contact integration related to calling conve
Hello Ingo, Lyubomir,

Thank you to both of you for the help.
Ingo has provided a patch to correct this change of directory. It is
committed with Jisti r10545. It works on my different version of Windows
32 and 64 bits. Thus, please give it a try.

Regards,
Vincent

On 2/28/13 10:15 PM, Lyubomir Marinov wrote:

Ingo Bauersachs wrote on thats definitely better. However there's apparently still:
Thank you very much! I don't have that exception, I'm probably not doing

the testing right. The problem could be that mapi32.dll changes the current
directory which we used to have a fix for. I'll look into it asap.


#7

Enabling/Disabling the Outlook-Plugin multiple times in the Contact Sources
options causes a JVM crash. Logs are attached.

Patch for this. Main cause were a lot of mistakes with mixing char/wchar_t and deleted pointers that were forgotten to be set to NULL. I also moved the lock around the MAPI-Session to the session-files and also use it before accessing the session in a query. This avoids taking care in the java-code that a query is not performed after MAPIUnitialize is called.

Some of the stuff in the patch is not really needed for gcc, but as VC doesn't understand C99 I needed to move some dynamically stack-allocated arrays to the heap. Would be nice to have the VS project checked in, but also not needed.

Ingo

outlook-addrbook.patch (38.7 KB)


#8

Hey Ingo,

Is the latest build working for you? If so we can finally release :slight_smile:

Cheers,
Emil

路路路

On 02.03.13, 16:21, Ingo Bauersachs wrote:

Enabling/Disabling the Outlook-Plugin multiple times in the Contact Sources
options causes a JVM crash. Logs are attached.

Patch for this. Main cause were a lot of mistakes with mixing char/wchar_t and deleted pointers that were forgotten to be set to NULL. I also moved the lock around the MAPI-Session to the session-files and also use it before accessing the session in a query. This avoids taking care in the java-code that a query is not performed after MAPIUnitialize is called.

Some of the stuff in the patch is not really needed for gcc, but as VC doesn't understand C99 I needed to move some dynamically stack-allocated arrays to the heap. Would be nice to have the VS project checked in, but also not needed.

Ingo

--
https://jitsi.org


#9

The build from last night was working.

Freundliche Gr眉sse,
Ingo Bauersachs

-- sent from my mobile

路路路

Le 03.03.2013 脿 14:10, "Emil Ivov" <emcho@jitsi.org> a 茅crit :

Hey Ingo,

Is the latest build working for you? If so we can finally release :slight_smile:

Cheers,
Emil

On 02.03.13, 16:21, Ingo Bauersachs wrote:

Enabling/Disabling the Outlook-Plugin multiple times in the Contact Sources
options causes a JVM crash. Logs are attached.

Patch for this. Main cause were a lot of mistakes with mixing char/wchar_t and deleted pointers that were forgotten to be set to NULL. I also moved the lock around the MAPI-Session to the session-files and also use it before accessing the session in a query. This avoids taking care in the java-code that a query is not performed after MAPIUnitialize is called.

Some of the stuff in the patch is not really needed for gcc, but as VC doesn't understand C99 I needed to move some dynamically stack-allocated arrays to the heap. Would be nice to have the VS project checked in, but also not needed.

Ingo

--
https://jitsi.org