[jitsi-dev] Re: [jitsi~svn:10437] Adds some additional detail categories and labels for contact source deta


#1

Hey Yana

Ahm, objection: Hardcoded English strings.
If I get that right, these are labels for tooltips and therefore need to be localizable? Or, if these are some kind of identifiers, then I think they should be written as WORK, PERSONAL, POSTAL_CODE, etc.

Ingo

···

Project: jitsi
Repository: svn
Revision: 10437
Author: yanas
Date: 2013-02-06 16:20:30 UTC
Link:

Log Message:
------------
Adds some additional detail categories and labels for contact source details.

Revisions:
----------
10437

Modified Paths: ---------------
trunk/src/net/java/sip/communicator/service/contactsource/ContactDetail.j
ava


#2

Hey Ingo,

Yes, they're hardcoded right now, but I'll be implementing internationalization later. I thought I'd keep the LABEL_XXX name because we also have CATEGORY_XXX and I want to differentiate the two and also don't do a lot of changes. We should may be call it SUB_CATEGORY_XXX, but it's too long..

Cheers,
Yana

···

On Feb 6, 2013, at 6:08 PM, "Ingo Bauersachs" <ingo@jitsi.org> wrote:

Hey Yana

Ahm, objection: Hardcoded English strings.
If I get that right, these are labels for tooltips and therefore need to be localizable? Or, if these are some kind of identifiers, then I think they should be written as WORK, PERSONAL, POSTAL_CODE, etc.

Ingo

Project: jitsi
Repository: svn
Revision: 10437
Author: yanas
Date: 2013-02-06 16:20:30 UTC
Link:

Log Message:
------------
Adds some additional detail categories and labels for contact source details.

Revisions:
----------
10437

Modified Paths: ---------------
trunk/src/net/java/sip/communicator/service/contactsource/ContactDetail.j
ava


#3

Ahm, objection: Hardcoded English strings.
If I get that right, these are labels for tooltips and therefore need to

be

localizable? Or, if these are some kind of identifiers, then I think they
should be written as WORK, PERSONAL, POSTAL_CODE, etc.

Yes, they're hardcoded right now, but I'll be implementing
internationalization later.

What kind of later? The existing labels hang there for about two years
already, so please excuse my uneasy feeling about procrastination in the
trunk...

I thought I'd keep the LABEL_XXX name
because we also have CATEGORY_XXX and I want to differentiate the two
and also don't do a lot of changes. We should may be call it
SUB_CATEGORY_XXX, but it's too long..

Could they be converted to an enum SubCategory { Work, Personal, PostalCode,
... }? It causes a couple of changes, but would definitely be cleaner than
this type-unsafe constant-mess.

Cheers,
Yana

Ingo


#4

Hey Ingo,

Ahm, objection: Hardcoded English strings.
If I get that right, these are labels for tooltips and therefore need to

be

localizable? Or, if these are some kind of identifiers, then I think they
should be written as WORK, PERSONAL, POSTAL_CODE, etc.

Yes, they're hardcoded right now, but I'll be implementing
internationalization later.

What kind of later? The existing labels hang there for about two years
already, so please excuse my uneasy feeling about procrastination in the
trunk…

The kind of later today or tomorrow :slight_smile: I just had to commit my work, because this is part of a shared effort with Damian, so we had to be sure that we're on the same page about the properties we're handling and I really thought it won't do any harm.

And yes, it's there for about two years now and nobody complained about it and nobody fixed it, because we were busy with stuff people were complaining about or wanted implemented. Please feel completely free to implement it. Just send me a message, so I know that you'll be doing it.

I thought I'd keep the LABEL_XXX name
because we also have CATEGORY_XXX and I want to differentiate the two
and also don't do a lot of changes. We should may be call it
SUB_CATEGORY_XXX, but it's too long..

Could they be converted to an enum SubCategory { Work, Personal, PostalCode,
... }? It causes a couple of changes, but would definitely be cleaner than
this type-unsafe constant-mess.

Yes they could.

Cheers,
Yana

···

On Feb 6, 2013, at 6:50 PM, "Ingo Bauersachs" <ingo@jitsi.org> wrote:

Cheers,
Yana

Ingo


#5

I thought I'd keep the LABEL_XXX name
because we also have CATEGORY_XXX and I want to differentiate the two
and also don't do a lot of changes. We should may be call it
SUB_CATEGORY_XXX, but it's too long..

Could they be converted to an enum SubCategory { Work, Personal,
PostalCode, ... }? It causes a couple of changes, but would definitely
be cleaner than this type-unsafe constant-mess.

Yes they could.

Looks much better now with r10440. Thanks!

Ingo