[jitsi-dev] Re: [jitsi~svn:10278] Accept dates in XEP-0203 format for file transfers, fixes #JITSI-935


#1

We still /send/ the dates in XEP-0091 format, which is wrong according to the XEP-0096 (file transfers). If we change that however, file-transfers with older Jitsi-versions would break. Suggestion: leave as is for 2.0, change to the specification for 2.1/3.0 to allow time for users to migrate.

Other opinions?

Ingo

···

-----Original Message-----
From: ibauersachs@java.net [mailto:ibauersachs@java.net]
Sent: Dienstag, 15. Januar 2013 18:01
To: commits@jitsi.java.net
Subject: [jitsi~svn:10278] Accept dates in XEP-0203 format for file
transfers, fixes #JITSI-935
Project: jitsi
Repository: svn
Revision: 10278
Author: ibauersachs
Date: 2013-01-15 17:01:23 UTC
Link:

Log Message:
------------
Accept dates in XEP-0203 format for file transfers, fixes #JITSI-935

Revisions:
----------
10278


#2

Hello,

···

On Tue, Jan 15, 2013 at 7:09 PM, Ingo Bauersachs <ingo@jitsi.org> wrote:

We still /send/ the dates in XEP-0091 format, which is wrong according to
the XEP-0096 (file transfers). If we change that however, file-transfers
with older Jitsi-versions would break. Suggestion: leave as is for 2.0,
change to the specification for 2.1/3.0 to allow time for users to migrate.

Other opinions?

Soon before a new stable release seems like a convenient time to make
changes that break interoperability -- the period of time during which
stable and the nightlies will be incompatible is relatively short. So I'd
say change it now.

Boris


#3

Hey folks,

Hello,

    We still /send/ the dates in XEP-0091 format, which is wrong
    according to the XEP-0096 (file transfers). If we change that
    however, file-transfers with older Jitsi-versions would break.
    Suggestion: leave as is for 2.0, change to the specification for
    2.1/3.0 to allow time for users to migrate.

    Other opinions?

Soon before a new stable release seems like a convenient time to make
changes that break interoperability -- the period of time during which
stable and the nightlies will be incompatible is relatively short. So
I'd say change it now.

We've just talked this through with Ingo and the situation is the following:

* 1.0 breaks when receiving proper dates.
* current-nightlies can receive anything but can't send to other clients
* with the change we will be able to receive anything and send to anyone
except for 1.0 clients.

Applying the change now would mean 1.0 would break every time it
receives a message from 2.0.

Ingos original suggestion would mean that, after we commit the fix there
will be less 1.0s out there. We'll have more 2.0s which will be able to
send and receive to Jitsi even after it updates its sending dates.

I concur with that. Let's keep the change for 2.x.

Cheers,
Emil

···

On 15.01.13, 20:44, Boris Grozev wrote:

On Tue, Jan 15, 2013 at 7:09 PM, Ingo Bauersachs <ingo@jitsi.org > <mailto:ingo@jitsi.org>> wrote:

Boris

--
https://jitsi.org