[jitsi-dev] Re: [jitsi~svn:10107] Renames windows launcher name to one using the application name.


#1

Hey

Thank you! Finally! :slight_smile:

Just a quick comment:

Index: trunk/resources/install/build.xml

--- trunk/resources/install/build.xml (revision 10106)
+++ trunk/resources/install/build.xml (revision 10107)

[...]

+ <!-- removes '_' from app.exe.filename if any -->
+ <propertyregex property="app.exe.filename"
+ input="${app.exe.filename}"
+ regexp="-"
+ replace=""
+ override="true"
+ global="true"
+ defaultValue="${app.exe.filename}"/>

The regexp-attribute should probably be _ instead of the -. But couldn't those three propertyregex not anyway be combined into one? Like regexp="[ _-]"?

Regards,
Ingo