[jitsi-dev] Re: Jitsi prevents key bindings from working in other applications


#1

(This is my first time posting on mailing list. I'm trying to reply to this
thread: http://lists.jitsi.org/pipermail/dev/2013-February/003631.html)

Even though this is old thread, I think it's important so I'm adding my
comments on it (I just found it using search).

I think global keybindings should be disabled by default (currently they are
enabled by default).

1) They clash with other programs. For example, in Firefox Ctrl+Shift+A is
used to open Add-ons page and Ctrl+Shift+P is used to open private browsing
windows. I can't use those keybindings in Firefox if they are set as global
keybindings in Jitsi.

The worst part is that unless user has already dived into Jitsi's advanced
settings, they can't guess why keybindings don't work. I used hours to find
out why some keybindings didn't work and finally by chance I noticed that I
didn't have any problems when Jitsi was closed.

2) If global keybindings are important for some people, they can set them
themselves. I believe that most users don't expect Ctrl+Shift+A to answer to
incoming call but use mouse instead so it's useless to enable them by
default.


#2

I'd have to agree with this. Jitsi shouldn't be setting Global
keybindings that prevent other program's keybindings working, at least
not unless the user specifically chooses to do so themselves.
Keybindings should only apply when Jitsi has focus, so if an incoming
call pops up a window that gives Jitsi focus, then Ctrl-Shift-A can be
used to answer but as William says, I can't imagine many users opting
to use complicated keybindings rather than just clicking on the Answer
button.

Regards

Derek

···

On 25 February 2014 09:00, William Linna <william.linna@kapsi.fi> wrote:

(This is my first time posting on mailing list. I'm trying to reply to this
thread: http://lists.jitsi.org/pipermail/dev/2013-February/003631.html)

Even though this is old thread, I think it's important so I'm adding my
comments on it (I just found it using search).

I think global keybindings should be disabled by default (currently they are
enabled by default).

1) They clash with other programs. For example, in Firefox Ctrl+Shift+A is
used to open Add-ons page and Ctrl+Shift+P is used to open private browsing
windows. I can't use those keybindings in Firefox if they are set as global
keybindings in Jitsi.

The worst part is that unless user has already dived into Jitsi's advanced
settings, they can't guess why keybindings don't work. I used hours to find
out why some keybindings didn't work and finally by chance I noticed that I
didn't have any problems when Jitsi was closed.

2) If global keybindings are important for some people, they can set them
themselves. I believe that most users don't expect Ctrl+Shift+A to answer to
incoming call but use mouse instead so it's useless to enable them by
default.

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#3

I have to agree, I too stumbled upon the conflict with firefox
bindings. Also took me a while to figure out what was going on and I
also think that this should be disabled by default.

Regards,
Philipp

···

On Tue, 25 Feb 2014 10:01:22 +0000 Derek Moss <dmts@stoptheviolence.co.uk> wrote:

I'd have to agree with this. Jitsi shouldn't be setting Global
keybindings that prevent other program's keybindings working, at least
not unless the user specifically chooses to do so themselves.
Keybindings should only apply when Jitsi has focus, so if an incoming
call pops up a window that gives Jitsi focus, then Ctrl-Shift-A can be
used to answer but as William says, I can't imagine many users opting
to use complicated keybindings rather than just clicking on the Answer
button.

Regards

Derek

On 25 February 2014 09:00, William Linna <william.linna@kapsi.fi> > wrote:
> (This is my first time posting on mailing list. I'm trying to reply
> to this thread:
> http://lists.jitsi.org/pipermail/dev/2013-February/003631.html)
>
> Even though this is old thread, I think it's important so I'm
> adding my comments on it (I just found it using search).
>
> I think global keybindings should be disabled by default (currently
> they are enabled by default).
>
> 1) They clash with other programs. For example, in Firefox
> Ctrl+Shift+A is used to open Add-ons page and Ctrl+Shift+P is used
> to open private browsing windows. I can't use those keybindings in
> Firefox if they are set as global keybindings in Jitsi.
>
> The worst part is that unless user has already dived into Jitsi's
> advanced settings, they can't guess why keybindings don't work. I
> used hours to find out why some keybindings didn't work and finally
> by chance I noticed that I didn't have any problems when Jitsi was
> closed.
>
> 2) If global keybindings are important for some people, they can
> set them themselves. I believe that most users don't expect
> Ctrl+Shift+A to answer to incoming call but use mouse instead so
> it's useless to enable them by default.

--
JID: murks@jit.si


#4

A good solution here would be to let these pass through in cases where
they don't server any purpose in Jitsi (e.g. answering a call or
hanging up). Others could indeed be disabled (e.g. hiding and showing
the contact list).

Anyone interested in working on this?

···

On Tue, Feb 25, 2014 at 1:13 PM, Philipp Überbacher <murks@tuxfamily.org> wrote:

On Tue, 25 Feb 2014 10:01:22 +0000 > Derek Moss <dmts@stoptheviolence.co.uk> wrote:

I'd have to agree with this. Jitsi shouldn't be setting Global
keybindings that prevent other program's keybindings working, at least
not unless the user specifically chooses to do so themselves.
Keybindings should only apply when Jitsi has focus, so if an incoming
call pops up a window that gives Jitsi focus, then Ctrl-Shift-A can be
used to answer but as William says, I can't imagine many users opting
to use complicated keybindings rather than just clicking on the Answer
button.

Regards

Derek

On 25 February 2014 09:00, William Linna <william.linna@kapsi.fi> >> wrote:
> (This is my first time posting on mailing list. I'm trying to reply
> to this thread:
> http://lists.jitsi.org/pipermail/dev/2013-February/003631.html)
>
> Even though this is old thread, I think it's important so I'm
> adding my comments on it (I just found it using search).
>
> I think global keybindings should be disabled by default (currently
> they are enabled by default).
>
> 1) They clash with other programs. For example, in Firefox
> Ctrl+Shift+A is used to open Add-ons page and Ctrl+Shift+P is used
> to open private browsing windows. I can't use those keybindings in
> Firefox if they are set as global keybindings in Jitsi.
>
> The worst part is that unless user has already dived into Jitsi's
> advanced settings, they can't guess why keybindings don't work. I
> used hours to find out why some keybindings didn't work and finally
> by chance I noticed that I didn't have any problems when Jitsi was
> closed.
>
> 2) If global keybindings are important for some people, they can
> set them themselves. I believe that most users don't expect
> Ctrl+Shift+A to answer to incoming call but use mouse instead so
> it's useless to enable them by default.

I have to agree, I too stumbled upon the conflict with firefox
bindings. Also took me a while to figure out what was going on and I
also think that this should be disabled by default.

Regards,
Philipp

--
JID: murks@jit.si

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
https://jitsi.org


#5

I am interested!

I haven't looked at Jitsi's source code yet though. I'll take a look at this
when I'm home. I am interested in contributing though :slight_smile:

···

On Wednesday, February 26, 2014 12:43:00 Emil Ivov wrote:

A good solution here would be to let these pass through in cases where
they don't server any purpose in Jitsi (e.g. answering a call or
hanging up). Others could indeed be disabled (e.g. hiding and showing
the contact list).

Anyone interested in working on this?

On Tue, Feb 25, 2014 at 1:13 PM, Philipp Überbacher <murks@tuxfamily.org> wrote:
> On Tue, 25 Feb 2014 10:01:22 +0000 > > > > Derek Moss <dmts@stoptheviolence.co.uk> wrote:
>> I'd have to agree with this. Jitsi shouldn't be setting Global
>> keybindings that prevent other program's keybindings working, at least
>> not unless the user specifically chooses to do so themselves.
>> Keybindings should only apply when Jitsi has focus, so if an incoming
>> call pops up a window that gives Jitsi focus, then Ctrl-Shift-A can be
>> used to answer but as William says, I can't imagine many users opting
>> to use complicated keybindings rather than just clicking on the Answer
>> button.
>>
>> Regards
>>
>> Derek
>>
>> On 25 February 2014 09:00, William Linna <william.linna@kapsi.fi> > >> > >> wrote:
>> > (This is my first time posting on mailing list. I'm trying to reply
>> > to this thread:
>> > http://lists.jitsi.org/pipermail/dev/2013-February/003631.html)
>> >
>> > Even though this is old thread, I think it's important so I'm
>> > adding my comments on it (I just found it using search).
>> >
>> > I think global keybindings should be disabled by default (currently
>> > they are enabled by default).
>> >
>> > 1) They clash with other programs. For example, in Firefox
>> > Ctrl+Shift+A is used to open Add-ons page and Ctrl+Shift+P is used
>> > to open private browsing windows. I can't use those keybindings in
>> > Firefox if they are set as global keybindings in Jitsi.
>> >
>> > The worst part is that unless user has already dived into Jitsi's
>> > advanced settings, they can't guess why keybindings don't work. I
>> > used hours to find out why some keybindings didn't work and finally
>> > by chance I noticed that I didn't have any problems when Jitsi was
>> > closed.
>> >
>> > 2) If global keybindings are important for some people, they can
>> > set them themselves. I believe that most users don't expect
>> > Ctrl+Shift+A to answer to incoming call but use mouse instead so
>> > it's useless to enable them by default.
>
> I have to agree, I too stumbled upon the conflict with firefox
> bindings. Also took me a while to figure out what was going on and I
> also think that this should be disabled by default.
>
> Regards,
> Philipp
>
>
> --
> JID: murks@jit.si
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev


#6

I have now implemented fix that allows global shortcuts to exist while allowing
same keybindings to work in other programs. Global shortcuts are now enabled
and disabled when they are usable. Show contact list is now disabled by
default.

Should I post this as pull request in GitHub? How should I format patch? I
used command 'git format-patch HEAD^1' to generate this patch.

I attached patch as attachment in this email.

0001-Most-global-shortcuts-no-longer-block-keybindings-in.patch (8.22 KB)

···

On Wednesday 26 February 2014 12:43:00 Emil Ivov wrote:

A good solution here would be to let these pass through in cases where
they don't server any purpose in Jitsi (e.g. answering a call or
hanging up). Others could indeed be disabled (e.g. hiding and showing
the contact list).

Anyone interested in working on this?

On Tue, Feb 25, 2014 at 1:13 PM, Philipp Überbacher <murks@tuxfamily.org> wrote:
> On Tue, 25 Feb 2014 10:01:22 +0000 > > > > Derek Moss <dmts@stoptheviolence.co.uk> wrote:
>> I'd have to agree with this. Jitsi shouldn't be setting Global
>> keybindings that prevent other program's keybindings working, at least
>> not unless the user specifically chooses to do so themselves.
>> Keybindings should only apply when Jitsi has focus, so if an incoming
>> call pops up a window that gives Jitsi focus, then Ctrl-Shift-A can be
>> used to answer but as William says, I can't imagine many users opting
>> to use complicated keybindings rather than just clicking on the Answer
>> button.
>>
>> Regards
>>
>> Derek
>>
>> On 25 February 2014 09:00, William Linna <william.linna@kapsi.fi> > >> > >> wrote:
>> > (This is my first time posting on mailing list. I'm trying to reply
>> > to this thread:
>> > http://lists.jitsi.org/pipermail/dev/2013-February/003631.html)
>> >
>> > Even though this is old thread, I think it's important so I'm
>> > adding my comments on it (I just found it using search).
>> >
>> > I think global keybindings should be disabled by default (currently
>> > they are enabled by default).
>> >
>> > 1) They clash with other programs. For example, in Firefox
>> > Ctrl+Shift+A is used to open Add-ons page and Ctrl+Shift+P is used
>> > to open private browsing windows. I can't use those keybindings in
>> > Firefox if they are set as global keybindings in Jitsi.
>> >
>> > The worst part is that unless user has already dived into Jitsi's
>> > advanced settings, they can't guess why keybindings don't work. I
>> > used hours to find out why some keybindings didn't work and finally
>> > by chance I noticed that I didn't have any problems when Jitsi was
>> > closed.
>> >
>> > 2) If global keybindings are important for some people, they can
>> > set them themselves. I believe that most users don't expect
>> > Ctrl+Shift+A to answer to incoming call but use mouse instead so
>> > it's useless to enable them by default.
>
> I have to agree, I too stumbled upon the conflict with firefox
> bindings. Also took me a while to figure out what was going on and I
> also think that this should be disabled by default.
>
> Regards,
> Philipp
>
>
> --
> JID: murks@jit.si
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev


#7

Hey

Sorry for the late reply and thanks for your work!

Some comments:
- Most lines are too long (80 chars is the limit)
- Please leave the default shortcut for the contact list for the time being
- If you haven't already signed the BCA [1], please do so and send it to
emcho@jitsi.org

A pull request on Github to merge is good, an attached patch here on the
list will do as well.

Ingo

[1] http://bluejimp.com/bca.pdf

···

-----Original Message-----
From: dev-bounces@jitsi.org [mailto:dev-bounces@jitsi.org] On Behalf Of
William Linna
Sent: Donnerstag, 20. März 2014 18:39
To: Jitsi Developers
Subject: Re: [jitsi-dev] Jitsi prevents key bindings from working in other
applications
I have now implemented fix that allows global shortcuts to exist while
allowing same keybindings to work in other programs. Global shortcuts
are now enabled and disabled when they are usable. Show contact list is
now disabled by default.

Should I post this as pull request in GitHub? How should I format patch? I
used command 'git format-patch HEAD^1' to generate this patch.

I attached patch as attachment in this email.

On Wednesday 26 February 2014 12:43:00 Emil Ivov wrote:

A good solution here would be to let these pass through in cases where
they don't server any purpose in Jitsi (e.g. answering a call or
hanging up). Others could indeed be disabled (e.g. hiding and showing
the contact list).

Anyone interested in working on this?

On Tue, Feb 25, 2014 at 1:13 PM, Philipp Überbacher <murks@tuxfamily.org> > wrote:

On Tue, 25 Feb 2014 10:01:22 +0000 >>> >>> Derek Moss <dmts@stoptheviolence.co.uk> wrote:

I'd have to agree with this. Jitsi shouldn't be setting Global
keybindings that prevent other program's keybindings working, at least
not unless the user specifically chooses to do so themselves.
Keybindings should only apply when Jitsi has focus, so if an incoming
call pops up a window that gives Jitsi focus, then Ctrl-Shift-A can be
used to answer but as William says, I can't imagine many users opting
to use complicated keybindings rather than just clicking on the Answer
button.

Regards

Derek

On 25 February 2014 09:00, William Linna <william.linna@kapsi.fi> >>>> >>>> wrote:

(This is my first time posting on mailing list. I'm trying to reply
to this thread:
http://lists.jitsi.org/pipermail/dev/2013-February/003631.html)

Even though this is old thread, I think it's important so I'm
adding my comments on it (I just found it using search).

I think global keybindings should be disabled by default (currently
they are enabled by default).

1) They clash with other programs. For example, in Firefox
Ctrl+Shift+A is used to open Add-ons page and Ctrl+Shift+P is used
to open private browsing windows. I can't use those keybindings in
Firefox if they are set as global keybindings in Jitsi.

The worst part is that unless user has already dived into Jitsi's
advanced settings, they can't guess why keybindings don't work. I
used hours to find out why some keybindings didn't work and finally
by chance I noticed that I didn't have any problems when Jitsi was
closed.

2) If global keybindings are important for some people, they can
set them themselves. I believe that most users don't expect
Ctrl+Shift+A to answer to incoming call but use mouse instead so
it's useless to enable them by default.

I have to agree, I too stumbled upon the conflict with firefox
bindings. Also took me a while to figure out what was going on and I
also think that this should be disabled by default.

Regards,
Philipp

--
JID: murks@jit.si

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev