[jitsi-dev] PseudoTCP patch


#1

Hi guys,
I've some minor bug fixes to PseudoTCP that I hope you guys are willing to commit to the repository. The things I've fixed are:

* Prevent multiple executions of Agent.free() on the same instance (since free() can be called by an external object as well as by finalize().

* Fixed a NullPointerException that occurred for instance when an SSLSocket called getTcpNoDelay() on PseudoTCPSocket. PseudoTcpSocketImpl returned null but the SSLSocket assumed it would be true/false.

* Improved logging to better detect if someone is trying to get some other option that would return null.

Best Regards
Carl

Best Regards
Carl Hasselskog
Co-founder and CEO
Degoo Backup AB
carl@degoo.com<mailto:carl@degoo.com>
Phone: +46 73 070 1821
http://degoo.com<http://degoo.com/>
http://twitter.com/#!/DegooBackup

Patch-2013-03-22.patch (2.97 KB)


#2

Hi Carl,

Hi guys,

I’ve some minor bug fixes to PseudoTCP that I hope you guys are willing

to commit to the repository. The things I’ve fixed are:

· Prevent multiple executions of Agent.free() on the same instance

(since free() can be called by an external object as well as by finalize().

· Fixed a NullPointerException that occurred for instance when an

SSLSocket called getTcpNoDelay() on PseudoTCPSocket. PseudoTcpSocketImpl
returned null but the SSLSocket assumed it would be true/false.

· Improved logging to better detect if someone is trying to get

some other option that would return null.

Best Regards

Carl

Best Regards

Carl Hasselskog

Co-founder and CEO

Degoo Backup AB

carl@degoo.com

Phone: +46 73 070 1821

http://degoo.com

http://twitter.com/#!/DegooBackup

Thanks for the patch! I agree with PseduoTcp changes except the braces
formating in if statements and I've commited them.

Someone else would have to take a look on those made to the Agent, as I'm
not familiar enough with it.

···

2013/3/22 Carl Hasselskog <carl@degoo.com>

--
Regards,
Pawel