[jitsi-dev] private messages that shouldn't be private


#1

Hey,

First of all, thank you Danny for adding IRC support in Jitsi, it's
awesome, I love it and I think it's a fundamental feature that Jitsi was
missing for a long time.

That said, I think I'm having a small issue, and I wanted to ask if
others experience the same thing or is it just me. I'm building Jitsi
from github. I'm a few commits behind but not so many usually.

The problem: I'm not sure if it's specific to IRC rooms or with rooms in
general. Sometimes, when members of a room talk, their messages appear
as private messages to me. So they get added to my contact list etc.

Is this something that others have observed as well? Does anybody have a
clue where it may come from?

Thanks!

Cheers,
George


#2

Hey George,

I have noticed something similar. I haven't pinned it down exactly, but
I think I can reproduce it in the following way.

1. I have 1 IRC accounted fully connected and I've joined some chat
rooms there. (Preferrably busy chat rooms, since we need messages
arriving regularly.)
2. I enable another IRC account, such that it is in the process of
connecting.

At that point I may, for a few seconds, receive messages as private
messages that should just be plain chat room messages.
This period is extended when the process of connecting to an IRC server
takes a long time.

Up to now, I think I've only experienced this during some connection
process.

Could the above apply for you too? Or are you sure that it has happened
without any account in the process of connecting?
Also, is this a lasting problem or is it gone in a few seconds?

I haven't exactly put my finger on this, so I would be grateful for any
additional clues. I am pretty sure that this is an issue in the IRC
client library, but I haven't reported it yet.

Danny

···

On 25-11-14 15:10, George Politis wrote:

Hey,

First of all, thank you Danny for adding IRC support in Jitsi, it's
awesome, I love it and I think it's a fundamental feature that Jitsi was
missing for a long time.

That said, I think I'm having a small issue, and I wanted to ask if
others experience the same thing or is it just me. I'm building Jitsi
from github. I'm a few commits behind but not so many usually.

The problem: I'm not sure if it's specific to IRC rooms or with rooms in
general. Sometimes, when members of a room talk, their messages appear
as private messages to me. So they get added to my contact list etc.

Is this something that others have observed as well? Does anybody have a
clue where it may come from?

Thanks!

Cheers,
George

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#3

Hey Danny,

Hey George,

I have noticed something similar.

I'm glad I'm not the only one :slight_smile:

I haven't pinned it down exactly, but
I think I can reproduce it in the following way.

1. I have 1 IRC accounted fully connected and I've joined some chat
rooms there. (Preferrably busy chat rooms, since we need messages
arriving regularly.)
2. I enable another IRC account, such that it is in the process of
connecting.

At that point I may, for a few seconds, receive messages as private
messages that should just be plain chat room messages.
This period is extended when the process of connecting to an IRC server
takes a long time.

Up to now, I think I've only experienced this during some connection
process.

Could the above apply for you too?

Yes!

Or are you sure that it has happened
without any account in the process of connecting?

No, I'm not sure. I have 5 IRC accounts and I join some busy rooms, so
condition 1 is met. I'm also on a poor connection for now, so reconnects
_might_ be happening without me noticing.

I'll give it another shot as soon as I'm on a more stable connection.

Also, is this a lasting problem or is it gone in a few seconds?

This is a lasting problem from my (the user's) perspective, but I might
be reconnecting without noticing because of my crappy connection.

Thank you!

···

On 25/11/2014 19:45, Danny van Heumen wrote:

-
George

I haven't exactly put my finger on this, so I would be grateful for any
additional clues. I am pretty sure that this is an issue in the IRC
client library, but I haven't reported it yet.

Danny

On 25-11-14 15:10, George Politis wrote:

Hey,

First of all, thank you Danny for adding IRC support in Jitsi, it's
awesome, I love it and I think it's a fundamental feature that Jitsi was
missing for a long time.

That said, I think I'm having a small issue, and I wanted to ask if
others experience the same thing or is it just me. I'm building Jitsi
from github. I'm a few commits behind but not so many usually.

The problem: I'm not sure if it's specific to IRC rooms or with rooms in
general. Sometimes, when members of a room talk, their messages appear
as private messages to me. So they get added to my contact list etc.

Is this something that others have observed as well? Does anybody have a
clue where it may come from?

Thanks!

Cheers,
George

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#4

Hey Danny,

Hey George,

I have noticed something similar.

I'm glad I'm not the only one :slight_smile:

Well, I was starting to wonder the same. It happens to me almost never.
In fact, I almost forgot about this bug.

I haven't pinned it down exactly, but
I think I can reproduce it in the following way.

1. I have 1 IRC accounted fully connected and I've joined some chat
rooms there. (Preferrably busy chat rooms, since we need messages
arriving regularly.)
2. I enable another IRC account, such that it is in the process of
connecting.

At that point I may, for a few seconds, receive messages as private
messages that should just be plain chat room messages.
This period is extended when the process of connecting to an IRC server
takes a long time.

Up to now, I think I've only experienced this during some connection
process.

Could the above apply for you too?

Yes!

Or are you sure that it has happened
without any account in the process of connecting?

No, I'm not sure. I have 5 IRC accounts and I join some busy rooms, so
condition 1 is met. I'm also on a poor connection for now, so reconnects
_might_ be happening without me noticing.

I'll give it another shot as soon as I'm on a more stable connection.

Or maybe you could check with Jitsi if it happens to see whether some
IRC account is reconnecting. I do set "REGISTERING" state during the
connection process, so it may be easy to see.

A stable connection will make this problem almost invisible, so for the
purpose of debugging it doesn't add much. It does improve user
experience though :slight_smile:

Also, is this a lasting problem or is it gone in a few seconds?

This is a lasting problem from my (the user's) perspective, but I might
be reconnecting without noticing because of my crappy connection.

Well, given that this starts upon connecting and stop when finished
connecting, it isn't inconceivable that errors during the connection
process prevent this faulty state from getting fixed.

I'm going to have another look at this issue. AFAIK this is the only
remaining issue for which I'm not entirely sure that I am causing it. :stuck_out_tongue:

Danny

···

On 26-11-14 11:38, George Politis wrote:

On 25/11/2014 19:45, Danny van Heumen wrote:

Thank you!

-
George

I haven't exactly put my finger on this, so I would be grateful for any
additional clues. I am pretty sure that this is an issue in the IRC
client library, but I haven't reported it yet.

Danny

On 25-11-14 15:10, George Politis wrote:

Hey,

First of all, thank you Danny for adding IRC support in Jitsi, it's
awesome, I love it and I think it's a fundamental feature that Jitsi was
missing for a long time.

That said, I think I'm having a small issue, and I wanted to ask if
others experience the same thing or is it just me. I'm building Jitsi
from github. I'm a few commits behind but not so many usually.

The problem: I'm not sure if it's specific to IRC rooms or with rooms in
general. Sometimes, when members of a room talk, their messages appear
as private messages to me. So they get added to my contact list etc.

Is this something that others have observed as well? Does anybody have a
clue where it may come from?

Thanks!

Cheers,
George

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#5

Hi George,

I think I may have found the fix for this issue.

I've committed a fixed irc-api client library.
(https://github.com/jitsi/jitsi/commit/c0cebfe7c11ba5de1c9c4dbd873f79826a51ee98)
For reference, details on the cause and the proposed fix can be found
here: https://code.google.com/p/irc-api/issues/detail?id=20

Could you test this to see if it solves the problem for you?

Thanks in advance,
Danny

···

On 26-11-14 20:50, Danny van Heumen wrote:

On 26-11-14 11:38, George Politis wrote:

Hey Danny,

On 25/11/2014 19:45, Danny van Heumen wrote:

Hey George,

I have noticed something similar.

I'm glad I'm not the only one :slight_smile:

Well, I was starting to wonder the same. It happens to me almost never.
In fact, I almost forgot about this bug.

I haven't pinned it down exactly, but
I think I can reproduce it in the following way.

1. I have 1 IRC accounted fully connected and I've joined some chat
rooms there. (Preferrably busy chat rooms, since we need messages
arriving regularly.)
2. I enable another IRC account, such that it is in the process of
connecting.

At that point I may, for a few seconds, receive messages as private
messages that should just be plain chat room messages.
This period is extended when the process of connecting to an IRC server
takes a long time.

Up to now, I think I've only experienced this during some connection
process.

Could the above apply for you too?

Yes!

Or are you sure that it has happened
without any account in the process of connecting?

No, I'm not sure. I have 5 IRC accounts and I join some busy rooms, so
condition 1 is met. I'm also on a poor connection for now, so reconnects
_might_ be happening without me noticing.

I'll give it another shot as soon as I'm on a more stable connection.

Or maybe you could check with Jitsi if it happens to see whether some
IRC account is reconnecting. I do set "REGISTERING" state during the
connection process, so it may be easy to see.

A stable connection will make this problem almost invisible, so for the
purpose of debugging it doesn't add much. It does improve user
experience though :slight_smile:

Also, is this a lasting problem or is it gone in a few seconds?

This is a lasting problem from my (the user's) perspective, but I might
be reconnecting without noticing because of my crappy connection.

Well, given that this starts upon connecting and stop when finished
connecting, it isn't inconceivable that errors during the connection
process prevent this faulty state from getting fixed.

I'm going to have another look at this issue. AFAIK this is the only
remaining issue for which I'm not entirely sure that I am causing it. :stuck_out_tongue:

Danny

Thank you!

-
George

I haven't exactly put my finger on this, so I would be grateful for any
additional clues. I am pretty sure that this is an issue in the IRC
client library, but I haven't reported it yet.

Danny

On 25-11-14 15:10, George Politis wrote:

Hey,

First of all, thank you Danny for adding IRC support in Jitsi, it's
awesome, I love it and I think it's a fundamental feature that Jitsi was
missing for a long time.

That said, I think I'm having a small issue, and I wanted to ask if
others experience the same thing or is it just me. I'm building Jitsi
from github. I'm a few commits behind but not so many usually.

The problem: I'm not sure if it's specific to IRC rooms or with rooms in
general. Sometimes, when members of a room talk, their messages appear
as private messages to me. So they get added to my contact list etc.

Is this something that others have observed as well? Does anybody have a
clue where it may come from?

Thanks!

Cheers,
George

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#6

Awesome, I'm testing right now!

···

On 26/11/2014 23:35, Danny van Heumen wrote:

Hi George,

I think I may have found the fix for this issue.

I've committed a fixed irc-api client library.
(https://github.com/jitsi/jitsi/commit/c0cebfe7c11ba5de1c9c4dbd873f79826a51ee98)
For reference, details on the cause and the proposed fix can be found
here: https://code.google.com/p/irc-api/issues/detail?id=20

Could you test this to see if it solves the problem for you?

Thanks in advance,
Danny

On 26-11-14 20:50, Danny van Heumen wrote:

On 26-11-14 11:38, George Politis wrote:

Hey Danny,

On 25/11/2014 19:45, Danny van Heumen wrote:

Hey George,

I have noticed something similar.

I'm glad I'm not the only one :slight_smile:

Well, I was starting to wonder the same. It happens to me almost never.
In fact, I almost forgot about this bug.

I haven't pinned it down exactly, but
I think I can reproduce it in the following way.

1. I have 1 IRC accounted fully connected and I've joined some chat
rooms there. (Preferrably busy chat rooms, since we need messages
arriving regularly.)
2. I enable another IRC account, such that it is in the process of
connecting.

At that point I may, for a few seconds, receive messages as private
messages that should just be plain chat room messages.
This period is extended when the process of connecting to an IRC server
takes a long time.

Up to now, I think I've only experienced this during some connection
process.

Could the above apply for you too?

Yes!

Or are you sure that it has happened
without any account in the process of connecting?

No, I'm not sure. I have 5 IRC accounts and I join some busy rooms, so
condition 1 is met. I'm also on a poor connection for now, so reconnects
_might_ be happening without me noticing.

I'll give it another shot as soon as I'm on a more stable connection.

Or maybe you could check with Jitsi if it happens to see whether some
IRC account is reconnecting. I do set "REGISTERING" state during the
connection process, so it may be easy to see.

A stable connection will make this problem almost invisible, so for the
purpose of debugging it doesn't add much. It does improve user
experience though :slight_smile:

Also, is this a lasting problem or is it gone in a few seconds?

This is a lasting problem from my (the user's) perspective, but I might
be reconnecting without noticing because of my crappy connection.

Well, given that this starts upon connecting and stop when finished
connecting, it isn't inconceivable that errors during the connection
process prevent this faulty state from getting fixed.

I'm going to have another look at this issue. AFAIK this is the only
remaining issue for which I'm not entirely sure that I am causing it. :stuck_out_tongue:

Danny

Thank you!

-
George

I haven't exactly put my finger on this, so I would be grateful for any
additional clues. I am pretty sure that this is an issue in the IRC
client library, but I haven't reported it yet.

Danny

On 25-11-14 15:10, George Politis wrote:

Hey,

First of all, thank you Danny for adding IRC support in Jitsi, it's
awesome, I love it and I think it's a fundamental feature that Jitsi was
missing for a long time.

That said, I think I'm having a small issue, and I wanted to ask if
others experience the same thing or is it just me. I'm building Jitsi
from github. I'm a few commits behind but not so many usually.

The problem: I'm not sure if it's specific to IRC rooms or with rooms in
general. Sometimes, when members of a room talk, their messages appear
as private messages to me. So they get added to my contact list etc.

Is this something that others have observed as well? Does anybody have a
clue where it may come from?

Thanks!

Cheers,
George

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#7

No issues so far; maybe it's a bit premature to say but seems like the
issue's been fixed. I'll keep an eye on it for a while. Thank you Danny,
this is awesome!

···

On 27/11/2014 11:07, George Politis wrote:

Awesome, I'm testing right now!

On 26/11/2014 23:35, Danny van Heumen wrote:

Hi George,

I think I may have found the fix for this issue.

I've committed a fixed irc-api client library.
(https://github.com/jitsi/jitsi/commit/c0cebfe7c11ba5de1c9c4dbd873f79826a51ee98)
For reference, details on the cause and the proposed fix can be found
here: https://code.google.com/p/irc-api/issues/detail?id=20

Could you test this to see if it solves the problem for you?

Thanks in advance,
Danny

On 26-11-14 20:50, Danny van Heumen wrote:

On 26-11-14 11:38, George Politis wrote:

Hey Danny,

On 25/11/2014 19:45, Danny van Heumen wrote:

Hey George,

I have noticed something similar.

I'm glad I'm not the only one :slight_smile:

Well, I was starting to wonder the same. It happens to me almost never.
In fact, I almost forgot about this bug.

I haven't pinned it down exactly, but
I think I can reproduce it in the following way.

1. I have 1 IRC accounted fully connected and I've joined some chat
rooms there. (Preferrably busy chat rooms, since we need messages
arriving regularly.)
2. I enable another IRC account, such that it is in the process of
connecting.

At that point I may, for a few seconds, receive messages as private
messages that should just be plain chat room messages.
This period is extended when the process of connecting to an IRC server
takes a long time.

Up to now, I think I've only experienced this during some connection
process.

Could the above apply for you too?

Yes!

Or are you sure that it has happened
without any account in the process of connecting?

No, I'm not sure. I have 5 IRC accounts and I join some busy rooms, so
condition 1 is met. I'm also on a poor connection for now, so reconnects
_might_ be happening without me noticing.

I'll give it another shot as soon as I'm on a more stable connection.

Or maybe you could check with Jitsi if it happens to see whether some
IRC account is reconnecting. I do set "REGISTERING" state during the
connection process, so it may be easy to see.

A stable connection will make this problem almost invisible, so for the
purpose of debugging it doesn't add much. It does improve user
experience though :slight_smile:

Also, is this a lasting problem or is it gone in a few seconds?

This is a lasting problem from my (the user's) perspective, but I might
be reconnecting without noticing because of my crappy connection.

Well, given that this starts upon connecting and stop when finished
connecting, it isn't inconceivable that errors during the connection
process prevent this faulty state from getting fixed.

I'm going to have another look at this issue. AFAIK this is the only
remaining issue for which I'm not entirely sure that I am causing it. :stuck_out_tongue:

Danny

Thank you!

-
George

I haven't exactly put my finger on this, so I would be grateful for any
additional clues. I am pretty sure that this is an issue in the IRC
client library, but I haven't reported it yet.

Danny

On 25-11-14 15:10, George Politis wrote:

Hey,

First of all, thank you Danny for adding IRC support in Jitsi, it's
awesome, I love it and I think it's a fundamental feature that Jitsi was
missing for a long time.

That said, I think I'm having a small issue, and I wanted to ask if
others experience the same thing or is it just me. I'm building Jitsi
from github. I'm a few commits behind but not so many usually.

The problem: I'm not sure if it's specific to IRC rooms or with rooms in
general. Sometimes, when members of a room talk, their messages appear
as private messages to me. So they get added to my contact list etc.

Is this something that others have observed as well? Does anybody have a
clue where it may come from?

Thanks!

Cheers,
George

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev