[jitsi-dev] Prerequisite patch for Android settings


#1

Hi Pawel,

Could you please give us some more details, why do you need that?

Thanks,
Yana

···

On May 22, 2013, at 11:37 AM, Paweł Domas <pawel.domas@jitsi.org> wrote:

Hi all,

I need to change a littile bit more to reuse the registration classes,
as they are currently located in wizards plugin bundles. I thought
that SIPAccountRegistration and JabberAccountRegistration could be
available from some util or protocol packages.

Currently SecurityAccountRegistration and EncodingsRegistrationUtil
are in the util package(.util.wizard). Will this place will also be ok
for SIP and Jabber account registration objects ? From logical point
of view maybe it fits more to some SIP and Jabber specific packages.

Regards,
Pawel

On Wed, May 15, 2013 at 1:40 PM, Paweł Domas <pawel.domas@jitsi.org> wrote:

Hi Yana,

I've merged the interface and impl class into one utility class, as
we've discussed off the list. I'm attaching the patch with this
change.

Regards,
Pawel

On Wed, May 15, 2013 at 12:49 PM, Paweł Domas <pawel.domas@jitsi.org> wrote:

Hi Yana,

On Wed, May 15, 2013 at 12:21 PM, Yana Stamcheva <yana@jitsi.org> wrote:

Hi Pawel,

One more question on the patch. Do you use the EncodingsRegistrationImpl in Android? I'm not sure util.wizard.util is the best place for it, so I'm trying to figure out what would be the best package for it.

Could you please send the Android part of the patch, so that I have a better idea of how we use these changes on Android?

Thanks!
Yana

Unfortunately I don't have a patch that you could apply to svn or git
version and it would work as I've started working on other settings
for Android.

The EncodingsRegistrationImpl is instantiated inside
SIPAccountRegistration and JabberAccountRegistration. I have Activity
similiar to encodings panel and I use the interface.

Regards,
Pawel

On May 15, 2013, at 12:59 PM, Paweł Domas <pawel.domas@jitsi.org> wrote:

Hi Yana,

On Wed, May 15, 2013 at 11:39 AM, Yana Stamcheva <yana@jitsi.org> wrote:

Hi Pawel,

I'm currently reviewing your patch and later today I'll come back to you with more detailed answer. For now I've noticed an issue with account encodings, which also exists in the current version though. The problem is that if I change my account encodings and save them, then open the account settings by clicking Edit, I don't see the change I've previously made. I'm not sure if this is an interface problem or they're not correctly saved. As I said this bug appears in the last Jitsi build too, so it's not introduced by your patch, but if you could have a look while you're on it, it would be great.

Thanks,
Yana

I've checked it with latest build + the patch and it works fine for
both sip and jabber account types.

Regards,
Pawel

On May 15, 2013, at 12:28 PM, Paweł Domas <pawel.domas@jitsi.org> wrote:

Hi all,

In order to implement account settings in Android version I had to
make some changes in Jitsi trunk. I'm attaching the patch.

The point of these changes is to encapsulate operations on properties
inside "registration" objects:
- SIPAccountRegistration
- JabberAccountRegistration
- SecurityAccountRegistration
- EncodingsRegistration

I moved the code that loaded/commited values from/to AccountID
properties into these object. This way it hides complexity of null
checks and other conditions which are sometimes complicated and I
don't have to duplicate this code in Android.

Also I've extracted few routines from wizards into static methods so
that I can reuse them on Android.

I did it very carefully and have tested those changes, but in case any
problems may occur I'm still here to fix them.

Regards,
Pawel
<androidSettingsPrerequisite.txt>

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#2

Hi Yana,

I need that because they are currently in jabber and sip wizard
plugins and those are not available on Android.

The other thing you might not like is that when I moved them to
protocol bundles they are now dependent from corresponding impl
packages(net.java.sip.communicator.impl.protocol.sip). But this might
make sense as they implement protocol specific features.

Regards,
Pawel

···

On Wed, May 22, 2013 at 11:31 AM, Yana Stamcheva <yana@jitsi.org> wrote:

Hi Pawel,

Could you please give us some more details, why do you need that?

Thanks,
Yana

On May 22, 2013, at 11:37 AM, Paweł Domas <pawel.domas@jitsi.org> wrote:

Hi all,

I need to change a littile bit more to reuse the registration classes,
as they are currently located in wizards plugin bundles. I thought
that SIPAccountRegistration and JabberAccountRegistration could be
available from some util or protocol packages.

Currently SecurityAccountRegistration and EncodingsRegistrationUtil
are in the util package(.util.wizard). Will this place will also be ok
for SIP and Jabber account registration objects ? From logical point
of view maybe it fits more to some SIP and Jabber specific packages.

Regards,
Pawel

On Wed, May 15, 2013 at 1:40 PM, Paweł Domas <pawel.domas@jitsi.org> wrote:

Hi Yana,

I've merged the interface and impl class into one utility class, as
we've discussed off the list. I'm attaching the patch with this
change.

Regards,
Pawel

On Wed, May 15, 2013 at 12:49 PM, Paweł Domas <pawel.domas@jitsi.org> wrote:

Hi Yana,

On Wed, May 15, 2013 at 12:21 PM, Yana Stamcheva <yana@jitsi.org> wrote:

Hi Pawel,

One more question on the patch. Do you use the EncodingsRegistrationImpl in Android? I'm not sure util.wizard.util is the best place for it, so I'm trying to figure out what would be the best package for it.

Could you please send the Android part of the patch, so that I have a better idea of how we use these changes on Android?

Thanks!
Yana

Unfortunately I don't have a patch that you could apply to svn or git
version and it would work as I've started working on other settings
for Android.

The EncodingsRegistrationImpl is instantiated inside
SIPAccountRegistration and JabberAccountRegistration. I have Activity
similiar to encodings panel and I use the interface.

Regards,
Pawel

On May 15, 2013, at 12:59 PM, Paweł Domas <pawel.domas@jitsi.org> wrote:

Hi Yana,

On Wed, May 15, 2013 at 11:39 AM, Yana Stamcheva <yana@jitsi.org> wrote:

Hi Pawel,

I'm currently reviewing your patch and later today I'll come back to you with more detailed answer. For now I've noticed an issue with account encodings, which also exists in the current version though. The problem is that if I change my account encodings and save them, then open the account settings by clicking Edit, I don't see the change I've previously made. I'm not sure if this is an interface problem or they're not correctly saved. As I said this bug appears in the last Jitsi build too, so it's not introduced by your patch, but if you could have a look while you're on it, it would be great.

Thanks,
Yana

I've checked it with latest build + the patch and it works fine for
both sip and jabber account types.

Regards,
Pawel

On May 15, 2013, at 12:28 PM, Paweł Domas <pawel.domas@jitsi.org> wrote:

Hi all,

In order to implement account settings in Android version I had to
make some changes in Jitsi trunk. I'm attaching the patch.

The point of these changes is to encapsulate operations on properties
inside "registration" objects:
- SIPAccountRegistration
- JabberAccountRegistration
- SecurityAccountRegistration
- EncodingsRegistration

I moved the code that loaded/commited values from/to AccountID
properties into these object. This way it hides complexity of null
checks and other conditions which are sometimes complicated and I
don't have to duplicate this code in Android.

Also I've extracted few routines from wizards into static methods so
that I can reuse them on Android.

I did it very carefully and have tested those changes, but in case any
problems may occur I'm still here to fix them.

Regards,
Pawel
<androidSettingsPrerequisite.txt>

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#3

Hi Pawel,

Thanks for the explanation.

The problem I see is that these classes are just keeping account wizard values for the time of existence of the currently loaded wizard and even if they don't import any swing or wizard specific packages, they are very specific to wizards. For example, once the account is created the same properties are set in the AccountID properties table. I'm afraid that putting SIPAccountRegistration and JabberAccountRegistration in the service.protocol package could create confusion. If you agree I think that they could be services instead and could be called SIPAccountWizardRegistration and JabberAccountWizardRegistration, so that the name indicates their relation to the wizards.

Cheers,
Yana

···

On May 22, 2013, at 12:42 PM, Paweł Domas <pawel.domas@jitsi.org> wrote:

Hi Yana,

I need that because they are currently in jabber and sip wizard
plugins and those are not available on Android.

The other thing you might not like is that when I moved them to
protocol bundles they are now dependent from corresponding impl
packages(net.java.sip.communicator.impl.protocol.sip). But this might
make sense as they implement protocol specific features.

Regards,
Pawel

On Wed, May 22, 2013 at 11:31 AM, Yana Stamcheva <yana@jitsi.org> wrote:

Hi Pawel,

Could you please give us some more details, why do you need that?

Thanks,
Yana

On May 22, 2013, at 11:37 AM, Paweł Domas <pawel.domas@jitsi.org> wrote:

Hi all,

I need to change a littile bit more to reuse the registration classes,
as they are currently located in wizards plugin bundles. I thought
that SIPAccountRegistration and JabberAccountRegistration could be
available from some util or protocol packages.

Currently SecurityAccountRegistration and EncodingsRegistrationUtil
are in the util package(.util.wizard). Will this place will also be ok
for SIP and Jabber account registration objects ? From logical point
of view maybe it fits more to some SIP and Jabber specific packages.

Regards,
Pawel

On Wed, May 15, 2013 at 1:40 PM, Paweł Domas <pawel.domas@jitsi.org> wrote:

Hi Yana,

I've merged the interface and impl class into one utility class, as
we've discussed off the list. I'm attaching the patch with this
change.

Regards,
Pawel

On Wed, May 15, 2013 at 12:49 PM, Paweł Domas <pawel.domas@jitsi.org> wrote:

Hi Yana,

On Wed, May 15, 2013 at 12:21 PM, Yana Stamcheva <yana@jitsi.org> wrote:

Hi Pawel,

One more question on the patch. Do you use the EncodingsRegistrationImpl in Android? I'm not sure util.wizard.util is the best place for it, so I'm trying to figure out what would be the best package for it.

Could you please send the Android part of the patch, so that I have a better idea of how we use these changes on Android?

Thanks!
Yana

Unfortunately I don't have a patch that you could apply to svn or git
version and it would work as I've started working on other settings
for Android.

The EncodingsRegistrationImpl is instantiated inside
SIPAccountRegistration and JabberAccountRegistration. I have Activity
similiar to encodings panel and I use the interface.

Regards,
Pawel

On May 15, 2013, at 12:59 PM, Paweł Domas <pawel.domas@jitsi.org> wrote:

Hi Yana,

On Wed, May 15, 2013 at 11:39 AM, Yana Stamcheva <yana@jitsi.org> wrote:

Hi Pawel,

I'm currently reviewing your patch and later today I'll come back to you with more detailed answer. For now I've noticed an issue with account encodings, which also exists in the current version though. The problem is that if I change my account encodings and save them, then open the account settings by clicking Edit, I don't see the change I've previously made. I'm not sure if this is an interface problem or they're not correctly saved. As I said this bug appears in the last Jitsi build too, so it's not introduced by your patch, but if you could have a look while you're on it, it would be great.

Thanks,
Yana

I've checked it with latest build + the patch and it works fine for
both sip and jabber account types.

Regards,
Pawel

On May 15, 2013, at 12:28 PM, Paweł Domas <pawel.domas@jitsi.org> wrote:

Hi all,

In order to implement account settings in Android version I had to
make some changes in Jitsi trunk. I'm attaching the patch.

The point of these changes is to encapsulate operations on properties
inside "registration" objects:
- SIPAccountRegistration
- JabberAccountRegistration
- SecurityAccountRegistration
- EncodingsRegistration

I moved the code that loaded/commited values from/to AccountID
properties into these object. This way it hides complexity of null
checks and other conditions which are sometimes complicated and I
don't have to duplicate this code in Android.

Also I've extracted few routines from wizards into static methods so
that I can reuse them on Android.

I did it very carefully and have tested those changes, but in case any
problems may occur I'm still here to fix them.

Regards,
Pawel
<androidSettingsPrerequisite.txt>

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#4

Hi Yana,

Hi Pawel,

Thanks for the explanation.

The problem I see is that these classes are just keeping account wizard values for the time of existence of the currently loaded wizard and even if they don't import any swing or wizard specific packages, they are very specific to wizards. For example, once the account is created the same properties are set in the AccountID properties table. I'm afraid that putting SIPAccountRegistration and JabberAccountRegistration in the service.protocol package could create confusion. If you agree I think that they could be services instead and could be called SIPAccountWizardRegistration and JabberAccountWizardRegistration, so that the name indicates their relation to the wizards.

Cheers,
Yana

Yes they do keep wizard values and I want to share some common utility
part between Swing wizards and Android wizards. If those would become
services do you mean that I should create separate bundles for each ?

Regards,
Pawel

···

On Wed, May 22, 2013 at 12:00 PM, Yana Stamcheva <yana@jitsi.org> wrote:

On May 22, 2013, at 12:42 PM, Paweł Domas <pawel.domas@jitsi.org> wrote:

Hi Yana,

I need that because they are currently in jabber and sip wizard
plugins and those are not available on Android.

The other thing you might not like is that when I moved them to
protocol bundles they are now dependent from corresponding impl
packages(net.java.sip.communicator.impl.protocol.sip). But this might
make sense as they implement protocol specific features.

Regards,
Pawel

On Wed, May 22, 2013 at 11:31 AM, Yana Stamcheva <yana@jitsi.org> wrote:

Hi Pawel,

Could you please give us some more details, why do you need that?

Thanks,
Yana

On May 22, 2013, at 11:37 AM, Paweł Domas <pawel.domas@jitsi.org> wrote:

Hi all,

I need to change a littile bit more to reuse the registration classes,
as they are currently located in wizards plugin bundles. I thought
that SIPAccountRegistration and JabberAccountRegistration could be
available from some util or protocol packages.

Currently SecurityAccountRegistration and EncodingsRegistrationUtil
are in the util package(.util.wizard). Will this place will also be ok
for SIP and Jabber account registration objects ? From logical point
of view maybe it fits more to some SIP and Jabber specific packages.

Regards,
Pawel

On Wed, May 15, 2013 at 1:40 PM, Paweł Domas <pawel.domas@jitsi.org> wrote:

Hi Yana,

I've merged the interface and impl class into one utility class, as
we've discussed off the list. I'm attaching the patch with this
change.

Regards,
Pawel

On Wed, May 15, 2013 at 12:49 PM, Paweł Domas <pawel.domas@jitsi.org> wrote:

Hi Yana,

On Wed, May 15, 2013 at 12:21 PM, Yana Stamcheva <yana@jitsi.org> wrote:

Hi Pawel,

One more question on the patch. Do you use the EncodingsRegistrationImpl in Android? I'm not sure util.wizard.util is the best place for it, so I'm trying to figure out what would be the best package for it.

Could you please send the Android part of the patch, so that I have a better idea of how we use these changes on Android?

Thanks!
Yana

Unfortunately I don't have a patch that you could apply to svn or git
version and it would work as I've started working on other settings
for Android.

The EncodingsRegistrationImpl is instantiated inside
SIPAccountRegistration and JabberAccountRegistration. I have Activity
similiar to encodings panel and I use the interface.

Regards,
Pawel

On May 15, 2013, at 12:59 PM, Paweł Domas <pawel.domas@jitsi.org> wrote:

Hi Yana,

On Wed, May 15, 2013 at 11:39 AM, Yana Stamcheva <yana@jitsi.org> wrote:

Hi Pawel,

I'm currently reviewing your patch and later today I'll come back to you with more detailed answer. For now I've noticed an issue with account encodings, which also exists in the current version though. The problem is that if I change my account encodings and save them, then open the account settings by clicking Edit, I don't see the change I've previously made. I'm not sure if this is an interface problem or they're not correctly saved. As I said this bug appears in the last Jitsi build too, so it's not introduced by your patch, but if you could have a look while you're on it, it would be great.

Thanks,
Yana

I've checked it with latest build + the patch and it works fine for
both sip and jabber account types.

Regards,
Pawel

On May 15, 2013, at 12:28 PM, Paweł Domas <pawel.domas@jitsi.org> wrote:

Hi all,

In order to implement account settings in Android version I had to
make some changes in Jitsi trunk. I'm attaching the patch.

The point of these changes is to encapsulate operations on properties
inside "registration" objects:
- SIPAccountRegistration
- JabberAccountRegistration
- SecurityAccountRegistration
- EncodingsRegistration

I moved the code that loaded/commited values from/to AccountID
properties into these object. This way it hides complexity of null
checks and other conditions which are sometimes complicated and I
don't have to duplicate this code in Android.

Also I've extracted few routines from wizards into static methods so
that I can reuse them on Android.

I did it very carefully and have tested those changes, but in case any
problems may occur I'm still here to fix them.

Regards,
Pawel
<androidSettingsPrerequisite.txt>

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev