[jitsi-dev] PR for FMJ


#1

I've got a fix for RawPushBufferParser.java that my team fixed in our work
and would like to provide it to the Jitsi team; since FMJ is on
sourceforge, I'm not sure how you guys want to handle it. Also yes, I've
signed the CLA already.

Regards,
Paul

RawPushBufferParser.java (24.7 KB)


#2

Thank you very much, Paul!

Writing to the dev mailing list is the best way to go about this.

Could you please elaborate on what problem you've fixed?

···

On Wed, Mar 2, 2016 at 9:39 AM, Mondain <mondain@gmail.com> wrote:

I've got a fix for RawPushBufferParser.java that my team fixed in our work
and would like to provide it to the Jitsi team; since FMJ is on sourceforge,
I'm not sure how you guys want to handle it. Also yes, I've signed the CLA
already.


#3

Paul,

Damyan Minkov noticed that the file you've sent doesn't look right.
Could you please send us a patch of what you want committed into FMJ?

diff --strip-trailing-cr
fmj//src/net/sf/fmj/media/parser/RawPushBufferParser.java
RawPushBufferParser.java

11a12

732c733
< {

···

---

    { System.out.println("wooooHOOO!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!");

814,815c815,816
<
< source.stop();
---

            source.stop();


#4

Cool, i'll remember that for next time. I can't take credit for this one
however, the modification here was used in conjunction with the VP8 PR I
created on libjitsi today; primarily these are in-place to fix issues in
handling empty buffers or the source / sink not being closed. If you need
further details, I'll have to inquire with my workmate.

Paul

···

On Wed, Mar 2, 2016 at 10:46 AM Lyubomir Marinov <lyubomir.marinov@jitsi.org> wrote:

On Wed, Mar 2, 2016 at 9:39 AM, Mondain <mondain@gmail.com> wrote:
> I've got a fix for RawPushBufferParser.java that my team fixed in our
work
> and would like to provide it to the Jitsi team; since FMJ is on
sourceforge,
> I'm not sure how you guys want to handle it. Also yes, I've signed the
CLA
> already.

Thank you very much, Paul!

Writing to the dev mailing list is the best way to go about this.

Could you please elaborate on what problem you've fixed?

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#5

Certainly, will do.

···

On Wed, Mar 2, 2016 at 2:33 PM Lyubomir Marinov <lyubomir.marinov@jitsi.org> wrote:

Paul,

Damyan Minkov noticed that the file you've sent doesn't look right.
Could you please send us a patch of what you want committed into FMJ?

diff --strip-trailing-cr
fmj//src/net/sf/fmj/media/parser/RawPushBufferParser.java
RawPushBufferParser.java

11a12
>
732c733
< {
---
> {
System.out.println("wooooHOOO!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!");
814,815c815,816
<
< source.stop();
---
>
> source.stop();

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev