[jitsi-dev] [PATCH] XEP-0280 (+XEP-0297) implementation


#1

Hello, dev!

I have implemented XEP-0280 (Message Carbons) and XEP-0297 (Message
Forwarding) into Jitsi. A patch file has been created on the last.10728
revision.
Hope you'll check and commit this code soon. Thank you.
Best regards,
Semyon Baranov
mobile: +7 925 369 9878
skype: silex89
icq: 431469408

XEP-0280 (message carbons).patch (84.8 KB)


#2

Hey

I have implemented XEP-0280 (Message Carbons) and XEP-0297 (Message
Forwarding) into Jitsi. A patch file has been created on the last.10728
revision.

Thank you very much for your work! Looking forward to get this integrated!

Hope you'll check and commit this code soon. Thank you.

However before we can look deeper into the patch, please:
- If haven't already done so, sign the BCA [1] and send it emcho@jitsi.org
- Update it against the current source code you find on GitHub [2]. We no
longer use java.net or SVN.
- Follow the code conventions [3]. Line length, braces, wildcard imports and
comments stand out.

Best regards,
Semyon Baranov

Regards,
Ingo

[1] http://bluejimp.com/bca.pdf
[2] https://github.com/jitsi/jitsi
[3] https://jitsi.org/Documentation/CodeConvention


#3

Hi, Ingo!

1. I'm already signed the BCA and have sent it to Emil.
2. I used last code sources from https://github.com/jitsi/jitsi
3. I have followed the code conventions in most cases. If there will be
some remarks to the code that I sent, I can correct it quickly.

Best regards,
Semyon Baranov
mobile: +7 925 369 9878
skype: silex89
icq: 431469408

···

2013/12/16 Ingo Bauersachs <ingo@jitsi.org>

Hey

> I have implemented XEP-0280 (Message Carbons) and XEP-0297 (Message
> Forwarding) into Jitsi. A patch file has been created on the last.10728
> revision.

Thank you very much for your work! Looking forward to get this integrated!

> Hope you'll check and commit this code soon. Thank you.

However before we can look deeper into the patch, please:
- If haven't already done so, sign the BCA [1] and send it emcho@jitsi.org
- Update it against the current source code you find on GitHub [2]. We no
longer use java.net or SVN.
- Follow the code conventions [3]. Line length, braces, wildcard imports
and
comments stand out.

> Best regards,
> Semyon Baranov

Regards,
Ingo

[1] http://bluejimp.com/bca.pdf
[2] https://github.com/jitsi/jitsi
[3] https://jitsi.org/Documentation/CodeConvention

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#4

1. I'm already signed the BCA and have sent it to Emil.

I'm sorry, I missed you previous contributions. I didn't follow the list in
September and October.

2. I used last code sources from https://github.com/jitsi/jitsi

Okay, but then why does the patch file say "revision 10728"? Are you using
Githubs SVN interface?

3. I have followed the code conventions in most cases. If there will be

some

remarks to the code that I sent, I can correct it quickly.

ChatConversationPanel.java:
boolean isEdit = chatMessage.isDelivered() ? false : true;
-> boolean isEdit = !chatMessage.isDelivered();

ChatHtmlUtils.java, ChatPanel.java, ContactListPane.java:
Braces, whitespace on empty lines

HistoryWindow.java, MessageHistoryServiceImpl.java:
Open TODO

DeliveryReceipts.java (in the patch file twice), DeliveryReceipts.java:
Missing header, no comments, braces, unnecessary new lines

OperationSetBasicInstantMessagingJabberImpl.java:
whitespace on empty lines

ProtocolProviderServiceJabberImpl.java:
Braces, Wildcard import

JabberMessageDeliveryReceiptsActivator.java:
Wildcard imports, braces, line length, whitespace on empty lines

...

Best regards,
Semyon Baranov

Ingo


#5

Ingo,

I have re-sent the BCA to Emil today.
The patch bases on the last source codes from github, but I used Turtoise
SVN for all actions with repository. Is it wrong?

Sorry for these discrepancies with the code style agreements. I'll correct
them and check again the both patches.

Best regards,
Semyon Baranov
mobile: +7 925 369 9878
skype: silex89
icq: 431469408

···

2013/12/16 Ingo Bauersachs <ingo@jitsi.org>

> 1. I'm already signed the BCA and have sent it to Emil.

I'm sorry, I missed you previous contributions. I didn't follow the list in
September and October.

> 2. I used last code sources from https://github.com/jitsi/jitsi

Okay, but then why does the patch file say "revision 10728"? Are you using
Githubs SVN interface?

> 3. I have followed the code conventions in most cases. If there will be
some
> remarks to the code that I sent, I can correct it quickly.

ChatConversationPanel.java:
boolean isEdit = chatMessage.isDelivered() ? false : true;
-> boolean isEdit = !chatMessage.isDelivered();

ChatHtmlUtils.java, ChatPanel.java, ContactListPane.java:
Braces, whitespace on empty lines

HistoryWindow.java, MessageHistoryServiceImpl.java:
Open TODO

DeliveryReceipts.java (in the patch file twice), DeliveryReceipts.java:
Missing header, no comments, braces, unnecessary new lines

OperationSetBasicInstantMessagingJabberImpl.java:
whitespace on empty lines

ProtocolProviderServiceJabberImpl.java:
Braces, Wildcard import

JabberMessageDeliveryReceiptsActivator.java:
Wildcard imports, braces, line length, whitespace on empty lines

...

> Best regards,
> Semyon Baranov

Ingo

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#6

I have re-sent the BCA to Emil today.

Thanks - that would not have been necessary. Sorry for the confusion.

The patch bases on the last source codes from github, but I used Turtoise

SVN

for all actions with repository. Is it wrong?

Well, not wrong, but preferably you'd directly use Git as a client. We can
see on which commit your patch is based, and the patch itself can contain
binary data (and as such include the new image).

Sorry for these discrepancies with the code style agreements. I'll correct
them and check again the both patches.

Thanks!

Best regards,
Semyon Baranov

Ingo