[jitsi-dev] [PATCH] XEP-0184 implementation


#1

Hi, dev!

have implemented XEP-0184 (Message Delivery Receipts) into Jitsi. A patch
file has been created on the last.10728 revision.
For applying the patch you'll need a picture of delivered message. This
picture should exists in the following path:
\resources\images\plugin\jabbermessagedeliveryreceipts\messageDelivered.png. I
suggest an image that is attached to this email.
Hope you'll check and commit this code soon. Thank you.
Best regards,
Semyon Baranov
mobile: +7 925 369 9878
skype: silex89
icq: 431469408

XEP-0184 (message delivery receipts).patch (105 KB)


#2

Hi,

Thank you for your work. I'm currently looking at you patch, but a
number of things bother me and need to be fixed before integrating it.

1. The patch do not compile:
jitsi.git/src/net/java/sip/communicator/impl/protocol/jabber/ProtocolProviderServiceJabberImpl.java:23:
cannot find symbol
    [javac] symbol : class DeliveryReceiptsManager
    [javac] location: package
net.java.sip.communicator.impl.protocol.jabber.extensions.deliveryreceipts
    [javac] import
net.java.sip.communicator.impl.protocol.jabber.extensions.deliveryreceipts.DeliveryReceiptsManager;

2. About the plugin jabbermessagedeliveryreceipts:
- don't think it actually needs to be a plugin.
- for obtaining a xmpp connection there is no need to check for it
every second in new thread, you need just to wait the provider to
register
- using felix bundles and impl and service packages are there for
reason, no need to use reflection to call methods on the
ProtocolProviderServiceJabberImpl inside the plugin. The place of this
plugin is inside the xmpp protocol, as other xmpp extensions.
- you intercept every packet and add the Delivery Receipts extension,
but what about group messages, private chat group messages ... in the
xep this is marked as not recommended.

3. MessageDeliveryReceiptEvent is identical to MessageDeliveredEvent,
I think we can reuse it, just adding a 'boolean isReceiptReceived'
method will hold enough information to distinguish events in the UI.
This way MessageListener will not be changed, which otherwise leads to
changing more than 15 classes, just adding an empty implementation.

4. There are a lot of code convention problems in your patch like 80
column, formatting, unused imports, and using no star imports.

5. Why you need to add isDelivered and isEdited in
impl.gui.main.chat.ChatMessage?

I think this is all my comments on the submitted patch.
Thanks once again and we are waiting for your updates.

Regards
damencho

···

On Sun, Dec 15, 2013 at 10:11 PM, Semen Baranov <sfbaranov@gmail.com> wrote:

Hi, dev!

have implemented XEP-0184 (Message Delivery Receipts) into Jitsi. A patch
file has been created on the last.10728 revision.
For applying the patch you'll need a picture of delivered message. This
picture should exists in the following path:
\resources\images\plugin\jabbermessagedeliveryreceipts\messageDelivered.png.
I suggest an image that is attached to this email.
Hope you'll check and commit this code soon. Thank you.
Best regards,
Semyon Baranov
mobile: +7 925 369 9878
skype: silex89
icq: 431469408

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#3

Hello, Damian!

Thank you for your comments.

The patch is updated and attached to this message. Hope it will consider
all your requirements.

Best regards,
Semyon Baranov
mobile: +7 925 369 9878
skype: silex89
icq: 431469408

XEP-0184 (message delivery receipts).patch (69.9 KB)

···

2013/12/18 Damian Minkov <damencho@jitsi.org>

Hi,

Thank you for your work. I'm currently looking at you patch, but a
number of things bother me and need to be fixed before integrating it.

1. The patch do not compile:

jitsi.git/src/net/java/sip/communicator/impl/protocol/jabber/ProtocolProviderServiceJabberImpl.java:23:
cannot find symbol
    [javac] symbol : class DeliveryReceiptsManager
    [javac] location: package
net.java.sip.communicator.impl.protocol.jabber.extensions.deliveryreceipts
    [javac] import

net.java.sip.communicator.impl.protocol.jabber.extensions.deliveryreceipts.DeliveryReceiptsManager;

2. About the plugin jabbermessagedeliveryreceipts:
- don't think it actually needs to be a plugin.
- for obtaining a xmpp connection there is no need to check for it
every second in new thread, you need just to wait the provider to
register
- using felix bundles and impl and service packages are there for
reason, no need to use reflection to call methods on the
ProtocolProviderServiceJabberImpl inside the plugin. The place of this
plugin is inside the xmpp protocol, as other xmpp extensions.
- you intercept every packet and add the Delivery Receipts extension,
but what about group messages, private chat group messages ... in the
xep this is marked as not recommended.

3. MessageDeliveryReceiptEvent is identical to MessageDeliveredEvent,
I think we can reuse it, just adding a 'boolean isReceiptReceived'
method will hold enough information to distinguish events in the UI.
This way MessageListener will not be changed, which otherwise leads to
changing more than 15 classes, just adding an empty implementation.

4. There are a lot of code convention problems in your patch like 80
column, formatting, unused imports, and using no star imports.

5. Why you need to add isDelivered and isEdited in
impl.gui.main.chat.ChatMessage?

I think this is all my comments on the submitted patch.
Thanks once again and we are waiting for your updates.

Regards
damencho

On Sun, Dec 15, 2013 at 10:11 PM, Semen Baranov <sfbaranov@gmail.com> > wrote:
> Hi, dev!
>
> have implemented XEP-0184 (Message Delivery Receipts) into Jitsi. A
patch
> file has been created on the last.10728 revision.
> For applying the patch you'll need a picture of delivered message. This
> picture should exists in the following path:
>
\resources\images\plugin\jabbermessagedeliveryreceipts\messageDelivered.png.
> I suggest an image that is attached to this email.
> Hope you'll check and commit this code soon. Thank you.
> Best regards,
> Semyon Baranov
> mobile: +7 925 369 9878
> skype: silex89
> icq: 431469408
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#4

Thanks for your update!
But: I'm unable to apply your patch - neither with Eclipse nor with git.
Looking at it with Notepad++, it is in some weird encoding, showing
null-bytes all over.
Even after converting it to a readable format, there are still violations of
the code-convention (curly braces on the same line as statements). And there
are changes to files that shouldn't be touched (Eclipse prefs, files under
lib/native

Ingo

From: dev-bounces@jitsi.org [mailto:dev-bounces@jitsi.org] On Behalf Of

Semen

Baranov
Sent: Sonntag, 19. Januar 2014 21:08
To: Jitsi Developers
Cc: Damian Minkov
Subject: Re: [jitsi-dev] [PATCH] XEP-0184 implementation
Hello, Damian!

Thank you for your comments.

The patch is updated and attached to this message. Hope it will consider

all

your requirements.

Best regards,
Semyon Baranov
mobile: +7 925 369 9878
skype: silex89
icq: 431469408

2013/12/18 Damian Minkov <damencho@jitsi.org <mailto:damencho@jitsi.org> >

  Hi,

  Thank you for your work. I'm currently looking at you patch, but a
  number of things bother me and need to be fixed before integrating

it.

  1. The patch do not compile:

jitsi.git/src/net/java/sip/communicator/impl/protocol/jabber/ProtocolP

roviderServiceJabberImpl.java:23: cannot find symbol [javac]
symbol : class DeliveryReceiptsManager [javac] location:

package

net.java.sip.communicator.impl.protocol.jabber.extensions.deliveryrece

ipts [javac] import

net.java.sip.communicator.impl.protocol.jabber.extensions.deliveryrece

ipts.DeliveryReceiptsManager;

  2. About the plugin jabbermessagedeliveryreceipts: - don't

think it

actually needs to be a plugin. - for obtaining a xmpp connection

there

is no need to check for it every second in new thread, you need just to
wait the provider to register - using felix bundles and impl and
service packages are there for reason, no need to use reflection to
call methods on the ProtocolProviderServiceJabberImpl inside the
plugin. The place of this plugin is inside the xmpp protocol, as other
xmpp extensions. - you intercept every packet and add the Delivery
Receipts extension, but what about group messages, private chat group
messages ... in the xep this is marked as not recommended.

  3. MessageDeliveryReceiptEvent is identical to

MessageDeliveredEvent,

  I think we can reuse it, just adding a 'boolean isReceiptReceived'
  method will hold enough information to distinguish events in the UI.
  This way MessageListener will not be changed, which otherwise leads

to

  changing more than 15 classes, just adding an empty implementation.

  4. There are a lot of code convention problems in your patch like 80
  column, formatting, unused imports, and using no star imports.

  5. Why you need to add isDelivered and isEdited in
  impl.gui.main.chat.ChatMessage?

  I think this is all my comments on the submitted patch.
  Thanks once again and we are waiting for your updates.

  Regards
  damencho

  On Sun, Dec 15, 2013 at 10:11 PM, Semen Baranov <sfbaranov@gmail.com
<mailto:sfbaranov@gmail.com> > wrote: > Hi, dev! > >

have

implemented XEP-0184 (Message Delivery Receipts) into Jitsi. A patch

file has been created on the last.10728 revision. > For applying the
patch you'll need a picture of delivered message. This > picture

should

exists in the following path: >
\resources\images\plugin\jabbermessagedeliveryreceipts\messageDelivered.p
ng. > I suggest an image that is attached to this email. > Hope

you'll

check and commit this code soon. Thank you. > Best regards, >

Semyon

Baranov > mobile: +7 925 369 9878 > skype: silex89 >

icq: 431469408 >

  > _______________________________________________
  > dev mailing list
  > dev@jitsi.org <mailto:dev@jitsi.org>
  > Unsubscribe instructions and other list options:
  > http://lists.jitsi.org/mailman/listinfo/dev

  _______________________________________________ dev mailing

list

···

-----Original Message-----
  dev@jitsi.org <mailto:dev@jitsi.org> Unsubscribe instructions and
other list options: http://lists.jitsi.org/mailman/listinfo/dev


#5

sir please address my issue...:frowning:

···

On Sun, Jan 19, 2014 at 8:08 PM, Semen Baranov <sfbaranov@gmail.com> wrote:

Hello, Damian!

Thank you for your comments.

The patch is updated and attached to this message. Hope it will consider
all your requirements.

Best regards,
Semyon Baranov
mobile: +7 925 369 9878
skype: silex89
icq: 431469408

2013/12/18 Damian Minkov <damencho@jitsi.org>

Hi,

Thank you for your work. I'm currently looking at you patch, but a
number of things bother me and need to be fixed before integrating it.

1. The patch do not compile:

jitsi.git/src/net/java/sip/communicator/impl/protocol/jabber/ProtocolProviderServiceJabberImpl.java:23:
cannot find symbol
    [javac] symbol : class DeliveryReceiptsManager
    [javac] location: package
net.java.sip.communicator.impl.protocol.jabber.extensions.deliveryreceipts
    [javac] import

net.java.sip.communicator.impl.protocol.jabber.extensions.deliveryreceipts.DeliveryReceiptsManager;

2. About the plugin jabbermessagedeliveryreceipts:
- don't think it actually needs to be a plugin.
- for obtaining a xmpp connection there is no need to check for it
every second in new thread, you need just to wait the provider to
register
- using felix bundles and impl and service packages are there for
reason, no need to use reflection to call methods on the
ProtocolProviderServiceJabberImpl inside the plugin. The place of this
plugin is inside the xmpp protocol, as other xmpp extensions.
- you intercept every packet and add the Delivery Receipts extension,
but what about group messages, private chat group messages ... in the
xep this is marked as not recommended.

3. MessageDeliveryReceiptEvent is identical to MessageDeliveredEvent,
I think we can reuse it, just adding a 'boolean isReceiptReceived'
method will hold enough information to distinguish events in the UI.
This way MessageListener will not be changed, which otherwise leads to
changing more than 15 classes, just adding an empty implementation.

4. There are a lot of code convention problems in your patch like 80
column, formatting, unused imports, and using no star imports.

5. Why you need to add isDelivered and isEdited in
impl.gui.main.chat.ChatMessage?

I think this is all my comments on the submitted patch.
Thanks once again and we are waiting for your updates.

Regards
damencho

On Sun, Dec 15, 2013 at 10:11 PM, Semen Baranov <sfbaranov@gmail.com> >> wrote:
> Hi, dev!
>
> have implemented XEP-0184 (Message Delivery Receipts) into Jitsi. A
patch
> file has been created on the last.10728 revision.
> For applying the patch you'll need a picture of delivered message. This
> picture should exists in the following path:
>
\resources\images\plugin\jabbermessagedeliveryreceipts\messageDelivered.png.
> I suggest an image that is attached to this email.
> Hope you'll check and commit this code soon. Thank you.
> Best regards,
> Semyon Baranov
> mobile: +7 925 369 9878
> skype: silex89
> icq: 431469408
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#6

Hi, Ingo!

Please, try this patch-file. I've applied it with Eclipse and everything
was ok.
Thank you.

Best regards,
Semyon Baranov
mobile: +7 925 369 9878
skype: silex89
icq: 431469408

xep-0184 (Message delivery receipts) impl.patch (55.8 KB)

···

2014/1/20 Ingo Bauersachs <ingo@jitsi.org>

Thanks for your update!
But: I'm unable to apply your patch - neither with Eclipse nor with git.
Looking at it with Notepad++, it is in some weird encoding, showing
null-bytes all over.
Even after converting it to a readable format, there are still violations
of
the code-convention (curly braces on the same line as statements). And
there
are changes to files that shouldn't be touched (Eclipse prefs, files under
lib/native

Ingo

> -----Original Message-----
> From: dev-bounces@jitsi.org [mailto:dev-bounces@jitsi.org] On Behalf Of
Semen
> Baranov
> Sent: Sonntag, 19. Januar 2014 21:08
> To: Jitsi Developers
> Cc: Damian Minkov
> Subject: Re: [jitsi-dev] [PATCH] XEP-0184 implementation
> Hello, Damian!
>
> Thank you for your comments.
>
> The patch is updated and attached to this message. Hope it will consider
all
> your requirements.
>
> Best regards,
> Semyon Baranov
> mobile: +7 925 369 9878
> skype: silex89
> icq: 431469408
>
>
> 2013/12/18 Damian Minkov <damencho@jitsi.org <mailto:damencho@jitsi.org>
>
>
>
> Hi,
>
> Thank you for your work. I'm currently looking at you patch, but a
> number of things bother me and need to be fixed before integrating
it.
>
> 1. The patch do not compile:
>
jitsi.git/src/net/java/sip/communicator/impl/protocol/jabber/ProtocolP
> roviderServiceJabberImpl.java:23: cannot find symbol [javac]
> symbol : class DeliveryReceiptsManager [javac] location:
package
>
net.java.sip.communicator.impl.protocol.jabber.extensions.deliveryrece
> ipts [javac] import
>
net.java.sip.communicator.impl.protocol.jabber.extensions.deliveryrece
> ipts.DeliveryReceiptsManager;
>
> 2. About the plugin jabbermessagedeliveryreceipts: - don't
think it
> actually needs to be a plugin. - for obtaining a xmpp connection
there
> is no need to check for it every second in new thread, you need just
to
> wait the provider to register - using felix bundles and impl and
> service packages are there for reason, no need to use reflection
to
> call methods on the ProtocolProviderServiceJabberImpl inside the
> plugin. The place of this plugin is inside the xmpp protocol, as
other
> xmpp extensions. - you intercept every packet and add the Delivery
> Receipts extension, but what about group messages, private chat group
> messages ... in the xep this is marked as not recommended.
>
> 3. MessageDeliveryReceiptEvent is identical to
MessageDeliveredEvent,
> I think we can reuse it, just adding a 'boolean isReceiptReceived'
> method will hold enough information to distinguish events in the
UI.
> This way MessageListener will not be changed, which otherwise leads
to
> changing more than 15 classes, just adding an empty implementation.
>
> 4. There are a lot of code convention problems in your patch like
80
> column, formatting, unused imports, and using no star imports.
>
> 5. Why you need to add isDelivered and isEdited in
> impl.gui.main.chat.ChatMessage?
>
> I think this is all my comments on the submitted patch.
> Thanks once again and we are waiting for your updates.
>
> Regards
> damencho
>
>
>
> On Sun, Dec 15, 2013 at 10:11 PM, Semen Baranov <
sfbaranov@gmail.com
> <mailto:sfbaranov@gmail.com> > wrote: > Hi, dev! > >
have
> implemented XEP-0184 (Message Delivery Receipts) into Jitsi. A patch
>
> file has been created on the last.10728 revision. > For applying the
> patch you'll need a picture of delivered message. This > picture
should
> exists in the following path: >
> \resources\images\plugin\jabbermessagedeliveryreceipts\messageDelivered.p
> ng. > I suggest an image that is attached to this email. > Hope
you'll
> check and commit this code soon. Thank you. > Best regards, >
Semyon
> Baranov > mobile: +7 925 369 9878 > skype: silex89 >
icq: 431469408 >
>
> > _______________________________________________
> > dev mailing list
> > dev@jitsi.org <mailto:dev@jitsi.org>
> > Unsubscribe instructions and other list options:
> > http://lists.jitsi.org/mailman/listinfo/dev
>
> _______________________________________________ dev mailing
list
> dev@jitsi.org <mailto:dev@jitsi.org> Unsubscribe instructions
and
> other list options: http://lists.jitsi.org/mailman/listinfo/dev
>
>

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#7

Please do not hijack threads. You have already asked your question. People will respond if they have an answer. Harassing the list is just going to get you banned.

Emil

···

On 20.01.14, 05:18, Ankew Champ wrote:

sir please address my issue...:frowning:

On Sun, Jan 19, 2014 at 8:08 PM, Semen Baranov <sfbaranov@gmail.com > <mailto:sfbaranov@gmail.com>> wrote:

    Hello, Damian!
    Thank you for your comments.
    The patch is updated and attached to this message. Hope it will
    consider all your requirements.

    Best regards,
    Semyon Baranov
    mobile: +7 925 369 9878 <tel:%2B7%20925%20369%209878>
    skype: silex89
    icq: 431469408

    2013/12/18 Damian Minkov <damencho@jitsi.org
    <mailto:damencho@jitsi.org>>

        Hi,

        Thank you for your work. I'm currently looking at you patch, but a
        number of things bother me and need to be fixed before
        integrating it.

        1. The patch do not compile:
        jitsi.git/src/net/java/sip/communicator/impl/protocol/jabber/ProtocolProviderServiceJabberImpl.java:23:
        cannot find symbol
             [javac] symbol : class DeliveryReceiptsManager
             [javac] location: package
        net.java.sip.communicator.impl.protocol.jabber.extensions.deliveryreceipts
             [javac] import
        net.java.sip.communicator.impl.protocol.jabber.extensions.deliveryreceipts.DeliveryReceiptsManager;

        2. About the plugin jabbermessagedeliveryreceipts:
        - don't think it actually needs to be a plugin.
        - for obtaining a xmpp connection there is no need to check for it
        every second in new thread, you need just to wait the provider to
        register
        - using felix bundles and impl and service packages are there for
        reason, no need to use reflection to call methods on the
        ProtocolProviderServiceJabberImpl inside the plugin. The place
        of this
        plugin is inside the xmpp protocol, as other xmpp extensions.
        - you intercept every packet and add the Delivery Receipts
        extension,
        but what about group messages, private chat group messages ...
        in the
        xep this is marked as not recommended.

        3. MessageDeliveryReceiptEvent is identical to
        MessageDeliveredEvent,
        I think we can reuse it, just adding a 'boolean isReceiptReceived'
        method will hold enough information to distinguish events in the UI.
        This way MessageListener will not be changed, which otherwise
        leads to
        changing more than 15 classes, just adding an empty implementation.

        4. There are a lot of code convention problems in your patch like 80
        column, formatting, unused imports, and using no star imports.

        5. Why you need to add isDelivered and isEdited in
        impl.gui.main.chat.ChatMessage?

        I think this is all my comments on the submitted patch.
        Thanks once again and we are waiting for your updates.

        Regards
        damencho

        On Sun, Dec 15, 2013 at 10:11 PM, Semen Baranov > <sfbaranov@gmail.com <mailto:sfbaranov@gmail.com>> wrote:
         > Hi, dev!
         >
         > have implemented XEP-0184 (Message Delivery Receipts) into
        Jitsi. A patch
         > file has been created on the last.10728 revision.
         > For applying the patch you'll need a picture of delivered
        message. This
         > picture should exists in the following path:
         >
        \resources\images\plugin\jabbermessagedeliveryreceipts\messageDelivered.png.
         > I suggest an image that is attached to this email.
         > Hope you'll check and commit this code soon. Thank you.
         > Best regards,
         > Semyon Baranov
         > mobile: +7 925 369 9878 <tel:%2B7%20925%20369%209878>
         > skype: silex89
         > icq: 431469408
         >
         > _______________________________________________
         > dev mailing list
         > dev@jitsi.org <mailto:dev@jitsi.org>
         > Unsubscribe instructions and other list options:
         > http://lists.jitsi.org/mailman/listinfo/dev

        _______________________________________________
        dev mailing list
        dev@jitsi.org <mailto:dev@jitsi.org>
        Unsubscribe instructions and other list options:
        http://lists.jitsi.org/mailman/listinfo/dev

    _______________________________________________
    dev mailing list
    dev@jitsi.org <mailto:dev@jitsi.org>
    Unsubscribe instructions and other list options:
    http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
https://jitsi.org


#8

Hey Semen,

Thanks for sending this. I had a quick look and I see a number of
methods and classes with no javadocs. There also seem to be a number
of opening braces that are not on their own line. Have you had a look
at our code convention?

https://jitsi.org/codeconvention

Also could you please send a short text that explains your changes?

I think this could be a very useful contribution but we have to get it right.

Emil

···

On Sun, Jan 26, 2014 at 12:16 PM, Semen Baranov <sfbaranov@gmail.com> wrote:

Hi, Ingo!

Please, try this patch-file. I've applied it with Eclipse and everything was
ok.
Thank you.

Best regards,
Semyon Baranov
mobile: +7 925 369 9878
skype: silex89
icq: 431469408

2014/1/20 Ingo Bauersachs <ingo@jitsi.org>

Thanks for your update!
But: I'm unable to apply your patch - neither with Eclipse nor with git.
Looking at it with Notepad++, it is in some weird encoding, showing
null-bytes all over.
Even after converting it to a readable format, there are still violations
of
the code-convention (curly braces on the same line as statements). And
there
are changes to files that shouldn't be touched (Eclipse prefs, files under
lib/native

Ingo

> -----Original Message-----
> From: dev-bounces@jitsi.org [mailto:dev-bounces@jitsi.org] On Behalf Of
Semen
> Baranov
> Sent: Sonntag, 19. Januar 2014 21:08
> To: Jitsi Developers
> Cc: Damian Minkov
> Subject: Re: [jitsi-dev] [PATCH] XEP-0184 implementation
> Hello, Damian!
>
> Thank you for your comments.
>
> The patch is updated and attached to this message. Hope it will consider
all
> your requirements.
>
> Best regards,
> Semyon Baranov
> mobile: +7 925 369 9878
> skype: silex89
> icq: 431469408
>
>
> 2013/12/18 Damian Minkov <damencho@jitsi.org <mailto:damencho@jitsi.org>
> >
>
>
> Hi,
>
> Thank you for your work. I'm currently looking at you patch, but a
> number of things bother me and need to be fixed before integrating
it.
>
> 1. The patch do not compile:
>
jitsi.git/src/net/java/sip/communicator/impl/protocol/jabber/ProtocolP
> roviderServiceJabberImpl.java:23: cannot find symbol
> [javac]
> symbol : class DeliveryReceiptsManager [javac] location:
package
>
net.java.sip.communicator.impl.protocol.jabber.extensions.deliveryrece
> ipts [javac] import
>
net.java.sip.communicator.impl.protocol.jabber.extensions.deliveryrece
> ipts.DeliveryReceiptsManager;
>
> 2. About the plugin jabbermessagedeliveryreceipts: - don't
think it
> actually needs to be a plugin. - for obtaining a xmpp connection
there
> is no need to check for it every second in new thread, you need just
> to
> wait the provider to register - using felix bundles and impl and
> service packages are there for reason, no need to use reflection
> to
> call methods on the ProtocolProviderServiceJabberImpl inside the
> plugin. The place of this plugin is inside the xmpp protocol, as
> other
> xmpp extensions. - you intercept every packet and add the Delivery
> Receipts extension, but what about group messages, private chat group
> messages ... in the xep this is marked as not recommended.
>
> 3. MessageDeliveryReceiptEvent is identical to
MessageDeliveredEvent,
> I think we can reuse it, just adding a 'boolean isReceiptReceived'
> method will hold enough information to distinguish events in the
> UI.
> This way MessageListener will not be changed, which otherwise
> leads
to
> changing more than 15 classes, just adding an empty
> implementation.
>
> 4. There are a lot of code convention problems in your patch like
> 80
> column, formatting, unused imports, and using no star imports.
>
> 5. Why you need to add isDelivered and isEdited in
> impl.gui.main.chat.ChatMessage?
>
> I think this is all my comments on the submitted patch.
> Thanks once again and we are waiting for your updates.
>
> Regards
> damencho
>
>
>
> On Sun, Dec 15, 2013 at 10:11 PM, Semen Baranov
> <sfbaranov@gmail.com
> <mailto:sfbaranov@gmail.com> > wrote: > Hi, dev! > >
have
> implemented XEP-0184 (Message Delivery Receipts) into Jitsi. A patch
>
> file has been created on the last.10728 revision. > For applying the
> patch you'll need a picture of delivered message. This > picture
should
> exists in the following path: >
>
> \resources\images\plugin\jabbermessagedeliveryreceipts\messageDelivered.p
> ng. > I suggest an image that is attached to this email. > Hope
you'll
> check and commit this code soon. Thank you. > Best regards, >
Semyon
> Baranov > mobile: +7 925 369 9878 > skype: silex89 >
icq: 431469408 >
>
> > _______________________________________________
> > dev mailing list
> > dev@jitsi.org <mailto:dev@jitsi.org>
> > Unsubscribe instructions and other list options:
> > http://lists.jitsi.org/mailman/listinfo/dev
>
> _______________________________________________ dev
> mailing
list
> dev@jitsi.org <mailto:dev@jitsi.org> Unsubscribe instructions
> and
> other list options: http://lists.jitsi.org/mailman/listinfo/dev
>
>

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
https://jitsi.org FAX: +33.1.77.62.47.31


#9

Hi, Emil!

I've tried to refactor code in the patch for your code convention. Here is
my results.
These changes implements XEP-0184 (message delivery receipts) to jabber
protocol. So if you apply the patch you'll see the delivered picture near
the outgoing messages if your jabber server supports XEP-0184. In the code
there are DeliveryReceiptsManager which intercepts incoming and outgoing
smack messages and adds the delivery receipts info if the message delivery
feature is enabled. Furthermore, the manager adds XEP-0184 info to the
features list that Jitsi sends to server. If the server responds to Jitsi
that some smack message has been delivered, the manager sends a
confirmation message to the server and creates a new MessageDeliveredEvent
which changes a corresponding message by adding the delivered picture in
the chat window and saves this changes to the history.

More detailed information about XEP-0184 you can get here
http://xmpp.org/extensions/xep-0184.html

Hope, this version of patch will be suitable for you.

P.S. the "messageDelivered15x15.png" picture should be saved to
"jitsi\resources\images\protocol\jabber" directory.

Best regards,
Semyon Baranov
mobile: +7 925 369 9878
skype: silex89
icq: 431469408

XEP-0184 (message delivery receipts).patch (58.7 KB)

···

2014-01-26 15:25 GMT+04:00 Emil Ivov <emcho@jitsi.org>:

Hey Semen,

Thanks for sending this. I had a quick look and I see a number of
methods and classes with no javadocs. There also seem to be a number
of opening braces that are not on their own line. Have you had a look
at our code convention?

https://jitsi.org/codeconvention

Also could you please send a short text that explains your changes?

I think this could be a very useful contribution but we have to get it
right.

Emil

On Sun, Jan 26, 2014 at 12:16 PM, Semen Baranov <sfbaranov@gmail.com> > wrote:
> Hi, Ingo!
>
> Please, try this patch-file. I've applied it with Eclipse and everything
was
> ok.
> Thank you.
>
> Best regards,
> Semyon Baranov
> mobile: +7 925 369 9878
> skype: silex89
> icq: 431469408
>
>
> 2014/1/20 Ingo Bauersachs <ingo@jitsi.org>
>>
>> Thanks for your update!
>> But: I'm unable to apply your patch - neither with Eclipse nor with git.
>> Looking at it with Notepad++, it is in some weird encoding, showing
>> null-bytes all over.
>> Even after converting it to a readable format, there are still
violations
>> of
>> the code-convention (curly braces on the same line as statements). And
>> there
>> are changes to files that shouldn't be touched (Eclipse prefs, files
under
>> lib/native
>>
>> Ingo
>>
>> > -----Original Message-----
>> > From: dev-bounces@jitsi.org [mailto:dev-bounces@jitsi.org] On Behalf
Of
>> Semen
>> > Baranov
>> > Sent: Sonntag, 19. Januar 2014 21:08
>> > To: Jitsi Developers
>> > Cc: Damian Minkov
>> > Subject: Re: [jitsi-dev] [PATCH] XEP-0184 implementation
>> > Hello, Damian!
>> >
>> > Thank you for your comments.
>> >
>> > The patch is updated and attached to this message. Hope it will
consider
>> all
>> > your requirements.
>> >
>> > Best regards,
>> > Semyon Baranov
>> > mobile: +7 925 369 9878
>> > skype: silex89
>> > icq: 431469408
>> >
>> >
>> > 2013/12/18 Damian Minkov <damencho@jitsi.org <mailto:
damencho@jitsi.org>
>> > >
>> >
>> >
>> > Hi,
>> >
>> > Thank you for your work. I'm currently looking at you patch,
but a
>> > number of things bother me and need to be fixed before
integrating
>> it.
>> >
>> > 1. The patch do not compile:
>> >
>> jitsi.git/src/net/java/sip/communicator/impl/protocol/jabber/ProtocolP
>> > roviderServiceJabberImpl.java:23: cannot find symbol
>> > [javac]
>> > symbol : class DeliveryReceiptsManager [javac] location:
>> package
>> >
>> net.java.sip.communicator.impl.protocol.jabber.extensions.deliveryrece
>> > ipts [javac] import
>> >
>> net.java.sip.communicator.impl.protocol.jabber.extensions.deliveryrece
>> > ipts.DeliveryReceiptsManager;
>> >
>> > 2. About the plugin jabbermessagedeliveryreceipts: - don't
>> think it
>> > actually needs to be a plugin. - for obtaining a xmpp
connection
>> there
>> > is no need to check for it every second in new thread, you need
just
>> > to
>> > wait the provider to register - using felix bundles and impl
and
>> > service packages are there for reason, no need to use
reflection
>> > to
>> > call methods on the ProtocolProviderServiceJabberImpl inside the
>> > plugin. The place of this plugin is inside the xmpp protocol, as
>> > other
>> > xmpp extensions. - you intercept every packet and add the
Delivery
>> > Receipts extension, but what about group messages, private chat
group
>> > messages ... in the xep this is marked as not recommended.
>> >
>> > 3. MessageDeliveryReceiptEvent is identical to
>> MessageDeliveredEvent,
>> > I think we can reuse it, just adding a 'boolean
isReceiptReceived'
>> > method will hold enough information to distinguish events in the
>> > UI.
>> > This way MessageListener will not be changed, which otherwise
>> > leads
>> to
>> > changing more than 15 classes, just adding an empty
>> > implementation.
>> >
>> > 4. There are a lot of code convention problems in your patch
like
>> > 80
>> > column, formatting, unused imports, and using no star imports.
>> >
>> > 5. Why you need to add isDelivered and isEdited in
>> > impl.gui.main.chat.ChatMessage?
>> >
>> > I think this is all my comments on the submitted patch.
>> > Thanks once again and we are waiting for your updates.
>> >
>> > Regards
>> > damencho
>> >
>> >
>> >
>> > On Sun, Dec 15, 2013 at 10:11 PM, Semen Baranov
>> > <sfbaranov@gmail.com
>> > <mailto:sfbaranov@gmail.com> > wrote: > Hi, dev! >
  >
>> have
>> > implemented XEP-0184 (Message Delivery Receipts) into Jitsi. A patch
>> >
>> > file has been created on the last.10728 revision. > For applying
the
>> > patch you'll need a picture of delivered message. This >
picture
>> should
>> > exists in the following path: >
>> >
>> >
\resources\images\plugin\jabbermessagedeliveryreceipts\messageDelivered.p
>> > ng. > I suggest an image that is attached to this email. > Hope
>> you'll
>> > check and commit this code soon. Thank you. > Best regards,
>
>> Semyon
>> > Baranov > mobile: +7 925 369 9878 > skype: silex89
>
>> icq: 431469408 >
>> >
>> > > _______________________________________________
>> > > dev mailing list
>> > > dev@jitsi.org <mailto:dev@jitsi.org>
>> > > Unsubscribe instructions and other list options:
>> > > http://lists.jitsi.org/mailman/listinfo/dev
>> >
>> > _______________________________________________ dev
>> > mailing
>> list
>> > dev@jitsi.org <mailto:dev@jitsi.org> Unsubscribe
instructions
>> > and
>> > other list options: http://lists.jitsi.org/mailman/listinfo/dev
>> >
>> >
>>
>>
>> _______________________________________________
>> dev mailing list
>> dev@jitsi.org
>> Unsubscribe instructions and other list options:
>> http://lists.jitsi.org/mailman/listinfo/dev
>
>
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
https://jitsi.org FAX: +33.1.77.62.47.31

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#10

Hi, Emil!

I've tried to refactor code in the patch for your code convention. Here is
my results.
These changes implements XEP-0184 (message delivery receipts) to jabber
protocol. So if you apply the patch you'll see the delivered picture near
the outgoing messages if your jabber server supports XEP-0184. In the code
there are DeliveryReceiptsManager which intercepts incoming and outgoing
smack messages and adds the delivery receipts info if the message delivery
feature is enabled. Furthermore, the manager adds XEP-0184 info to the
features list that Jitsi sends to server. If the server responds to Jitsi
that some smack message has been delivered, the manager sends a
confirmation message to the server and creates a new MessageDeliveredEvent
which changes a corresponding message by adding the delivered picture in
the chat window and saves this changes to the history.

More detailed information about XEP-0184 you can get here
http://xmpp.org/extensions/xep-0184.html

Hope, this version of patch will be suitable for you.

P.S. the "messageDelivered15x15.png" picture should be saved to
"jitsi\resources\images\protocol\jabber" directory.

Best regards,
Semyon Baranov
mobile: +7 925 369 9878
skype: silex89
icq: 431469408

Hey Semen,

XEP-0184 (message delivery receipts).patch (58.7 KB)

···

2014-01-26 15:25 GMT+04:00 Emil Ivov <emcho@jitsi.org>:

Thanks for sending this. I had a quick look and I see a number of
methods and classes with no javadocs. There also seem to be a number
of opening braces that are not on their own line. Have you had a look
at our code convention?

https://jitsi.org/codeconvention

Also could you please send a short text that explains your changes?

I think this could be a very useful contribution but we have to get it
right.

Emil

On Sun, Jan 26, 2014 at 12:16 PM, Semen Baranov <sfbaranov@gmail.com> > wrote:
> Hi, Ingo!
>
> Please, try this patch-file. I've applied it with Eclipse and everything
was
> ok.
> Thank you.
>
> Best regards,
> Semyon Baranov
> mobile: +7 925 369 9878
> skype: silex89
> icq: 431469408
>
>
> 2014/1/20 Ingo Bauersachs <ingo@jitsi.org>
>>
>> Thanks for your update!
>> But: I'm unable to apply your patch - neither with Eclipse nor with git.
>> Looking at it with Notepad++, it is in some weird encoding, showing
>> null-bytes all over.
>> Even after converting it to a readable format, there are still
violations
>> of
>> the code-convention (curly braces on the same line as statements). And
>> there
>> are changes to files that shouldn't be touched (Eclipse prefs, files
under
>> lib/native
>>
>> Ingo
>>
>> > -----Original Message-----
>> > From: dev-bounces@jitsi.org [mailto:dev-bounces@jitsi.org] On Behalf
Of
>> Semen
>> > Baranov
>> > Sent: Sonntag, 19. Januar 2014 21:08
>> > To: Jitsi Developers
>> > Cc: Damian Minkov
>> > Subject: Re: [jitsi-dev] [PATCH] XEP-0184 implementation
>> > Hello, Damian!
>> >
>> > Thank you for your comments.
>> >
>> > The patch is updated and attached to this message. Hope it will
consider
>> all
>> > your requirements.
>> >
>> > Best regards,
>> > Semyon Baranov
>> > mobile: +7 925 369 9878
>> > skype: silex89
>> > icq: 431469408
>> >
>> >
>> > 2013/12/18 Damian Minkov <damencho@jitsi.org <mailto:
damencho@jitsi.org>
>> > >
>> >
>> >
>> > Hi,
>> >
>> > Thank you for your work. I'm currently looking at you patch,
but a
>> > number of things bother me and need to be fixed before
integrating
>> it.
>> >
>> > 1. The patch do not compile:
>> >
>> jitsi.git/src/net/java/sip/communicator/impl/protocol/jabber/ProtocolP
>> > roviderServiceJabberImpl.java:23: cannot find symbol
>> > [javac]
>> > symbol : class DeliveryReceiptsManager [javac] location:
>> package
>> >
>> net.java.sip.communicator.impl.protocol.jabber.extensions.deliveryrece
>> > ipts [javac] import
>> >
>> net.java.sip.communicator.impl.protocol.jabber.extensions.deliveryrece
>> > ipts.DeliveryReceiptsManager;
>> >
>> > 2. About the plugin jabbermessagedeliveryreceipts: - don't
>> think it
>> > actually needs to be a plugin. - for obtaining a xmpp
connection
>> there
>> > is no need to check for it every second in new thread, you need
just
>> > to
>> > wait the provider to register - using felix bundles and impl
and
>> > service packages are there for reason, no need to use
reflection
>> > to
>> > call methods on the ProtocolProviderServiceJabberImpl inside the
>> > plugin. The place of this plugin is inside the xmpp protocol, as
>> > other
>> > xmpp extensions. - you intercept every packet and add the
Delivery
>> > Receipts extension, but what about group messages, private chat
group
>> > messages ... in the xep this is marked as not recommended.
>> >
>> > 3. MessageDeliveryReceiptEvent is identical to
>> MessageDeliveredEvent,
>> > I think we can reuse it, just adding a 'boolean
isReceiptReceived'
>> > method will hold enough information to distinguish events in the
>> > UI.
>> > This way MessageListener will not be changed, which otherwise
>> > leads
>> to
>> > changing more than 15 classes, just adding an empty
>> > implementation.
>> >
>> > 4. There are a lot of code convention problems in your patch
like
>> > 80
>> > column, formatting, unused imports, and using no star imports.
>> >
>> > 5. Why you need to add isDelivered and isEdited in
>> > impl.gui.main.chat.ChatMessage?
>> >
>> > I think this is all my comments on the submitted patch.
>> > Thanks once again and we are waiting for your updates.
>> >
>> > Regards
>> > damencho
>> >
>> >
>> >
>> > On Sun, Dec 15, 2013 at 10:11 PM, Semen Baranov
>> > <sfbaranov@gmail.com
>> > <mailto:sfbaranov@gmail.com> > wrote: > Hi, dev! >
  >
>> have
>> > implemented XEP-0184 (Message Delivery Receipts) into Jitsi. A patch
>> >
>> > file has been created on the last.10728 revision. > For applying
the
>> > patch you'll need a picture of delivered message. This >
picture
>> should
>> > exists in the following path: >
>> >
>> >
\resources\images\plugin\jabbermessagedeliveryreceipts\messageDelivered.p
>> > ng. > I suggest an image that is attached to this email. > Hope
>> you'll
>> > check and commit this code soon. Thank you. > Best regards,
>
>> Semyon
>> > Baranov > mobile: +7 925 369 9878 > skype: silex89
>
>> icq: 431469408 >
>> >
>> > > _______________________________________________
>> > > dev mailing list
>> > > dev@jitsi.org <mailto:dev@jitsi.org>
>> > > Unsubscribe instructions and other list options:
>> > > http://lists.jitsi.org/mailman/listinfo/dev
>> >
>> > _______________________________________________ dev
>> > mailing
>> list
>> > dev@jitsi.org <mailto:dev@jitsi.org> Unsubscribe
instructions
>> > and
>> > other list options: http://lists.jitsi.org/mailman/listinfo/dev
>> >
>> >
>>
>>
>> _______________________________________________
>> dev mailing list
>> dev@jitsi.org
>> Unsubscribe instructions and other list options:
>> http://lists.jitsi.org/mailman/listinfo/dev
>
>
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
https://jitsi.org FAX: +33.1.77.62.47.31

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#11

Thanks Semen,

We'll try to have a look as time permits.

Emil

···

On 23.03.14, 10:45, Semen Baranov wrote:

Hi, Emil!
I've tried to refactor code in the patch for your code convention. Here
is my results.
These changes implements XEP-0184 (message delivery receipts) to jabber
protocol. So if you apply the patch you'll see the delivered picture
near the outgoing messages if your jabber server supports XEP-0184. In
the code there are DeliveryReceiptsManager which intercepts incoming and
outgoing smack messages and adds the delivery receipts info if the
message delivery feature is enabled. Furthermore, the manager adds
XEP-0184 info to the features list that Jitsi sends to server. If the
server responds to Jitsi that some smack message has been delivered, the
manager sends a confirmation message to the server and creates a new
MessageDeliveredEvent which changes a corresponding message by adding
the delivered picture in the chat window and saves this changes to the
history.
More detailed information about XEP-0184 you can get here
http://xmpp.org/extensions/xep-0184.html
Hope, this version of patch will be suitable for you.
P.S. the "messageDelivered15x15.png" picture should be saved to
"jitsi\resources\images\protocol\jabber" directory.

Best regards,
Semyon Baranov
mobile: +7 925 369 9878
skype: silex89
icq: 431469408

2014-01-26 15:25 GMT+04:00 Emil Ivov <emcho@jitsi.org
<mailto:emcho@jitsi.org>>:

    Hey Semen,

    Thanks for sending this. I had a quick look and I see a number of
    methods and classes with no javadocs. There also seem to be a number
    of opening braces that are not on their own line. Have you had a look
    at our code convention?

    https://jitsi.org/codeconvention

    Also could you please send a short text that explains your changes?

    I think this could be a very useful contribution but we have to get
    it right.

    Emil

    On Sun, Jan 26, 2014 at 12:16 PM, Semen Baranov <sfbaranov@gmail.com > <mailto:sfbaranov@gmail.com>> wrote:
     > Hi, Ingo!
     >
     > Please, try this patch-file. I've applied it with Eclipse and
    everything was
     > ok.
     > Thank you.
     >
     > Best regards,
     > Semyon Baranov
     > mobile: +7 925 369 9878
     > skype: silex89
     > icq: 431469408
     >
     > 2014/1/20 Ingo Bauersachs <ingo@jitsi.org <mailto:ingo@jitsi.org>>
     >>
     >> Thanks for your update!
     >> But: I'm unable to apply your patch - neither with Eclipse nor
    with git.
     >> Looking at it with Notepad++, it is in some weird encoding, showing
     >> null-bytes all over.
     >> Even after converting it to a readable format, there are still
    violations
     >> of
     >> the code-convention (curly braces on the same line as
    statements). And
     >> there
     >> are changes to files that shouldn't be touched (Eclipse prefs,
    files under
     >> lib/native
     >>
     >> Ingo
     >>
     >> > -----Original Message-----
     >> > From: dev-bounces@jitsi.org <mailto:dev-bounces@jitsi.org>
    [mailto:dev-bounces@jitsi.org <mailto:dev-bounces@jitsi.org>] On
    Behalf Of
     >> Semen
     >> > Baranov
     >> > Sent: Sonntag, 19. Januar 2014 21:08
     >> > To: Jitsi Developers
     >> > Cc: Damian Minkov
     >> > Subject: Re: [jitsi-dev] [PATCH] XEP-0184 implementation
     >> > Hello, Damian!
     >> >
     >> > Thank you for your comments.
     >> >
     >> > The patch is updated and attached to this message. Hope it
    will consider
     >> all
     >> > your requirements.
     >> >
     >> > Best regards,
     >> > Semyon Baranov
     >> > mobile: +7 925 369 9878
     >> > skype: silex89
     >> > icq: 431469408
     >> >
     >> > 2013/12/18 Damian Minkov <damencho@jitsi.org
    <mailto:damencho@jitsi.org> <mailto:damencho@jitsi.org
    <mailto:damencho@jitsi.org>>
     >> > >
     >> >
     >> > Hi,
     >> >
     >> > Thank you for your work. I'm currently looking at you
    patch, but a
     >> > number of things bother me and need to be fixed before
    integrating
     >> it.
     >> >
     >> > 1. The patch do not compile:
     >> >
     >>
    jitsi.git/src/net/java/sip/communicator/impl/protocol/jabber/ProtocolP
     >> > roviderServiceJabberImpl.java:23: cannot find symbol
     >> > [javac]
     >> > symbol : class DeliveryReceiptsManager [javac]
    location:
     >> package
     >> >
     >>
    net.java.sip.communicator.impl.protocol.jabber.extensions.deliveryrece
     >> > ipts [javac] import
     >> >
     >>
    net.java.sip.communicator.impl.protocol.jabber.extensions.deliveryrece
     >> > ipts.DeliveryReceiptsManager;
     >> >
     >> > 2. About the plugin jabbermessagedeliveryreceipts:
      - don't
     >> think it
     >> > actually needs to be a plugin. - for obtaining a xmpp
    connection
     >> there
     >> > is no need to check for it every second in new thread, you
    need just
     >> > to
     >> > wait the provider to register - using felix bundles
    and impl and
     >> > service packages are there for reason, no need to use
    reflection
     >> > to
     >> > call methods on the ProtocolProviderServiceJabberImpl inside the
     >> > plugin. The place of this plugin is inside the xmpp
    protocol, as
     >> > other
     >> > xmpp extensions. - you intercept every packet and add the
    Delivery
     >> > Receipts extension, but what about group messages, private
    chat group
     >> > messages ... in the xep this is marked as not recommended.
     >> >
     >> > 3. MessageDeliveryReceiptEvent is identical to
     >> MessageDeliveredEvent,
     >> > I think we can reuse it, just adding a 'boolean
    isReceiptReceived'
     >> > method will hold enough information to distinguish
    events in the
     >> > UI.
     >> > This way MessageListener will not be changed, which
    otherwise
     >> > leads
     >> to
     >> > changing more than 15 classes, just adding an empty
     >> > implementation.
     >> >
     >> > 4. There are a lot of code convention problems in your
    patch like
     >> > 80
     >> > column, formatting, unused imports, and using no star
    imports.
     >> >
     >> > 5. Why you need to add isDelivered and isEdited in
     >> > impl.gui.main.chat.ChatMessage?
     >> >
     >> > I think this is all my comments on the submitted patch.
     >> > Thanks once again and we are waiting for your updates.
     >> >
     >> > Regards
     >> > damencho
     >> >
     >> > On Sun, Dec 15, 2013 at 10:11 PM, Semen Baranov
     >> > <sfbaranov@gmail.com <mailto:sfbaranov@gmail.com>
     >> > <mailto:sfbaranov@gmail.com <mailto:sfbaranov@gmail.com>> >
    wrote: > Hi, dev! > >
     >> have
     >> > implemented XEP-0184 (Message Delivery Receipts) into Jitsi.
    A patch
     >> >
     >> > file has been created on the last.10728 revision. > For
    applying the
     >> > patch you'll need a picture of delivered message. This
      > picture
     >> should
     >> > exists in the following path: >
     >> >
    \resources\images\plugin\jabbermessagedeliveryreceipts\messageDelivered.p
     >> > ng. > I suggest an image that is attached to this email.
      > Hope
     >> you'll
     >> > check and commit this code soon. Thank you. > Best regards,
             >
     >> Semyon
     >> > Baranov > mobile: +7 925 369 9878 > skype: silex89
            >
     >> icq: 431469408 >
     >> >
     >> > > _______________________________________________
     >> > > dev mailing list
     >> > > dev@jitsi.org <mailto:dev@jitsi.org>
    <mailto:dev@jitsi.org <mailto:dev@jitsi.org>>
     >> > > Unsubscribe instructions and other list options:
     >> > > http://lists.jitsi.org/mailman/listinfo/dev
     >> >
     >> > _______________________________________________ dev
     >> > mailing
     >> list
     >> > dev@jitsi.org <mailto:dev@jitsi.org> <mailto:dev@jitsi.org
    <mailto:dev@jitsi.org>> Unsubscribe instructions
     >> > and
     >> > other list options: http://lists.jitsi.org/mailman/listinfo/dev
     >> >
     >>
     >> _______________________________________________
     >> dev mailing list
     >> dev@jitsi.org <mailto:dev@jitsi.org>
     >> Unsubscribe instructions and other list options:
     >> http://lists.jitsi.org/mailman/listinfo/dev
     >
     > _______________________________________________
     > dev mailing list
     > dev@jitsi.org <mailto:dev@jitsi.org>
     > Unsubscribe instructions and other list options:
     > http://lists.jitsi.org/mailman/listinfo/dev

    --
    Emil Ivov, Ph.D. 67000 Strasbourg,
    Project Lead France
    Jitsi
    emcho@jitsi.org <mailto:emcho@jitsi.org>
      PHONE: +33.1.77.62.43.30
    https://jitsi.org FAX: +33.1.77.62.47.31

    _______________________________________________
    dev mailing list
    dev@jitsi.org <mailto:dev@jitsi.org>
    Unsubscribe instructions and other list options:
    http://lists.jitsi.org/mailman/listinfo/dev

--
https://jitsi.org