Thanks for your update!
But: I'm unable to apply your patch - neither with Eclipse nor with git.
Looking at it with Notepad++, it is in some weird encoding, showing
null-bytes all over.
Even after converting it to a readable format, there are still violations of
the code-convention (curly braces on the same line as statements). And there
are changes to files that shouldn't be touched (Eclipse prefs, files under
From: firstname.lastname@example.org [mailto:email@example.com] On Behalf Of
Sent: Sonntag, 19. Januar 2014 21:08
To: Jitsi Developers
Cc: Damian Minkov
Subject: Re: [jitsi-dev] [PATCH] XEP-0184 implementation
Thank you for your comments.
The patch is updated and attached to this message. Hope it will consider
mobile: +7 925 369 9878
2013/12/18 Damian Minkov <firstname.lastname@example.org <mailto:email@example.com> >
Thank you for your work. I'm currently looking at you patch, but a
number of things bother me and need to be fixed before integrating
1. The patch do not compile:
roviderServiceJabberImpl.java:23: cannot find symbol [javac]
symbol : class DeliveryReceiptsManager [javac] location:
ipts [javac] import
2. About the plugin jabbermessagedeliveryreceipts: - don't
actually needs to be a plugin. - for obtaining a xmpp connection
is no need to check for it every second in new thread, you need just to
wait the provider to register - using felix bundles and impl and
service packages are there for reason, no need to use reflection to
call methods on the ProtocolProviderServiceJabberImpl inside the
plugin. The place of this plugin is inside the xmpp protocol, as other
xmpp extensions. - you intercept every packet and add the Delivery
Receipts extension, but what about group messages, private chat group
messages ... in the xep this is marked as not recommended.
3. MessageDeliveryReceiptEvent is identical to
I think we can reuse it, just adding a 'boolean isReceiptReceived'
method will hold enough information to distinguish events in the UI.
This way MessageListener will not be changed, which otherwise leads
changing more than 15 classes, just adding an empty implementation.
4. There are a lot of code convention problems in your patch like 80
column, formatting, unused imports, and using no star imports.
5. Why you need to add isDelivered and isEdited in
I think this is all my comments on the submitted patch.
Thanks once again and we are waiting for your updates.
On Sun, Dec 15, 2013 at 10:11 PM, Semen Baranov <firstname.lastname@example.org
<mailto:email@example.com> > wrote: > Hi, dev! > >
implemented XEP-0184 (Message Delivery Receipts) into Jitsi. A patch
file has been created on the last.10728 revision. > For applying the
patch you'll need a picture of delivered message. This > picture
exists in the following path: >
ng. > I suggest an image that is attached to this email. > Hope
check and commit this code soon. Thank you. > Best regards, >
Baranov > mobile: +7 925 369 9878 > skype: silex89 >
icq: 431469408 >
> dev mailing list
> firstname.lastname@example.org <mailto:email@example.com>
> Unsubscribe instructions and other list options:
_______________________________________________ dev mailing
firstname.lastname@example.org <mailto:email@example.com> Unsubscribe instructions and
other list options: http://lists.jitsi.org/mailman/listinfo/dev