[jitsi-dev] Patch which adds a button in the CallPanel to create invoke a chat between call peers


#1

Hello devs,

Here is a little patch to add a button which ables to invoke a chat with your call peer. During a call, this button is displayed on the lower right of the call panel.

This button is disabled when your peer or your account does not support IM basic operations. Normally, the button is normally disabled too (I have not been able to test this part) during a conference call.

The button image joined must be placed at "resources/images/impl/gui/buttons/chatSmallWhite.png" (as indicated in the patch file).

Regards,
Vincent

patch_add_button_call_to_invoke_chat.patch (7.02 KB)


#2

Hi Vincent,

the patch looks ok to me.
I was just wondering about the button isn't it better to be added only
when this functionality is available, this way there will not be a
disabled state for the button and it won't be visible for conf calls.
But as IM is commonly available functionality, its ok as it is. Maybe
others can also comment on this.
And one more, its about the quality of the icon. I couldn't find the
sources of our button for messaging from the contact list
(resources/images/impl/gui/buttons/chatSmall.png), but isn't it better
to use that chat icon in the button.

Regards
damencho

···

On Fri, Jan 6, 2012 at 6:26 PM, Vincent Lucas <vincent.lucas@gmail.com> wrote:

Hello devs,

Here is a little patch to add a button which ables to invoke a chat with
your call peer. During a call, this button is displayed on the lower right
of the call panel.

This button is disabled when your peer or your account does not support IM
basic operations. Normally, the button is normally disabled too (I have not
been able to test this part) during a conference call.

The button image joined must be placed at
"resources/images/impl/gui/buttons/chatSmallWhite.png" (as indicated in the
patch file).

Regards,
Vincent


#3

Hi Damencho,

Thank you for the review and your suggestions.
Sincerely, I have no preferences concerning the GUI questions.

If there is no other comments, I will follow your suggestion to set the button invisible if the chat functionality is unavailable.

Concerning the button icon (Yana has send me the svg source of the image chatSmall.png and will be committed too), maybe the best thing is to convert the resources/images/impl/gui/buttons/chatSmall.png to a white on transparent version (without reverse video), to correspond to other CallPanel button design.

Regards,
Vincent

···

On 01/09/2012 04:45 PM, Damian Minkov wrote:

Hi Vincent,

the patch looks ok to me.
I was just wondering about the button isn't it better to be added only
when this functionality is available, this way there will not be a
disabled state for the button and it won't be visible for conf calls.
But as IM is commonly available functionality, its ok as it is. Maybe
others can also comment on this.
And one more, its about the quality of the icon. I couldn't find the
sources of our button for messaging from the contact list
(resources/images/impl/gui/buttons/chatSmall.png), but isn't it better
to use that chat icon in the button.

Regards
damencho

On Fri, Jan 6, 2012 at 6:26 PM, Vincent Lucas<vincent.lucas@gmail.com> wrote:

Hello devs,

Here is a little patch to add a button which ables to invoke a chat with
your call peer. During a call, this button is displayed on the lower right
of the call panel.

This button is disabled when your peer or your account does not support IM
basic operations. Normally, the button is normally disabled too (I have not
been able to test this part) during a conference call.

The button image joined must be placed at
"resources/images/impl/gui/buttons/chatSmallWhite.png" (as indicated in the
patch file).

Regards,
Vincent


#4

Hi,

Hi Damencho,

Thank you for the review and your suggestions.
Sincerely, I have no preferences concerning the GUI questions.

If there is no other comments, I will follow your suggestion to set the

button invisible if the chat functionality is unavailable.

Concerning the button icon (Yana has send me the svg source of the image

chatSmall.png and will be committed too), maybe the best thing is to
convert the resources/images/impl/gui/buttons/chatSmall.png to a white on
transparent version (without reverse video), to correspond to other
CallPanel button design.

Great, that was exactly what I had in mind.

Cheers
damencho

Regards,
Vincent

Hi Vincent,

the patch looks ok to me.
I was just wondering about the button isn't it better to be added only
when this functionality is available, this way there will not be a
disabled state for the button and it won't be visible for conf calls.
But as IM is commonly available functionality, its ok as it is. Maybe
others can also comment on this.
And one more, its about the quality of the icon. I couldn't find the
sources of our button for messaging from the contact list
(resources/images/impl/gui/buttons/chatSmall.png), but isn't it better
to use that chat icon in the button.

Regards
damencho

Hello devs,

Here is a little patch to add a button which ables to invoke a chat with
your call peer. During a call, this button is displayed on the lower

right

of the call panel.

This button is disabled when your peer or your account does not support

IM

basic operations. Normally, the button is normally disabled too (I have

not

been able to test this part) during a conference call.

The button image joined must be placed at
"resources/images/impl/gui/buttons/chatSmallWhite.png" (as indicated in

the

···

On Jan 9, 2012 9:36 PM, "Vincent Lucas" <lucas@clarinet.u-strasbg.fr> wrote:

On 01/09/2012 04:45 PM, Damian Minkov wrote:

On Fri, Jan 6, 2012 at 6:26 PM, Vincent Lucas<vincent.lucas@gmail.com> wrote:

patch file).

Regards,
Vincent


#5

Hi,

Hi Damencho,

Thank you for the review and your suggestions.
Sincerely, I have no preferences concerning the GUI questions.

If there is no other comments, I will follow your suggestion to set the

button invisible if the chat functionality is unavailable.

Concerning the button icon (Yana has send me the svg source of the image

chatSmall.png and will be committed too), maybe the best thing is to
convert the resources/images/impl/gui/buttons/chatSmall.png to a white on
transparent version (without reverse video), to correspond to other
CallPanel button design.

Great, that's exatly what I had in mind.

Cheers
damencho

Regards,
Vincent

Hi Vincent,

the patch looks ok to me.
I was just wondering about the button isn't it better to be added only
when this functionality is available, this way there will not be a
disabled state for the button and it won't be visible for conf calls.
But as IM is commonly available functionality, its ok as it is. Maybe
others can also comment on this.
And one more, its about the quality of the icon. I couldn't find the
sources of our button for messaging from the contact list
(resources/images/impl/gui/buttons/chatSmall.png), but isn't it better
to use that chat icon in the button.

Regards
damencho

Hello devs,

Here is a little patch to add a button which ables to invoke a chat with
your call peer. During a call, this button is displayed on the lower

right

of the call panel.

This button is disabled when your peer or your account does not support

IM

basic operations. Normally, the button is normally disabled too (I have

not

been able to test this part) during a conference call.

The button image joined must be placed at
"resources/images/impl/gui/buttons/chatSmallWhite.png" (as indicated in

the

···

On Jan 9, 2012 9:36 PM, "Vincent Lucas" <lucas@clarinet.u-strasbg.fr> wrote:

On 01/09/2012 04:45 PM, Damian Minkov wrote:

On Fri, Jan 6, 2012 at 6:26 PM, Vincent Lucas<vincent.lucas@gmail.com> wrote:

patch file).

Regards,
Vincent


#6

Hi guys,

Could you please send a screenshot? I'll try to make an icon that fits better the call window.

Thanks,
Yana

···

On Jan 9, 2012, at 8:35 PM, Vincent Lucas wrote:

Hi Damencho,

Thank you for the review and your suggestions.
Sincerely, I have no preferences concerning the GUI questions.

If there is no other comments, I will follow your suggestion to set the button invisible if the chat functionality is unavailable.

Concerning the button icon (Yana has send me the svg source of the image chatSmall.png and will be committed too), maybe the best thing is to convert the resources/images/impl/gui/buttons/chatSmall.png to a white on transparent version (without reverse video), to correspond to other CallPanel button design.

Regards,
Vincent

On 01/09/2012 04:45 PM, Damian Minkov wrote:

Hi Vincent,

the patch looks ok to me.
I was just wondering about the button isn't it better to be added only
when this functionality is available, this way there will not be a
disabled state for the button and it won't be visible for conf calls.
But as IM is commonly available functionality, its ok as it is. Maybe
others can also comment on this.
And one more, its about the quality of the icon. I couldn't find the
sources of our button for messaging from the contact list
(resources/images/impl/gui/buttons/chatSmall.png), but isn't it better
to use that chat icon in the button.

Regards
damencho

On Fri, Jan 6, 2012 at 6:26 PM, Vincent Lucas<vincent.lucas@gmail.com> wrote:

Hello devs,

Here is a little patch to add a button which ables to invoke a chat with
your call peer. During a call, this button is displayed on the lower right
of the call panel.

This button is disabled when your peer or your account does not support IM
basic operations. Normally, the button is normally disabled too (I have not
been able to test this part) during a conference call.

The button image joined must be placed at
"resources/images/impl/gui/buttons/chatSmallWhite.png" (as indicated in the
patch file).

Regards,
Vincent


#7

Hi Yana,

Thank you for the help proposed. Three screenshots (.png) are joined to this email as well as the source (.svg) file:

- [screenshot_chatSmall.png] the icon based on the "classic" chat icon.

- [screenshot_chatSmallWhiteReverseVideo.png] the chat icon with white stroke, transparent fill and transparent background.

- [screenshot_chatSmallWhiteWithoutReverseVideo.png] the chat icon with gray stroke, white fill and transparent background.

Regards,
Vincent

···

On 01/10/2012 12:21 AM, Yana Stamcheva wrote:

Hi guys,

Could you please send a screenshot? I'll try to make an icon that fits better the call window.

Thanks,
Yana

On Jan 9, 2012, at 8:35 PM, Vincent Lucas wrote:

Hi Damencho,

Thank you for the review and your suggestions.
Sincerely, I have no preferences concerning the GUI questions.

If there is no other comments, I will follow your suggestion to set the button invisible if the chat functionality is unavailable.

Concerning the button icon (Yana has send me the svg source of the image chatSmall.png and will be committed too), maybe the best thing is to convert the resources/images/impl/gui/buttons/chatSmall.png to a white on transparent version (without reverse video), to correspond to other CallPanel button design.

Regards,
Vincent

On 01/09/2012 04:45 PM, Damian Minkov wrote:

Hi Vincent,

the patch looks ok to me.
I was just wondering about the button isn't it better to be added only
when this functionality is available, this way there will not be a
disabled state for the button and it won't be visible for conf calls.
But as IM is commonly available functionality, its ok as it is. Maybe
others can also comment on this.
And one more, its about the quality of the icon. I couldn't find the
sources of our button for messaging from the contact list
(resources/images/impl/gui/buttons/chatSmall.png), but isn't it better
to use that chat icon in the button.

Regards
damencho

On Fri, Jan 6, 2012 at 6:26 PM, Vincent Lucas<vincent.lucas@gmail.com> wrote:

Hello devs,

Here is a little patch to add a button which ables to invoke a chat with
your call peer. During a call, this button is displayed on the lower right
of the call panel.

This button is disabled when your peer or your account does not support IM
basic operations. Normally, the button is normally disabled too (I have not
been able to test this part) during a conference call.

The button image joined must be placed at
"resources/images/impl/gui/buttons/chatSmallWhite.png" (as indicated in the
patch file).

Regards,
Vincent


#8

Hi Vincent,

Thanks for the screenshots! I see that you've already made the icons :slight_smile:

Hi Yana,

Thank you for the help proposed. Three screenshots (.png) are joined to this email as well as the source (.svg) file:

- [screenshot_chatSmall.png] the icon based on the "classic" chat icon.

- [screenshot_chatSmallWhiteReverseVideo.png] the chat icon with white stroke, transparent fill and transparent background.

Personally I like this one! :slight_smile:

- [screenshot_chatSmallWhiteWithoutReverseVideo.png] the chat icon with gray stroke, white fill and transparent background.

This one is also good, but I'm not sure if the "message lines" are not too light and hence not very visible.

Cheers,
Yana

···

On Jan 10, 2012, at 11:55 AM, Vincent Lucas wrote:

Regards,
Vincent

On 01/10/2012 12:21 AM, Yana Stamcheva wrote:

Hi guys,

Could you please send a screenshot? I'll try to make an icon that fits better the call window.

Thanks,
Yana

On Jan 9, 2012, at 8:35 PM, Vincent Lucas wrote:

Hi Damencho,

Thank you for the review and your suggestions.
Sincerely, I have no preferences concerning the GUI questions.

If there is no other comments, I will follow your suggestion to set the button invisible if the chat functionality is unavailable.

Concerning the button icon (Yana has send me the svg source of the image chatSmall.png and will be committed too), maybe the best thing is to convert the resources/images/impl/gui/buttons/chatSmall.png to a white on transparent version (without reverse video), to correspond to other CallPanel button design.

Regards,
Vincent

On 01/09/2012 04:45 PM, Damian Minkov wrote:

Hi Vincent,

the patch looks ok to me.
I was just wondering about the button isn't it better to be added only
when this functionality is available, this way there will not be a
disabled state for the button and it won't be visible for conf calls.
But as IM is commonly available functionality, its ok as it is. Maybe
others can also comment on this.
And one more, its about the quality of the icon. I couldn't find the
sources of our button for messaging from the contact list
(resources/images/impl/gui/buttons/chatSmall.png), but isn't it better
to use that chat icon in the button.

Regards
damencho

On Fri, Jan 6, 2012 at 6:26 PM, Vincent Lucas<vincent.lucas@gmail.com> wrote:

Hello devs,

Here is a little patch to add a button which ables to invoke a chat with
your call peer. During a call, this button is displayed on the lower right
of the call panel.

This button is disabled when your peer or your account does not support IM
basic operations. Normally, the button is normally disabled too (I have not
been able to test this part) during a conference call.

The button image joined must be placed at
"resources/images/impl/gui/buttons/chatSmallWhite.png" (as indicated in the
patch file).

Regards,
Vincent

<screenshot_chatSmall.png><screenshot_chatSmallWhiteReverseVideo.png><screenshot_chatSmallWhiteWithoutReverseVideo.png><contactListButtons.svg>


#9

Hi Yana,

Considering Damencho comments and yours, I propose a last version for the button (cf. image joined): chat icon with accentuated "message lines" gray stroke, white fill and transparent background.

Just tell me if it suits you.

Regards,
Vincent

···

On 01/10/2012 12:54 PM, Yana Stamcheva wrote:

Hi Vincent,

Thanks for the screenshots! I see that you've already made the icons :slight_smile:

On Jan 10, 2012, at 11:55 AM, Vincent Lucas wrote:

Hi Yana,

Thank you for the help proposed. Three screenshots (.png) are joined to this email as well as the source (.svg) file:

- [screenshot_chatSmall.png] the icon based on the "classic" chat icon.

- [screenshot_chatSmallWhiteReverseVideo.png] the chat icon with white stroke, transparent fill and transparent background.

Personally I like this one! :slight_smile:

- [screenshot_chatSmallWhiteWithoutReverseVideo.png] the chat icon with gray stroke, white fill and transparent background.

This one is also good, but I'm not sure if the "message lines" are not too light and hence not very visible.

Cheers,
Yana

Regards,
Vincent

On 01/10/2012 12:21 AM, Yana Stamcheva wrote:

Hi guys,

Could you please send a screenshot? I'll try to make an icon that fits better the call window.

Thanks,
Yana

On Jan 9, 2012, at 8:35 PM, Vincent Lucas wrote:

Hi Damencho,

Thank you for the review and your suggestions.
Sincerely, I have no preferences concerning the GUI questions.

If there is no other comments, I will follow your suggestion to set the button invisible if the chat functionality is unavailable.

Concerning the button icon (Yana has send me the svg source of the image chatSmall.png and will be committed too), maybe the best thing is to convert the resources/images/impl/gui/buttons/chatSmall.png to a white on transparent version (without reverse video), to correspond to other CallPanel button design.

Regards,
Vincent

On 01/09/2012 04:45 PM, Damian Minkov wrote:

Hi Vincent,

the patch looks ok to me.
I was just wondering about the button isn't it better to be added only
when this functionality is available, this way there will not be a
disabled state for the button and it won't be visible for conf calls.
But as IM is commonly available functionality, its ok as it is. Maybe
others can also comment on this.
And one more, its about the quality of the icon. I couldn't find the
sources of our button for messaging from the contact list
(resources/images/impl/gui/buttons/chatSmall.png), but isn't it better
to use that chat icon in the button.

Regards
damencho

On Fri, Jan 6, 2012 at 6:26 PM, Vincent Lucas<vincent.lucas@gmail.com> wrote:

Hello devs,

Here is a little patch to add a button which ables to invoke a chat with
your call peer. During a call, this button is displayed on the lower right
of the call panel.

This button is disabled when your peer or your account does not support IM
basic operations. Normally, the button is normally disabled too (I have not
been able to test this part) during a conference call.

The button image joined must be placed at
"resources/images/impl/gui/buttons/chatSmallWhite.png" (as indicated in the
patch file).

Regards,
Vincent

<screenshot_chatSmall.png><screenshot_chatSmallWhiteReverseVideo.png><screenshot_chatSmallWhiteWithoutReverseVideo.png><contactListButtons.svg>


#10

Hi Vincent,

I don't know if it's the late hour, but I have the impression that the "message lines" are somehow blurred :wink: Otherwise it's ok for me!

Cheers,
Yana

···

On Jan 10, 2012, at 10:08 PM, Vincent Lucas wrote:

Hi Yana,

Considering Damencho comments and yours, I propose a last version for the button (cf. image joined): chat icon with accentuated "message lines" gray stroke, white fill and transparent background.

Just tell me if it suits you.

Regards,
Vincent

On 01/10/2012 12:54 PM, Yana Stamcheva wrote:

Hi Vincent,

Thanks for the screenshots! I see that you've already made the icons :slight_smile:

On Jan 10, 2012, at 11:55 AM, Vincent Lucas wrote:

Hi Yana,

Thank you for the help proposed. Three screenshots (.png) are joined to this email as well as the source (.svg) file:

- [screenshot_chatSmall.png] the icon based on the "classic" chat icon.

- [screenshot_chatSmallWhiteReverseVideo.png] the chat icon with white stroke, transparent fill and transparent background.

Personally I like this one! :slight_smile:

- [screenshot_chatSmallWhiteWithoutReverseVideo.png] the chat icon with gray stroke, white fill and transparent background.

This one is also good, but I'm not sure if the "message lines" are not too light and hence not very visible.

Cheers,
Yana

Regards,
Vincent

On 01/10/2012 12:21 AM, Yana Stamcheva wrote:

Hi guys,

Could you please send a screenshot? I'll try to make an icon that fits better the call window.

Thanks,
Yana

On Jan 9, 2012, at 8:35 PM, Vincent Lucas wrote:

Hi Damencho,

Thank you for the review and your suggestions.
Sincerely, I have no preferences concerning the GUI questions.

If there is no other comments, I will follow your suggestion to set the button invisible if the chat functionality is unavailable.

Concerning the button icon (Yana has send me the svg source of the image chatSmall.png and will be committed too), maybe the best thing is to convert the resources/images/impl/gui/buttons/chatSmall.png to a white on transparent version (without reverse video), to correspond to other CallPanel button design.

Regards,
Vincent

On 01/09/2012 04:45 PM, Damian Minkov wrote:

Hi Vincent,

the patch looks ok to me.
I was just wondering about the button isn't it better to be added only
when this functionality is available, this way there will not be a
disabled state for the button and it won't be visible for conf calls.
But as IM is commonly available functionality, its ok as it is. Maybe
others can also comment on this.
And one more, its about the quality of the icon. I couldn't find the
sources of our button for messaging from the contact list
(resources/images/impl/gui/buttons/chatSmall.png), but isn't it better
to use that chat icon in the button.

Regards
damencho

On Fri, Jan 6, 2012 at 6:26 PM, Vincent Lucas<vincent.lucas@gmail.com> wrote:

Hello devs,

Here is a little patch to add a button which ables to invoke a chat with
your call peer. During a call, this button is displayed on the lower right
of the call panel.

This button is disabled when your peer or your account does not support IM
basic operations. Normally, the button is normally disabled too (I have not
been able to test this part) during a conference call.

The button image joined must be placed at
"resources/images/impl/gui/buttons/chatSmallWhite.png" (as indicated in the
patch file).

Regards,
Vincent

<screenshot_chatSmall.png><screenshot_chatSmallWhiteReverseVideo.png><screenshot_chatSmallWhiteWithoutReverseVideo.png><contactListButtons.svg>

<screenshot_chatSmallWhiteWithoutReverseVideoAccentuatedChatLines.png>