Thank you for the review and your suggestions.
Sincerely, I have no preferences concerning the GUI questions.
If there is no other comments, I will follow your suggestion to set the
button invisible if the chat functionality is unavailable.
Concerning the button icon (Yana has send me the svg source of the image
chatSmall.png and will be committed too), maybe the best thing is to
convert the resources/images/impl/gui/buttons/chatSmall.png to a white on
transparent version (without reverse video), to correspond to other
CallPanel button design.
Great, that was exactly what I had in mind.
the patch looks ok to me.
I was just wondering about the button isn't it better to be added only
when this functionality is available, this way there will not be a
disabled state for the button and it won't be visible for conf calls.
But as IM is commonly available functionality, its ok as it is. Maybe
others can also comment on this.
And one more, its about the quality of the icon. I couldn't find the
sources of our button for messaging from the contact list
(resources/images/impl/gui/buttons/chatSmall.png), but isn't it better
to use that chat icon in the button.
Here is a little patch to add a button which ables to invoke a chat with
your call peer. During a call, this button is displayed on the lower
of the call panel.
This button is disabled when your peer or your account does not support
basic operations. Normally, the button is normally disabled too (I have
been able to test this part) during a conference call.
The button image joined must be placed at
"resources/images/impl/gui/buttons/chatSmallWhite.png" (as indicated in
On Jan 9, 2012 9:36 PM, "Vincent Lucas" <firstname.lastname@example.org> wrote:
On 01/09/2012 04:45 PM, Damian Minkov wrote:
On Fri, Jan 6, 2012 at 6:26 PM, Vincent Lucas<email@example.com> wrote: