[jitsi-dev] [PATCH] vCard editor for XMPP


#1

Hello,

I'm uploading some screenshots of the gui so you can quickly review the
changes.

Regards,
Marin


#2

Thanks,

Several quick notes:

* It'll be better for the combo box to have a default selection so thast
the form wouldn't open empty.

* Aren't we missing some vcard fields? For example, I am not seeing the
possibility to set a URL anywhere. I also don't see things like
"Description", "Full Name", "Job Title", "Role", "Birth date"

* Could you please make sure that the panel is transparent so that it
doesn't appear grey

* Could you please also make this option available in a right-click menu in
our account list?

Thanks,

Emil

--sent from my mobile

···

On 11 Oct 2013 09:17, "Marin Dzhigarov" <marin@bluejimp.com> wrote:

Hello,

I'm uploading some screenshots of the gui so you can quickly review the
changes.

Regards,
Marin

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#3

Hi Marin,

Hello,

I'm uploading some screenshots of the gui so you can quickly review the

changes.

Looks great!

I've noticed just a few things. I think we should have an account selected
by default (the first one or if there's a preferred account). Also we'll
need a cancel button, especially in the case where we're able to make
changes.

Also maybe text fields look a little bit wierd when they're so long, going
to the end of the window.

Cheers,
Yana

···

On Oct 11, 2013 9:17 AM, "Marin Dzhigarov" <marin@bluejimp.com> wrote:

Regards,
Marin

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#4

Thanks for the quick response!

* It'll be better for the combo box to have a default selection so thast

the form wouldn't open empty.

* Could you please make sure that the panel is transparent so that it

doesn't appear grey

* Could you please also make this option available in a right-click menu

in our account list?

Also we'll need a cancel button, especially in the case where we're able

to make changes.

Also maybe text fields look a little bit wierd when they're so long,

going to the end of the window.

Okay, no problem :slight_smile:

* Aren't we missing some vcard fields? For example, I am not seeing the

possibility to set a URL anywhere. I also don't see things

like "Description", "Full Name", "Job Title", "Role", "Birth date"

We are using jivesoftware's VCard implementation for managing vcards and
according to their docu
http://www.igniterealtime.org/builds/smack/docs/latest/javadoc/org/jivesoftware/smackx/packet/VCard.html
these are the fields that can be set. There is also an option to set
generic vCard fields.
Should I proceed and add "URL", "Description", "Full Name", "Job Title",
"Role", "Birth date" as generic fields?

Regards,
Marin

···

On Fri, Oct 11, 2013 at 10:35 AM, Emil Ivov <emcho@jitsi.org> wrote:

Thanks,

Several quick notes:

* It'll be better for the combo box to have a default selection so thast
the form wouldn't open empty.

* Aren't we missing some vcard fields? For example, I am not seeing the
possibility to set a URL anywhere. I also don't see things like
"Description", "Full Name", "Job Title", "Role", "Birth date"

* Could you please make sure that the panel is transparent so that it
doesn't appear grey

* Could you please also make this option available in a right-click menu
in our account list?

Thanks,

Emil

--sent from my mobile
On 11 Oct 2013 09:17, "Marin Dzhigarov" <marin@bluejimp.com> wrote:

Hello,

I'm uploading some screenshots of the gui so you can quickly review the
changes.

Regards,
Marin

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#5

Should I proceed and add "URL", "Description", "Full Name", "Job Title",
"Role", "Birth date" as generic fields?

Yes please. (Actually, I am not certain we need "Full Name" and "Role"
actually, but the rest would be good to add. Especially URL, which we
even show in the contact list).

···

On Fri, Oct 11, 2013 at 9:51 AM, Marin Dzhigarov <marin@bluejimp.com> wrote:

Regards,
Marin

On Fri, Oct 11, 2013 at 10:35 AM, Emil Ivov <emcho@jitsi.org> wrote:

Thanks,

Several quick notes:

* It'll be better for the combo box to have a default selection so thast
the form wouldn't open empty.

* Aren't we missing some vcard fields? For example, I am not seeing the
possibility to set a URL anywhere. I also don't see things like
"Description", "Full Name", "Job Title", "Role", "Birth date"

* Could you please make sure that the panel is transparent so that it
doesn't appear grey

* Could you please also make this option available in a right-click menu
in our account list?

Thanks,

Emil

--sent from my mobile

On 11 Oct 2013 09:17, "Marin Dzhigarov" <marin@bluejimp.com> wrote:

Hello,

I'm uploading some screenshots of the gui so you can quickly review the
changes.

Regards,
Marin

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
https://jitsi.org FAX: +33.1.77.62.47.31


#6

Hello,

I'm sending the newest patch for a review and some screenshots. Also, this
jar <http://www.toedter.com/en/jcalendar/> should be added to
lib/installer-exclude.

Looking forward for any feedback!

Regards,
Marin

vCard1.patch (198 KB)

···

On Fri, Oct 18, 2013 at 2:10 PM, Marin Dzhigarov <marin@bluejimp.com> wrote:

Hello,

I'm sending the newest patch for a review, a jar that should be added to
lib/installer-exclude and also some screenshots.

Looking forward for any feedback!

Regards,
Marin

On Fri, Oct 11, 2013 at 11:09 AM, Emil Ivov <emcho@jitsi.org> wrote:

On Fri, Oct 11, 2013 at 9:51 AM, Marin Dzhigarov <marin@bluejimp.com> >> wrote:
> Should I proceed and add "URL", "Description", "Full Name", "Job Title",
> "Role", "Birth date" as generic fields?

Yes please. (Actually, I am not certain we need "Full Name" and "Role"
actually, but the rest would be good to add. Especially URL, which we
even show in the contact list).

>
> Regards,
> Marin
>
>
>
>
>
> On Fri, Oct 11, 2013 at 10:35 AM, Emil Ivov <emcho@jitsi.org> wrote:
>>
>> Thanks,
>>
>> Several quick notes:
>>
>> * It'll be better for the combo box to have a default selection so
thast
>> the form wouldn't open empty.
>>
>> * Aren't we missing some vcard fields? For example, I am not seeing the
>> possibility to set a URL anywhere. I also don't see things like
>> "Description", "Full Name", "Job Title", "Role", "Birth date"
>>
>> * Could you please make sure that the panel is transparent so that it
>> doesn't appear grey
>>
>> * Could you please also make this option available in a right-click
menu
>> in our account list?
>>
>>
>> Thanks,
>>
>> Emil
>>
>> --sent from my mobile
>>
>> On 11 Oct 2013 09:17, "Marin Dzhigarov" <marin@bluejimp.com> wrote:
>>>
>>> Hello,
>>>
>>> I'm uploading some screenshots of the gui so you can quickly review
the
>>> changes.
>>>
>>> Regards,
>>> Marin
>>>
>>> _______________________________________________
>>> dev mailing list
>>> dev@jitsi.org
>>> Unsubscribe instructions and other list options:
>>> http://lists.jitsi.org/mailman/listinfo/dev
>>
>>
>> _______________________________________________
>> dev mailing list
>> dev@jitsi.org
>> Unsubscribe instructions and other list options:
>> http://lists.jitsi.org/mailman/listinfo/dev
>
>
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
https://jitsi.org FAX: +33.1.77.62.47.31

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#7

Hi Marin,

Hello,

I'm sending the newest patch for a review and some screenshots. Also, this jar should be added to lib/installer-exclude.

Looking forward for any feedback!

Thanks for the good work!

I've just applied your patch and it looks good. I have some requests before being able to commit it though.

Here they are (in no particular order):

* I have an ippi account (which is basically a custom sip provider), which appears as a first entry in the account info combo box with an empty form below it (screenshot attached). I think it shouldn't appear there if it doesn't support account info edit and one way of doing it would be to add a method to the OperationSetServerStoredAccountInfo, which is isEditable().

* After modifying my jabber vCard and hitting "Apply" I see the following line in the Console :

[java] 17:00:21.545 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.actionPerformed().751 Failed to update URL detail due to malformed URL.

I didn't add an URL to my details and it didn't have any consequences, but we should fix it anyway :slight_smile:

* The edit menu item icon is kind of old, I'll send you a newer one.

* When I scroll to the bottom of the details, then close the window, then open it again, the scroll will be at the bottom, IMO the form should be refreshed to the top.

* When I tried to delete some of the details I've previously entered I get the following exceptions. And even if they appeared to be deleted from the form, when I restart jitsi they're still there!

[java] 17:20:07.351 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. First Name java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.351 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Middle Name java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.352 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Last Name java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.352 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Nickname java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.352 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.actionPerformed().751 Failed to update URL detail due to malformed URL.
     [java] 17:20:07.352 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. URL java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.353 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Birth Date java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.353 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Address java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.353 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. City java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.353 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Region/Province/State java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.354 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Postal/Zip Code java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.354 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Country java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.354 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. e-mail java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.354 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Work e-mail java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.354 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Work Organization Name java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.355 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Job Title java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.355 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Description java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached

In my installation I have 3 account. One ippi, one jit.si account, which served for the vCards tests and one gmail account.

If you need more information don't hesitate to contact me.

Cheers,
Yana

···

On 18 Oct 2013, at 13:26, Marin Dzhigarov <marin@bluejimp.com> wrote:

Regards,
Marin

On Fri, Oct 18, 2013 at 2:10 PM, Marin Dzhigarov <marin@bluejimp.com> wrote:
Hello,

I'm sending the newest patch for a review, a jar that should be added to lib/installer-exclude and also some screenshots.

Looking forward for any feedback!

Regards,
Marin

On Fri, Oct 11, 2013 at 11:09 AM, Emil Ivov <emcho@jitsi.org> wrote:
On Fri, Oct 11, 2013 at 9:51 AM, Marin Dzhigarov <marin@bluejimp.com> wrote:
> Should I proceed and add "URL", "Description", "Full Name", "Job Title",
> "Role", "Birth date" as generic fields?

Yes please. (Actually, I am not certain we need "Full Name" and "Role"
actually, but the rest would be good to add. Especially URL, which we
even show in the contact list).

>
> Regards,
> Marin
>
>
>
>
>
> On Fri, Oct 11, 2013 at 10:35 AM, Emil Ivov <emcho@jitsi.org> wrote:
>>
>> Thanks,
>>
>> Several quick notes:
>>
>> * It'll be better for the combo box to have a default selection so thast
>> the form wouldn't open empty.
>>
>> * Aren't we missing some vcard fields? For example, I am not seeing the
>> possibility to set a URL anywhere. I also don't see things like
>> "Description", "Full Name", "Job Title", "Role", "Birth date"
>>
>> * Could you please make sure that the panel is transparent so that it
>> doesn't appear grey
>>
>> * Could you please also make this option available in a right-click menu
>> in our account list?
>>
>>
>> Thanks,
>>
>> Emil
>>
>> --sent from my mobile
>>
>> On 11 Oct 2013 09:17, "Marin Dzhigarov" <marin@bluejimp.com> wrote:
>>>
>>> Hello,
>>>
>>> I'm uploading some screenshots of the gui so you can quickly review the
>>> changes.
>>>
>>> Regards,
>>> Marin
>>>
>>> _______________________________________________
>>> dev mailing list
>>> dev@jitsi.org
>>> Unsubscribe instructions and other list options:
>>> http://lists.jitsi.org/mailman/listinfo/dev
>>
>>
>> _______________________________________________
>> dev mailing list
>> dev@jitsi.org
>> Unsubscribe instructions and other list options:
>> http://lists.jitsi.org/mailman/listinfo/dev
>
>
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
https://jitsi.org FAX: +33.1.77.62.47.31

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

<1.png><2.png><vCard1.patch>_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#8

Are there plans to support the (much more extensible) vCard4 standard?

···

Sent from mobile, might be terse

On Nov 1, 2013, at 10:28 AM, Yana Stamcheva <yana@jitsi.org> wrote:

Hi Marin,

On 18 Oct 2013, at 13:26, Marin Dzhigarov <marin@bluejimp.com> wrote:

Hello,

I'm sending the newest patch for a review and some screenshots. Also, this jar should be added to lib/installer-exclude.

Looking forward for any feedback!

Thanks for the good work!

I've just applied your patch and it looks good. I have some requests before being able to commit it though.

Here they are (in no particular order):

* I have an ippi account (which is basically a custom sip provider), which appears as a first entry in the account info combo box with an empty form below it (screenshot attached). I think it shouldn't appear there if it doesn't support account info edit and one way of doing it would be to add a method to the OperationSetServerStoredAccountInfo, which is isEditable().

* After modifying my jabber vCard and hitting "Apply" I see the following line in the Console :

[java] 17:00:21.545 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.actionPerformed().751 Failed to update URL detail due to malformed URL.

I didn't add an URL to my details and it didn't have any consequences, but we should fix it anyway :slight_smile:

* The edit menu item icon is kind of old, I'll send you a newer one.

* When I scroll to the bottom of the details, then close the window, then open it again, the scroll will be at the bottom, IMO the form should be refreshed to the top.

* When I tried to delete some of the details I've previously entered I get the following exceptions. And even if they appeared to be deleted from the form, when I restart jitsi they're still there!

[java] 17:20:07.351 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. First Name java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.351 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Middle Name java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.352 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Last Name java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.352 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Nickname java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.352 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.actionPerformed().751 Failed to update URL detail due to malformed URL.
     [java] 17:20:07.352 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. URL java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.353 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Birth Date java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.353 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Address java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.353 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. City java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.353 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Region/Province/State java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.354 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Postal/Zip Code java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.354 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Country java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.354 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. e-mail java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.354 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Work e-mail java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.354 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Work Organization Name java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.355 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Job Title java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.355 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Description java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached

In my installation I have 3 account. One ippi, one jit.si account, which served for the vCards tests and one gmail account.

If you need more information don't hesitate to contact me.

Cheers,
Yana

<Screen Shot 2013-11-01 at 16.59.00.png>

Regards,
Marin

On Fri, Oct 18, 2013 at 2:10 PM, Marin Dzhigarov <marin@bluejimp.com> wrote:
Hello,

I'm sending the newest patch for a review, a jar that should be added to lib/installer-exclude and also some screenshots.

Looking forward for any feedback!

Regards,
Marin

On Fri, Oct 11, 2013 at 11:09 AM, Emil Ivov <emcho@jitsi.org> wrote:
On Fri, Oct 11, 2013 at 9:51 AM, Marin Dzhigarov <marin@bluejimp.com> wrote:
> Should I proceed and add "URL", "Description", "Full Name", "Job Title",
> "Role", "Birth date" as generic fields?

Yes please. (Actually, I am not certain we need "Full Name" and "Role"
actually, but the rest would be good to add. Especially URL, which we
even show in the contact list).

>
> Regards,
> Marin
>
>
>
>
>
> On Fri, Oct 11, 2013 at 10:35 AM, Emil Ivov <emcho@jitsi.org> wrote:
>>
>> Thanks,
>>
>> Several quick notes:
>>
>> * It'll be better for the combo box to have a default selection so thast
>> the form wouldn't open empty.
>>
>> * Aren't we missing some vcard fields? For example, I am not seeing the
>> possibility to set a URL anywhere. I also don't see things like
>> "Description", "Full Name", "Job Title", "Role", "Birth date"
>>
>> * Could you please make sure that the panel is transparent so that it
>> doesn't appear grey
>>
>> * Could you please also make this option available in a right-click menu
>> in our account list?
>>
>>
>> Thanks,
>>
>> Emil
>>
>> --sent from my mobile
>>
>> On 11 Oct 2013 09:17, "Marin Dzhigarov" <marin@bluejimp.com> wrote:
>>>
>>> Hello,
>>>
>>> I'm uploading some screenshots of the gui so you can quickly review the
>>> changes.
>>>
>>> Regards,
>>> Marin
>>>
>>> _______________________________________________
>>> dev mailing list
>>> dev@jitsi.org
>>> Unsubscribe instructions and other list options:
>>> http://lists.jitsi.org/mailman/listinfo/dev
>>
>>
>> _______________________________________________
>> dev mailing list
>> dev@jitsi.org
>> Unsubscribe instructions and other list options:
>> http://lists.jitsi.org/mailman/listinfo/dev
>
>
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
https://jitsi.org FAX: +33.1.77.62.47.31

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

<1.png><2.png><vCard1.patch>_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#9

Hey,

One more thing. Is there a way to change the photo of a particular account (I don't see it)? Maybe it would be a good idea to add this possibility here.

Cheers,
Yana

···

On 01 Nov 2013, at 17:28, Yana Stamcheva <yana@jitsi.org> wrote:

Hi Marin,

On 18 Oct 2013, at 13:26, Marin Dzhigarov <marin@bluejimp.com> wrote:

Hello,

I'm sending the newest patch for a review and some screenshots. Also, this jar should be added to lib/installer-exclude.

Looking forward for any feedback!

Thanks for the good work!

I've just applied your patch and it looks good. I have some requests before being able to commit it though.

Here they are (in no particular order):

* I have an ippi account (which is basically a custom sip provider), which appears as a first entry in the account info combo box with an empty form below it (screenshot attached). I think it shouldn't appear there if it doesn't support account info edit and one way of doing it would be to add a method to the OperationSetServerStoredAccountInfo, which is isEditable().

* After modifying my jabber vCard and hitting "Apply" I see the following line in the Console :

[java] 17:00:21.545 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.actionPerformed().751 Failed to update URL detail due to malformed URL.

I didn't add an URL to my details and it didn't have any consequences, but we should fix it anyway :slight_smile:

* The edit menu item icon is kind of old, I'll send you a newer one.

* When I scroll to the bottom of the details, then close the window, then open it again, the scroll will be at the bottom, IMO the form should be refreshed to the top.

* When I tried to delete some of the details I've previously entered I get the following exceptions. And even if they appeared to be deleted from the form, when I restart jitsi they're still there!

[java] 17:20:07.351 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. First Name java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.351 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Middle Name java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.352 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Last Name java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.352 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Nickname java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.352 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.actionPerformed().751 Failed to update URL detail due to malformed URL.
     [java] 17:20:07.352 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. URL java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.353 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Birth Date java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.353 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Address java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.353 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. City java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.353 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Region/Province/State java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.354 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Postal/Zip Code java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.354 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Country java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.354 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. e-mail java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.354 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Work e-mail java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.354 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Work Organization Name java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.355 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Job Title java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.355 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Description java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached

In my installation I have 3 account. One ippi, one jit.si account, which served for the vCards tests and one gmail account.

If you need more information don't hesitate to contact me.

Cheers,
Yana

<Screen Shot 2013-11-01 at 16.59.00.png>

Regards,
Marin

On Fri, Oct 18, 2013 at 2:10 PM, Marin Dzhigarov <marin@bluejimp.com> wrote:
Hello,

I'm sending the newest patch for a review, a jar that should be added to lib/installer-exclude and also some screenshots.

Looking forward for any feedback!

Regards,
Marin

On Fri, Oct 11, 2013 at 11:09 AM, Emil Ivov <emcho@jitsi.org> wrote:
On Fri, Oct 11, 2013 at 9:51 AM, Marin Dzhigarov <marin@bluejimp.com> wrote:
> Should I proceed and add "URL", "Description", "Full Name", "Job Title",
> "Role", "Birth date" as generic fields?

Yes please. (Actually, I am not certain we need "Full Name" and "Role"
actually, but the rest would be good to add. Especially URL, which we
even show in the contact list).

>
> Regards,
> Marin
>
>
>
>
>
> On Fri, Oct 11, 2013 at 10:35 AM, Emil Ivov <emcho@jitsi.org> wrote:
>>
>> Thanks,
>>
>> Several quick notes:
>>
>> * It'll be better for the combo box to have a default selection so thast
>> the form wouldn't open empty.
>>
>> * Aren't we missing some vcard fields? For example, I am not seeing the
>> possibility to set a URL anywhere. I also don't see things like
>> "Description", "Full Name", "Job Title", "Role", "Birth date"
>>
>> * Could you please make sure that the panel is transparent so that it
>> doesn't appear grey
>>
>> * Could you please also make this option available in a right-click menu
>> in our account list?
>>
>>
>> Thanks,
>>
>> Emil
>>
>> --sent from my mobile
>>
>> On 11 Oct 2013 09:17, "Marin Dzhigarov" <marin@bluejimp.com> wrote:
>>>
>>> Hello,
>>>
>>> I'm uploading some screenshots of the gui so you can quickly review the
>>> changes.
>>>
>>> Regards,
>>> Marin
>>>
>>> _______________________________________________
>>> dev mailing list
>>> dev@jitsi.org
>>> Unsubscribe instructions and other list options:
>>> http://lists.jitsi.org/mailman/listinfo/dev
>>
>>
>> _______________________________________________
>> dev mailing list
>> dev@jitsi.org
>> Unsubscribe instructions and other list options:
>> http://lists.jitsi.org/mailman/listinfo/dev
>
>
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
https://jitsi.org FAX: +33.1.77.62.47.31

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

<1.png><2.png><vCard1.patch>_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#10

Hey Peter,

···

On Fri, Nov 1, 2013 at 6:17 PM, Peter Saint-Andre <stpeter@stpeter.im> wrote:

Are there plans to support the (much more extensible) vCard4 standard?

We haven't specifically discussed it but I suppose we will switch at
some point. Not sure when though. Running into a specific problem with
3.0 or badly needing a feature in 4.0 would certainly expedite the
process.

Emil

--
https://jitsi.org


#11

Hi,

just to add, we already have the editing of account image from the
contact list where we display it. We discussed it offline and we
agreed back then that it is not priority to move it from the ui to
this plugin.

In display of account image we modify all accounts images in one step,
by moving it into account settings we can do it per account. Or we can
move it once the other edit functionality is present, as a second step
:slight_smile:

Regards
damencho

···

On Fri, Nov 1, 2013 at 6:32 PM, Yana Stamcheva <yana@jitsi.org> wrote:

Hey,

One more thing. Is there a way to change the photo of a particular account (I don't see it)? Maybe it would be a good idea to add this possibility here.

Cheers,
Yana

On 01 Nov 2013, at 17:28, Yana Stamcheva <yana@jitsi.org> wrote:

Hi Marin,

On 18 Oct 2013, at 13:26, Marin Dzhigarov <marin@bluejimp.com> wrote:

Hello,

I'm sending the newest patch for a review and some screenshots. Also, this jar should be added to lib/installer-exclude.

Looking forward for any feedback!

Thanks for the good work!

I've just applied your patch and it looks good. I have some requests before being able to commit it though.

Here they are (in no particular order):

* I have an ippi account (which is basically a custom sip provider), which appears as a first entry in the account info combo box with an empty form below it (screenshot attached). I think it shouldn't appear there if it doesn't support account info edit and one way of doing it would be to add a method to the OperationSetServerStoredAccountInfo, which is isEditable().

* After modifying my jabber vCard and hitting "Apply" I see the following line in the Console :

[java] 17:00:21.545 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.actionPerformed().751 Failed to update URL detail due to malformed URL.

I didn't add an URL to my details and it didn't have any consequences, but we should fix it anyway :slight_smile:

* The edit menu item icon is kind of old, I'll send you a newer one.

* When I scroll to the bottom of the details, then close the window, then open it again, the scroll will be at the bottom, IMO the form should be refreshed to the top.

* When I tried to delete some of the details I've previously entered I get the following exceptions. And even if they appeared to be deleted from the form, when I restart jitsi they're still there!

[java] 17:20:07.351 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. First Name java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.351 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Middle Name java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.352 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Last Name java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.352 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Nickname java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.352 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.actionPerformed().751 Failed to update URL detail due to malformed URL.
     [java] 17:20:07.352 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. URL java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.353 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Birth Date java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.353 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Address java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.353 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. City java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.353 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Region/Province/State java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.354 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Postal/Zip Code java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.354 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Country java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.354 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. e-mail java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.354 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Work e-mail java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.354 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Work Organization Name java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.355 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Job Title java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
     [java] 17:20:07.355 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Description java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached

In my installation I have 3 account. One ippi, one jit.si account, which served for the vCards tests and one gmail account.

If you need more information don't hesitate to contact me.

Cheers,
Yana

<Screen Shot 2013-11-01 at 16.59.00.png>

Regards,
Marin

On Fri, Oct 18, 2013 at 2:10 PM, Marin Dzhigarov <marin@bluejimp.com> wrote:
Hello,

I'm sending the newest patch for a review, a jar that should be added to lib/installer-exclude and also some screenshots.

Looking forward for any feedback!

Regards,
Marin

On Fri, Oct 11, 2013 at 11:09 AM, Emil Ivov <emcho@jitsi.org> wrote:
On Fri, Oct 11, 2013 at 9:51 AM, Marin Dzhigarov <marin@bluejimp.com> wrote:
> Should I proceed and add "URL", "Description", "Full Name", "Job Title",
> "Role", "Birth date" as generic fields?

Yes please. (Actually, I am not certain we need "Full Name" and "Role"
actually, but the rest would be good to add. Especially URL, which we
even show in the contact list).

>
> Regards,
> Marin
>
>
>
>
>
> On Fri, Oct 11, 2013 at 10:35 AM, Emil Ivov <emcho@jitsi.org> wrote:
>>
>> Thanks,
>>
>> Several quick notes:
>>
>> * It'll be better for the combo box to have a default selection so thast
>> the form wouldn't open empty.
>>
>> * Aren't we missing some vcard fields? For example, I am not seeing the
>> possibility to set a URL anywhere. I also don't see things like
>> "Description", "Full Name", "Job Title", "Role", "Birth date"
>>
>> * Could you please make sure that the panel is transparent so that it
>> doesn't appear grey
>>
>> * Could you please also make this option available in a right-click menu
>> in our account list?
>>
>>
>> Thanks,
>>
>> Emil
>>
>> --sent from my mobile
>>
>> On 11 Oct 2013 09:17, "Marin Dzhigarov" <marin@bluejimp.com> wrote:
>>>
>>> Hello,
>>>
>>> I'm uploading some screenshots of the gui so you can quickly review the
>>> changes.
>>>
>>> Regards,
>>> Marin
>>>
>>> _______________________________________________
>>> dev mailing list
>>> dev@jitsi.org
>>> Unsubscribe instructions and other list options:
>>> http://lists.jitsi.org/mailman/listinfo/dev
>>
>>
>> _______________________________________________
>> dev mailing list
>> dev@jitsi.org
>> Unsubscribe instructions and other list options:
>> http://lists.jitsi.org/mailman/listinfo/dev
>
>
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
https://jitsi.org FAX: +33.1.77.62.47.31

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

<1.png><2.png><vCard1.patch>_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#12

Hello,

Thanks for the great review!

* I have an ippi account (which is basically a custom sip provider), which
appears as a first entry in the account info combo box with an empty form
below it (screenshot attached). I think it shouldn't appear there if it
doesn't support account info edit and one way of doing it would be to add a
method to the OperationSetServerStoredAccountInfo, which is isEditable().

Alright, this will be done. However, I don't think that isEditable() method
is a the best way. The main purpose of the OperationSetServerStoredAccountInfo
is for protocols to implement it when they support edition of account
information. It will be confusing to have a protocol that implements "the
account edition functionality" but at the same time have an isEditable()
method returning false. I think it's best to add this check to the account
info plugin.

* After modifying my jabber vCard and hitting "Apply" I see the following
line in the Console :
Done.. just lowered the logging level to debug.

* The edit menu item icon is kind of old, I'll send you a newer one.
Please, do.

* When I scroll to the bottom of the details, then close the window, then
open it again, the scroll will be at the bottom, IMO the form should be
refreshed to the top.
Done.

* When I tried to delete some of the details I've previously entered I get
the following exceptions. And even if they appeared to be deleted from the
form, when I restart jitsi they're still there!
This is very odd. I'm trying to reproduce this all morning and did not
experience such a behaviour even once. I would need more details on this
one.

* That's what I thought actually. My idea is not to move it from the
contact list, but in addition to what we have in the contact list to have
the possibility to modify the account specific image from the new account
info form. I still think we should keep the one-click global account image
edition from the contact list.
I can do that but I don't like this very much...
The image in the contact list and the one in the account info plugin will
not be in sync and users may get confused.
What do the others think?

Regards,
Marin

···

On Fri, Nov 1, 2013 at 7:54 PM, Emil Ivov <emcho@jitsi.org> wrote:

Hey Peter,

On Fri, Nov 1, 2013 at 6:17 PM, Peter Saint-Andre <stpeter@stpeter.im> > wrote:
> Are there plans to support the (much more extensible) vCard4 standard?

We haven't specifically discussed it but I suppose we will switch at
some point. Not sure when though. Running into a specific problem with
3.0 or badly needing a feature in 4.0 would certainly expedite the
process.

Emil

--
https://jitsi.org

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#13

Hi Damian,

Hi,

just to add, we already have the editing of account image from the
contact list where we display it. We discussed it offline and we
agreed back then that it is not priority to move it from the ui to
this plugin.

In display of account image we modify all accounts images in one step,
by moving it into account settings we can do it per account. Or we can
move it once the other edit functionality is present, as a second step
:slight_smile:

That's what I thought actually. My idea is not to move it from the contact list, but in addition to what we have in the contact list to have the possibility to modify the account specific image from the new account info form. I still think we should keep the one-click global account image edition from the contact list.

Cheers,
Yana

···

On 01 Nov 2013, at 17:42, Damian Minkov <damencho@jitsi.org> wrote:

Regards
damencho

On Fri, Nov 1, 2013 at 6:32 PM, Yana Stamcheva <yana@jitsi.org> wrote:

Hey,

One more thing. Is there a way to change the photo of a particular account (I don't see it)? Maybe it would be a good idea to add this possibility here.

Cheers,
Yana

On 01 Nov 2013, at 17:28, Yana Stamcheva <yana@jitsi.org> wrote:

Hi Marin,

On 18 Oct 2013, at 13:26, Marin Dzhigarov <marin@bluejimp.com> wrote:

Hello,

I'm sending the newest patch for a review and some screenshots. Also, this jar should be added to lib/installer-exclude.

Looking forward for any feedback!

Thanks for the good work!

I've just applied your patch and it looks good. I have some requests before being able to commit it though.

Here they are (in no particular order):

* I have an ippi account (which is basically a custom sip provider), which appears as a first entry in the account info combo box with an empty form below it (screenshot attached). I think it shouldn't appear there if it doesn't support account info edit and one way of doing it would be to add a method to the OperationSetServerStoredAccountInfo, which is isEditable().

* After modifying my jabber vCard and hitting "Apply" I see the following line in the Console :

[java] 17:00:21.545 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.actionPerformed().751 Failed to update URL detail due to malformed URL.

I didn't add an URL to my details and it didn't have any consequences, but we should fix it anyway :slight_smile:

* The edit menu item icon is kind of old, I'll send you a newer one.

* When I scroll to the bottom of the details, then close the window, then open it again, the scroll will be at the bottom, IMO the form should be refreshed to the top.

* When I tried to delete some of the details I've previously entered I get the following exceptions. And even if they appeared to be deleted from the form, when I restart jitsi they're still there!

[java] 17:20:07.351 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. First Name java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
    [java] 17:20:07.351 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Middle Name java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
    [java] 17:20:07.352 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Last Name java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
    [java] 17:20:07.352 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Nickname java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
    [java] 17:20:07.352 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.actionPerformed().751 Failed to update URL detail due to malformed URL.
    [java] 17:20:07.352 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. URL java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
    [java] 17:20:07.353 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Birth Date java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
    [java] 17:20:07.353 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Address java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
    [java] 17:20:07.353 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. City java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
    [java] 17:20:07.353 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Region/Province/State java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
    [java] 17:20:07.354 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Postal/Zip Code java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
    [java] 17:20:07.354 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Country java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
    [java] 17:20:07.354 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. e-mail java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
    [java] 17:20:07.354 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Work e-mail java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
    [java] 17:20:07.354 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Work Organization Name java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
    [java] 17:20:07.355 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Job Title java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached
    [java] 17:20:07.355 SEVERE: [14] plugin.accountinfo.AccountDetailsPanel.addDetail().905 Failed to update account details. Description java.lang.ArrayIndexOutOfBoundsException: Max count for this detail is already reached

In my installation I have 3 account. One ippi, one jit.si account, which served for the vCards tests and one gmail account.

If you need more information don't hesitate to contact me.

Cheers,
Yana

<Screen Shot 2013-11-01 at 16.59.00.png>

Regards,
Marin

On Fri, Oct 18, 2013 at 2:10 PM, Marin Dzhigarov <marin@bluejimp.com> wrote:
Hello,

I'm sending the newest patch for a review, a jar that should be added to lib/installer-exclude and also some screenshots.

Looking forward for any feedback!

Regards,
Marin

On Fri, Oct 11, 2013 at 11:09 AM, Emil Ivov <emcho@jitsi.org> wrote:
On Fri, Oct 11, 2013 at 9:51 AM, Marin Dzhigarov <marin@bluejimp.com> wrote:

Should I proceed and add "URL", "Description", "Full Name", "Job Title",
"Role", "Birth date" as generic fields?

Yes please. (Actually, I am not certain we need "Full Name" and "Role"
actually, but the rest would be good to add. Especially URL, which we
even show in the contact list).

Regards,
Marin

On Fri, Oct 11, 2013 at 10:35 AM, Emil Ivov <emcho@jitsi.org> wrote:

Thanks,

Several quick notes:

* It'll be better for the combo box to have a default selection so thast
the form wouldn't open empty.

* Aren't we missing some vcard fields? For example, I am not seeing the
possibility to set a URL anywhere. I also don't see things like
"Description", "Full Name", "Job Title", "Role", "Birth date"

* Could you please make sure that the panel is transparent so that it
doesn't appear grey

* Could you please also make this option available in a right-click menu
in our account list?

Thanks,

Emil

--sent from my mobile

On 11 Oct 2013 09:17, "Marin Dzhigarov" <marin@bluejimp.com> wrote:

Hello,

I'm uploading some screenshots of the gui so you can quickly review the
changes.

Regards,
Marin

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
https://jitsi.org FAX: +33.1.77.62.47.31

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

<1.png><2.png><vCard1.patch>_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#14

Hi Marin,

Hello,

Thanks for the great review!

* I have an ippi account (which is basically a custom sip provider), which appears as a first entry in the account info combo box with an empty form below it (screenshot attached). I think it shouldn't appear there if it doesn't support account info edit and one way of doing it would be to add a method to the OperationSetServerStoredAccountInfo, which is isEditable().

Alright, this will be done. However, I don't think that isEditable() method is a the best way. The main purpose of the OperationSetServerStoredAccountInfo is for protocols to implement it when they support edition of account information.

No it is not. The main purpose of the OperationSetServerStoredAccountInfo is to give access to server stored account details. This very well be read-only access.

It will be confusing to have a protocol that implements "the account edition functionality" but at the same time have an isEditable() method returning false. I think it's best to add this check to the account info plugin.

The check will be added in the account info plugin, the problem is on what ground would you check what protocols support OperationSetServerStoredAccountInfo, what support read-only account details and what support editable account details.

We already have the information for the first case. In the above example the SIP protocol provider is in the second case. It already supports OperationSetServerStoredAccountInfo, but it doesn't yet support editable details. It's unacceptable to show an empty account detail form for it. Now that I've checked it supports the operation set I think we should still see it in the account info window but show all information as read-only (as in the attached screenshot from contact info or an improved version of it).

I've suggested to add the isEditable() method to the OperationSetServerStoredAccountInfo in order to distinguish this second case and handle it properly in the UI. Another even better approach would be to create an OperationSetServerStoredEditableAccountInfo, which extends the OperationSetServerStoredAccountInfo and have the method save() that you've currently added to the original OperationSet. I remember we've actually already discussed this off-list when you've started working on the project.
)

* After modifying my jabber vCard and hitting "Apply" I see the following line in the Console :
Done.. just lowered the logging level to debug.

Great!

* The edit menu item icon is kind of old, I'll send you a newer one.
Please, do.

* When I scroll to the bottom of the details, then close the window, then open it again, the scroll will be at the bottom, IMO the form should be refreshed to the top.
Done.

Thanks

* When I tried to delete some of the details I've previously entered I get the following exceptions. And even if they appeared to be deleted from the form, when I restart jitsi they're still there!
This is very odd. I'm trying to reproduce this all morning and did not experience such a behaviour even once. I would need more details on this one.

Have you tried to set up the same environment as what I've explained? I'm on java6, I have 2 accounts, an ippi one and a jit.si one. I entered the details, saved them, restarted jitsi, tried to delete the previously entered details, they disappear from the form as expected, but after a jitsi restart they're still there and they were not deleted from the server.

* That's what I thought actually. My idea is not to move it from the contact list, but in addition to what we have in the contact list to have the possibility to modify the account specific image from the new account info form. I still think we should keep the one-click global account image edition from the contact list.
I can do that but I don't like this very much...
The image in the contact list and the one in the account info plugin will not be in sync and users may get confused.

I agree this could be a reasonable concern. I still think people could be confused as to why they could not edit their image, while they can edit everything else. Maybe we could make it more clear that the image in the contact list is a global image. As an example Adium has exactly the same functionality and allows for a picture change both in account edit and global photo edit (screenshot attached).

Cheers,
Yana

···

On 04 Nov 2013, at 09:13, Marin Dzhigarov <marin@bluejimp.com> wrote:

What do the others think?

Regards,
Marin

On Fri, Nov 1, 2013 at 7:54 PM, Emil Ivov <emcho@jitsi.org> wrote:
Hey Peter,

On Fri, Nov 1, 2013 at 6:17 PM, Peter Saint-Andre <stpeter@stpeter.im> wrote:
> Are there plans to support the (much more extensible) vCard4 standard?

We haven't specifically discussed it but I suppose we will switch at
some point. Not sure when though. Running into a specific problem with
3.0 or badly needing a feature in 4.0 would certainly expedite the
process.

Emil

--
https://jitsi.org

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#15

Hello Yana,

I'm sending you the latest patch plus some screenshots.

Please review the changes and if you have any comments feel free to message
me.

Regards,
Marin

vCard.patch (327 KB)

···

On Fri, Nov 8, 2013 at 1:48 PM, Marin Dzhigarov <marin@bluejimp.com> wrote:

Hello Yana,

Here is the newest patch plus some screenshots.

Please review the changes. Any comments will be appreciated.

Regards,
Marin

On Mon, Nov 4, 2013 at 1:07 PM, Yana Stamcheva <yana@jitsi.org> wrote:

Hi Marin,

On 04 Nov 2013, at 09:13, Marin Dzhigarov <marin@bluejimp.com> wrote:

Hello,

Thanks for the great review!

* I have an ippi account (which is basically a custom sip provider),
which appears as a first entry in the account info combo box with an empty
form below it (screenshot attached). I think it shouldn't appear there if
it doesn't support account info edit and one way of doing it would be to
add a method to the OperationSetServerStoredAccountInfo, which is
isEditable().

Alright, this will be done. However, I don't think that isEditable()
method is a the best way. The main purpose of
the OperationSetServerStoredAccountInfo is for protocols to implement it
when they support edition of account information.

No it is not. The main purpose of the OperationSetServerStoredAccountInfo
is to give access to server stored account details. This very well be
read-only access.

It will be confusing to have a protocol that implements "the account
edition functionality" but at the same time have an isEditable() method
returning false. I think it's best to add this check to the account info
plugin.

The check will be added in the account info plugin, the problem is on
what ground would you check what protocols support
OperationSetServerStoredAccountInfo, what support read-only account details
and what support editable account details.

We already have the information for the first case. In the above example
the SIP protocol provider is in the second case. It already
supports OperationSetServerStoredAccountInfo, but it doesn't yet support
editable details. It's unacceptable to show an empty account detail form
for it. Now that I've checked it supports the operation set I think we
should still see it in the account info window but show all information as
read-only (as in the attached screenshot from contact info or an improved
version of it).

I've suggested to add the isEditable() method to
the OperationSetServerStoredAccountInfo in order to distinguish this second
case and handle it properly in the UI. Another even better approach would
be to create an OperationSetServerStoredEditableAccountInfo, which extends
the OperationSetServerStoredAccountInfo and have the method save() that
you've currently added to the original OperationSet. I remember we've
actually already discussed this off-list when you've started working on the
project.
)

* After modifying my jabber vCard and hitting "Apply" I see the following
line in the Console :
Done.. just lowered the logging level to debug.

Great!

* The edit menu item icon is kind of old, I'll send you a newer one.
Please, do.

* When I scroll to the bottom of the details, then close the window, then
open it again, the scroll will be at the bottom, IMO the form should be
refreshed to the top.
Done.

Thanks

* When I tried to delete some of the details I've previously entered I
get the following exceptions. And even if they appeared to be deleted from
the form, when I restart jitsi they're still there!
This is very odd. I'm trying to reproduce this all morning and did not
experience such a behaviour even once. I would need more details on this
one.

Have you tried to set up the same environment as what I've explained? I'm
on java6, I have 2 accounts, an ippi one and a jit.si one. I entered the
details, saved them, restarted jitsi, tried to delete the previously
entered details, they disappear from the form as expected, but after a
jitsi restart they're still there and they were not deleted from the server.

* That's what I thought actually. My idea is not to move it from the
contact list, but in addition to what we have in the contact list to have
the possibility to modify the account specific image from the new account
info form. I still think we should keep the one-click global account image
edition from the contact list.
I can do that but I don't like this very much...
The image in the contact list and the one in the account info plugin will
not be in sync and users may get confused.

I agree this could be a reasonable concern. I still think people could be
confused as to why they could not edit their image, while they can edit
everything else. Maybe we could make it more clear that the image in the
contact list is a global image. As an example Adium has exactly the same
functionality and allows for a picture change both in account edit and
global photo edit (screenshot attached).

Cheers,
Yana

What do the others think?

Regards,
Marin

On Fri, Nov 1, 2013 at 7:54 PM, Emil Ivov <emcho@jitsi.org> wrote:
Hey Peter,

On Fri, Nov 1, 2013 at 6:17 PM, Peter Saint-Andre <stpeter@stpeter.im> >> wrote:
> Are there plans to support the (much more extensible) vCard4 standard?

We haven't specifically discussed it but I suppose we will switch at
some point. Not sure when though. Running into a specific problem with
3.0 or badly needing a feature in 4.0 would certainly expedite the
process.

Emil

--
https://jitsi.org

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#16

Hi Marin,

Hello Yana,

I'm sending you the latest patch plus some screenshots.

Looks great!

Please review the changes and if you have any comments feel free to

message me.

I'll be able to make a more thorough review later today and will keep you
posted.

I think we should rename "Use global icon" to "Use global picture", but
it's a minor issue and I could do that while applying the patch.

Thanks for the good work!
Yana

Regards,
Marin

Hello Yana,

Here is the newest patch plus some screenshots.

Please review the changes. Any comments will be appreciated.

Regards,
Marin

Hi Marin,

Hello,

Thanks for the great review!

* I have an ippi account (which is basically a custom sip provider),

which appears as a first entry in the account info combo box with an empty
form below it (screenshot attached). I think it shouldn't appear there if
it doesn't support account info edit and one way of doing it would be to
add a method to the OperationSetServerStoredAccountInfo, which is
isEditable().

Alright, this will be done. However, I don't think that isEditable()

method is a the best way. The main purpose of
the OperationSetServerStoredAccountInfo is for protocols to implement it
when they support edition of account information.

No it is not. The main purpose of the

OperationSetServerStoredAccountInfo is to give access to server stored
account details. This very well be read-only access.

It will be confusing to have a protocol that implements "the account

edition functionality" but at the same time have an isEditable() method
returning false. I think it's best to add this check to the account info
plugin.

The check will be added in the account info plugin, the problem is on

what ground would you check what protocols support
OperationSetServerStoredAccountInfo, what support read-only account details
and what support editable account details.

We already have the information for the first case. In the above

example the SIP protocol provider is in the second case. It already
supports OperationSetServerStoredAccountInfo, but it doesn't yet support
editable details. It's unacceptable to show an empty account detail form
for it. Now that I've checked it supports the operation set I think we
should still see it in the account info window but show all information as
read-only (as in the attached screenshot from contact info or an improved
version of it).

I've suggested to add the isEditable() method to

the OperationSetServerStoredAccountInfo in order to distinguish this second
case and handle it properly in the UI. Another even better approach would
be to create an OperationSetServerStoredEditableAccountInfo, which extends
the OperationSetServerStoredAccountInfo and have the method save() that
you've currently added to the original OperationSet. I remember we've
actually already discussed this off-list when you've started working on the
project.

)

* After modifying my jabber vCard and hitting "Apply" I see the

following line in the Console :

Done.. just lowered the logging level to debug.

Great!

* The edit menu item icon is kind of old, I'll send you a newer one.
Please, do.

* When I scroll to the bottom of the details, then close the window,

then open it again, the scroll will be at the bottom, IMO the form should
be refreshed to the top.

Done.

Thanks

* When I tried to delete some of the details I've previously entered I

get the following exceptions. And even if they appeared to be deleted from
the form, when I restart jitsi they're still there!

This is very odd. I'm trying to reproduce this all morning and did not

experience such a behaviour even once. I would need more details on this
one.

Have you tried to set up the same environment as what I've explained?

I'm on java6, I have 2 accounts, an ippi one and a jit.si one. I entered
the details, saved them, restarted jitsi, tried to delete the previously
entered details, they disappear from the form as expected, but after a
jitsi restart they're still there and they were not deleted from the server.

* That's what I thought actually. My idea is not to move it from the

contact list, but in addition to what we have in the contact list to have
the possibility to modify the account specific image from the new account
info form. I still think we should keep the one-click global account image
edition from the contact list.

I can do that but I don't like this very much...
The image in the contact list and the one in the account info plugin

will not be in sync and users may get confused.

I agree this could be a reasonable concern. I still think people could

be confused as to why they could not edit their image, while they can edit
everything else. Maybe we could make it more clear that the image in the
contact list is a global image. As an example Adium has exactly the same
functionality and allows for a picture change both in account edit and
global photo edit (screenshot attached).

Cheers,
Yana

What do the others think?

Regards,
Marin

Hey Peter,

> Are there plans to support the (much more extensible) vCard4

standard?

···

On Nov 8, 2013 2:29 PM, "Marin Dzhigarov" <marin@bluejimp.com> wrote:

On Fri, Nov 8, 2013 at 1:48 PM, Marin Dzhigarov <marin@bluejimp.com> wrote:

On Mon, Nov 4, 2013 at 1:07 PM, Yana Stamcheva <yana@jitsi.org> wrote:

On 04 Nov 2013, at 09:13, Marin Dzhigarov <marin@bluejimp.com> wrote:

On Fri, Nov 1, 2013 at 7:54 PM, Emil Ivov <emcho@jitsi.org> wrote:
On Fri, Nov 1, 2013 at 6:17 PM, Peter Saint-Andre <stpeter@stpeter.im> wrote:

We haven't specifically discussed it but I suppose we will switch at
some point. Not sure when though. Running into a specific problem with
3.0 or badly needing a feature in 4.0 would certainly expedite the
process.

Emil

--
https://jitsi.org

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#17

Hi Marin,

Hello Yana,

I'm sending you the latest patch plus some screenshots.

Please review the changes and if you have any comments feel free to message me.

Thanks for fixing the issues. Good work!

Your patch is now committed and ack-ed on our Contributors page.

I had to make the following minor modifications:

* Made some changes in FramedImage class in order to fix the pixilated image in the account details dialog.

* Before creating a new detail class, added a check in order to know if this one has been edited by the user.

* Made use of the removeDetail function, instead of replaceDetail, when a detail has been deleted (this one has fixed a problem of persisting deleted details, explained in one of my previous emails)

* Fixed the initial dialog size (it was too small and the fields were cut)

I have one more minor request for an improvement when you have the time :slight_smile: When the Birth Date field is deleted, the Age field isn't updated on the fly (while it is updated when we add a Birth Date).

Cheers,
Yana

···

On 08 Nov 2013, at 12:50, Marin Dzhigarov <marin@bluejimp.com> wrote:

Regards,
Marin

On Fri, Nov 8, 2013 at 1:48 PM, Marin Dzhigarov <marin@bluejimp.com> wrote:
Hello Yana,

Here is the newest patch plus some screenshots.

Please review the changes. Any comments will be appreciated.

Regards,
Marin

On Mon, Nov 4, 2013 at 1:07 PM, Yana Stamcheva <yana@jitsi.org> wrote:
Hi Marin,

On 04 Nov 2013, at 09:13, Marin Dzhigarov <marin@bluejimp.com> wrote:

Hello,

Thanks for the great review!

* I have an ippi account (which is basically a custom sip provider), which appears as a first entry in the account info combo box with an empty form below it (screenshot attached). I think it shouldn't appear there if it doesn't support account info edit and one way of doing it would be to add a method to the OperationSetServerStoredAccountInfo, which is isEditable().

Alright, this will be done. However, I don't think that isEditable() method is a the best way. The main purpose of the OperationSetServerStoredAccountInfo is for protocols to implement it when they support edition of account information.

No it is not. The main purpose of the OperationSetServerStoredAccountInfo is to give access to server stored account details. This very well be read-only access.

It will be confusing to have a protocol that implements "the account edition functionality" but at the same time have an isEditable() method returning false. I think it's best to add this check to the account info plugin.

The check will be added in the account info plugin, the problem is on what ground would you check what protocols support OperationSetServerStoredAccountInfo, what support read-only account details and what support editable account details.

We already have the information for the first case. In the above example the SIP protocol provider is in the second case. It already supports OperationSetServerStoredAccountInfo, but it doesn't yet support editable details. It's unacceptable to show an empty account detail form for it. Now that I've checked it supports the operation set I think we should still see it in the account info window but show all information as read-only (as in the attached screenshot from contact info or an improved version of it).

I've suggested to add the isEditable() method to the OperationSetServerStoredAccountInfo in order to distinguish this second case and handle it properly in the UI. Another even better approach would be to create an OperationSetServerStoredEditableAccountInfo, which extends the OperationSetServerStoredAccountInfo and have the method save() that you've currently added to the original OperationSet. I remember we've actually already discussed this off-list when you've started working on the project.
<Screen Shot 2013-11-04 at 11.41.25.png>)

* After modifying my jabber vCard and hitting "Apply" I see the following line in the Console :
Done.. just lowered the logging level to debug.

Great!

* The edit menu item icon is kind of old, I'll send you a newer one.
Please, do.

* When I scroll to the bottom of the details, then close the window, then open it again, the scroll will be at the bottom, IMO the form should be refreshed to the top.
Done.

Thanks

* When I tried to delete some of the details I've previously entered I get the following exceptions. And even if they appeared to be deleted from the form, when I restart jitsi they're still there!
This is very odd. I'm trying to reproduce this all morning and did not experience such a behaviour even once. I would need more details on this one.

Have you tried to set up the same environment as what I've explained? I'm on java6, I have 2 accounts, an ippi one and a jit.si one. I entered the details, saved them, restarted jitsi, tried to delete the previously entered details, they disappear from the form as expected, but after a jitsi restart they're still there and they were not deleted from the server.

* That's what I thought actually. My idea is not to move it from the contact list, but in addition to what we have in the contact list to have the possibility to modify the account specific image from the new account info form. I still think we should keep the one-click global account image edition from the contact list.
I can do that but I don't like this very much...
The image in the contact list and the one in the account info plugin will not be in sync and users may get confused.

I agree this could be a reasonable concern. I still think people could be confused as to why they could not edit their image, while they can edit everything else. Maybe we could make it more clear that the image in the contact list is a global image. As an example Adium has exactly the same functionality and allows for a picture change both in account edit and global photo edit (screenshot attached).

<Screen Shot 2013-11-04 at 12.06.37.png>

Cheers,
Yana

What do the others think?

Regards,
Marin

On Fri, Nov 1, 2013 at 7:54 PM, Emil Ivov <emcho@jitsi.org> wrote:
Hey Peter,

On Fri, Nov 1, 2013 at 6:17 PM, Peter Saint-Andre <stpeter@stpeter.im> wrote:
> Are there plans to support the (much more extensible) vCard4 standard?

We haven't specifically discussed it but I suppose we will switch at
some point. Not sure when though. Running into a specific problem with
3.0 or badly needing a feature in 4.0 would certainly expedite the
process.

Emil

--
https://jitsi.org

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

<1.png><2.png><3.png><vCard.patch>_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev