[jitsi-dev] [patch] turnserver (and other packages) - RFCs not permitted


#1

Joachim noticed that some RFC documents are included in turnserver tarball

Technically, it is not possible to distribute them because of the way
they are licensed, the reasons are explained here:

  http://wiki.debian.org/NonFreeIETFDocuments

The can still be included in the source repository if necessary, but we
need another release of the tarball without any RFCs inside.

The quick solution is the delete them from the repository, but if that
is not desirable, I think this is the way to patch it:

Makefile.am:

- SUBDIRS = src man test
+ SUBDIRS = src man test doc
- EXTRA_DIST = extra doc Doxyfile aminclude.am acinclude.m4
+ EXTRA_DIST = extra Doxyfile aminclude.am acinclude.m4

configure.ac:

  AC_CONFIG_FILES([Makefile
+ doc/Makefile
                 src/Makefile
                 man/Makefile
                 test/Makefile])

and then create doc/Makefile.am:

EXTRA_DIST = coding_style.txt doxygen-main.h


#2

Hi Daniel,

Le 11/10/2012 22:40, Daniel Pocock a �crit :

Joachim noticed that some RFC documents are included in turnserver tarball

Technically, it is not possible to distribute them because of the way
they are licensed, the reasons are explained here:

   http://wiki.debian.org/NonFreeIETFDocuments

The can still be included in the source repository if necessary, but we
need another release of the tarball without any RFCs inside.

The quick solution is the delete them from the repository, but if that
is not desirable, I think this is the way to patch it:

Makefile.am:

- SUBDIRS = src man test
+ SUBDIRS = src man test doc
- EXTRA_DIST = extra doc Doxyfile aminclude.am acinclude.m4
+ EXTRA_DIST = extra Doxyfile aminclude.am acinclude.m4

configure.ac:

   AC_CONFIG_FILES([Makefile
+ doc/Makefile
                  src/Makefile
                  man/Makefile
                  test/Makefile])

and then create doc/Makefile.am:

EXTRA_DIST = coding_style.txt doxygen-main.h

The second solution sounds good. I will make the changes ASAP.

Regards,

···

--
Seb


#3

Done in SVN revision 219.

Regards,

···

--
Seb

Le 12/10/2012 08:18, Sebastien Vincent a �crit :

Hi Daniel,

Le 11/10/2012 22:40, Daniel Pocock a �crit :

Joachim noticed that some RFC documents are included in turnserver tarball

Technically, it is not possible to distribute them because of the way
they are licensed, the reasons are explained here:

   http://wiki.debian.org/NonFreeIETFDocuments

The can still be included in the source repository if necessary, but we
need another release of the tarball without any RFCs inside.

The quick solution is the delete them from the repository, but if that
is not desirable, I think this is the way to patch it:

Makefile.am:

- SUBDIRS = src man test
+ SUBDIRS = src man test doc
- EXTRA_DIST = extra doc Doxyfile aminclude.am acinclude.m4
+ EXTRA_DIST = extra Doxyfile aminclude.am acinclude.m4

configure.ac:

   AC_CONFIG_FILES([Makefile
+ doc/Makefile
                  src/Makefile
                  man/Makefile
                  test/Makefile])

and then create doc/Makefile.am:

EXTRA_DIST = coding_style.txt doxygen-main.h

The second solution sounds good. I will make the changes ASAP.

Regards,
--
Seb


#4

Thanks for looking at this so quickly

Do you have other pending changes, or if not, would it be too much
trouble to release a 0.7.1 tarball that we can upload into Debian?

···

On 12/10/12 10:33, Sebastien Vincent wrote:

Done in SVN revision 219.

Regards,
--
Seb

Le 12/10/2012 08:18, Sebastien Vincent a �crit :

Hi Daniel,

Le 11/10/2012 22:40, Daniel Pocock a �crit :

Joachim noticed that some RFC documents are included in turnserver
tarball

Technically, it is not possible to distribute them because of the way
they are licensed, the reasons are explained here:

   http://wiki.debian.org/NonFreeIETFDocuments

The can still be included in the source repository if necessary, but we
need another release of the tarball without any RFCs inside.

The quick solution is the delete them from the repository, but if that
is not desirable, I think this is the way to patch it:

Makefile.am:

- SUBDIRS = src man test
+ SUBDIRS = src man test doc
- EXTRA_DIST = extra doc Doxyfile aminclude.am acinclude.m4
+ EXTRA_DIST = extra Doxyfile aminclude.am acinclude.m4

configure.ac:

   AC_CONFIG_FILES([Makefile
+ doc/Makefile
                  src/Makefile
                  man/Makefile
                  test/Makefile])

and then create doc/Makefile.am:

EXTRA_DIST = coding_style.txt doxygen-main.h

The second solution sounds good. I will make the changes ASAP.

Regards,
--
Seb


#5

I will let 2-3 days before releasing a new version if you or Joachim have any other remarks.

Regards,

···

--
Seb

Le 12/10/2012 10:36, Daniel Pocock a �crit :

Thanks for looking at this so quickly

Do you have other pending changes, or if not, would it be too much
trouble to release a 0.7.1 tarball that we can upload into Debian?

On 12/10/12 10:33, Sebastien Vincent wrote:

Done in SVN revision 219.

Regards,
--
Seb

Le 12/10/2012 08:18, Sebastien Vincent a �crit :

Hi Daniel,

Le 11/10/2012 22:40, Daniel Pocock a �crit :

Joachim noticed that some RFC documents are included in turnserver
tarball

Technically, it is not possible to distribute them because of the way
they are licensed, the reasons are explained here:

    http://wiki.debian.org/NonFreeIETFDocuments

The can still be included in the source repository if necessary, but we
need another release of the tarball without any RFCs inside.

The quick solution is the delete them from the repository, but if that
is not desirable, I think this is the way to patch it:

Makefile.am:

- SUBDIRS = src man test
+ SUBDIRS = src man test doc
- EXTRA_DIST = extra doc Doxyfile aminclude.am acinclude.m4
+ EXTRA_DIST = extra Doxyfile aminclude.am acinclude.m4

configure.ac:

    AC_CONFIG_FILES([Makefile
+ doc/Makefile
                   src/Makefile
                   man/Makefile
                   test/Makefile])

and then create doc/Makefile.am:

EXTRA_DIST = coding_style.txt doxygen-main.h

The second solution sounds good. I will make the changes ASAP.

Regards,
--
Seb


#6

I haven't seen any other feedback from Joachim, so I'm hoping it is OK
to release again.

I know it can be a pain updating and releasing autotools projects,
remembering to update the version, tagging, etc.... that's why I
collaborated on the creation of this script:

   http://sourceforge.net/projects/git2dist/

It has been used for releasing other autotools projects (including
ganglia and flactag).

Please let me know if you find it helpful for turnserver

···

On 12/10/12 10:48, Sebastien Vincent wrote:

I will let 2-3 days before releasing a new version if you or Joachim
have any other remarks.

Regards,
--
Seb

Le 12/10/2012 10:36, Daniel Pocock a �crit :

Thanks for looking at this so quickly

Do you have other pending changes, or if not, would it be too much
trouble to release a 0.7.1 tarball that we can upload into Debian?

On 12/10/12 10:33, Sebastien Vincent wrote:

Done in SVN revision 219.

Regards,
--
Seb

Le 12/10/2012 08:18, Sebastien Vincent a �crit :

Hi Daniel,

Le 11/10/2012 22:40, Daniel Pocock a �crit :

Joachim noticed that some RFC documents are included in turnserver
tarball

Technically, it is not possible to distribute them because of the way
they are licensed, the reasons are explained here:

    http://wiki.debian.org/NonFreeIETFDocuments

The can still be included in the source repository if necessary,
but we
need another release of the tarball without any RFCs inside.

The quick solution is the delete them from the repository, but if that
is not desirable, I think this is the way to patch it:

Makefile.am:

- SUBDIRS = src man test
+ SUBDIRS = src man test doc
- EXTRA_DIST = extra doc Doxyfile aminclude.am acinclude.m4
+ EXTRA_DIST = extra Doxyfile aminclude.am acinclude.m4

configure.ac:

    AC_CONFIG_FILES([Makefile
+ doc/Makefile
                   src/Makefile
                   man/Makefile
                   test/Makefile])

and then create doc/Makefile.am:

EXTRA_DIST = coding_style.txt doxygen-main.h

The second solution sounds good. I will make the changes ASAP.

Regards,
--
Seb


#7

Hi,

I will do it today after work or tomorrow.

Regards,

···

--
Seb

Le mardi 16 octobre 2012, Daniel Pocock <daniel@pocock.com.au> a écrit :

I haven't seen any other feedback from Joachim, so I'm hoping it is OK
to release again.

I know it can be a pain updating and releasing autotools projects,
remembering to update the version, tagging, etc.... that's why I
collaborated on the creation of this script:

   http://sourceforge.net/projects/git2dist/

It has been used for releasing other autotools projects (including
ganglia and flactag).

Please let me know if you find it helpful for turnserver

On 12/10/12 10:48, Sebastien Vincent wrote:

I will let 2-3 days before releasing a new version if you or Joachim
have any other remarks.

Regards,
--
Seb

Le 12/10/2012 10:36, Daniel Pocock a écrit :

Thanks for looking at this so quickly

Do you have other pending changes, or if not, would it be too much
trouble to release a 0.7.1 tarball that we can upload into Debian?

On 12/10/12 10:33, Sebastien Vincent wrote:

Done in SVN revision 219.

Regards,
--
Seb

Le 12/10/2012 08:18, Sebastien Vincent a écrit :

Hi Daniel,

Le 11/10/2012 22:40, Daniel Pocock a écrit :

Joachim noticed that some RFC documents are included in turnserver
tarball

Technically, it is not possible to distribute them because of the way
they are licensed, the reasons are explained here:

    http://wiki.debian.org/NonFreeIETFDocuments

The can still be included in the source repository if necessary,
but we
need another release of the tarball without any RFCs inside.

The quick solution is the delete them from the repository, but if

that

is not desirable, I think this is the way to patch it:

Makefile.am:

- SUBDIRS = src man test
+ SUBDIRS = src man test doc
- EXTRA_DIST = extra doc Doxyfile aminclude.am acinclude.m4
+ EXTRA_DIST = extra Doxyfile aminclude.am acinclude.m4

configure.ac:

    AC_CONFIG_FILES([Makefile
+ doc/Makefile
                   src/Makefile
                   man/Makefile
                   test/Makefile])

and then create doc/Makefile.am:

EXTRA_DIST = coding_style.txt doxygen-main.h

The second solution sounds good. I will make the changes ASAP.

Regards,
--
Seb


#8

Hi,

Done. It should be available in a few hours in all SF mirrors.

Regards,

···

--
Seb

Le 17/10/2012 12:09, Sebastien Vincent a �crit :

Hi,

I will do it today after work or tomorrow.

Regards,
--
Seb

Le mardi 16 octobre 2012, Daniel Pocock <daniel@pocock.com.au <mailto:daniel@pocock.com.au>> a �crit :
>
> I haven't seen any other feedback from Joachim, so I'm hoping it is OK
> to release again.
>
> I know it can be a pain updating and releasing autotools projects,
> remembering to update the version, tagging, etc.... that's why I
> collaborated on the creation of this script:
>
> http://sourceforge.net/projects/git2dist/
>
> It has been used for releasing other autotools projects (including
> ganglia and flactag).
>
> Please let me know if you find it helpful for turnserver
>
> On 12/10/12 10:48, Sebastien Vincent wrote:
>> I will let 2-3 days before releasing a new version if you or Joachim
>> have any other remarks.
>>
>> Regards,
>> --
>> Seb
>>
>> Le 12/10/2012 10:36, Daniel Pocock a �crit :
>>> Thanks for looking at this so quickly
>>>
>>> Do you have other pending changes, or if not, would it be too much
>>> trouble to release a 0.7.1 tarball that we can upload into Debian?
>>>
>>> On 12/10/12 10:33, Sebastien Vincent wrote:
>>>> Done in SVN revision 219.
>>>>
>>>> Regards,
>>>> --
>>>> Seb
>>>>
>>>> Le 12/10/2012 08:18, Sebastien Vincent a �crit :
>>>>> Hi Daniel,
>>>>>
>>>>> Le 11/10/2012 22:40, Daniel Pocock a �crit :
>>>>>> Joachim noticed that some RFC documents are included in turnserver
>>>>>> tarball
>>>>>>
>>>>>> Technically, it is not possible to distribute them because of the way
>>>>>> they are licensed, the reasons are explained here:
>>>>>>
>>>>>> http://wiki.debian.org/NonFreeIETFDocuments
>>>>>>
>>>>>> The can still be included in the source repository if necessary,
>>>>>> but we
>>>>>> need another release of the tarball without any RFCs inside.
>>>>>>
>>>>>> The quick solution is the delete them from the repository, but if that
>>>>>> is not desirable, I think this is the way to patch it:
>>>>>>
>>>>>> Makefile.am:
>>>>>>
>>>>>> - SUBDIRS = src man test
>>>>>> + SUBDIRS = src man test doc
>>>>>> - EXTRA_DIST = extra doc Doxyfile aminclude.am <http://aminclude.am> acinclude.m4
>>>>>> + EXTRA_DIST = extra Doxyfile aminclude.am <http://aminclude.am> acinclude.m4
>>>>>>
>>>>>> configure.ac <http://configure.ac>:
>>>>>>
>>>>>> AC_CONFIG_FILES([Makefile
>>>>>> + doc/Makefile
>>>>>> src/Makefile
>>>>>> man/Makefile
>>>>>> test/Makefile])
>>>>>>
>>>>>> and then create doc/Makefile.am:
>>>>>>
>>>>>> EXTRA_DIST = coding_style.txt doxygen-main.h
>>>>> The second solution sounds good. I will make the changes ASAP.
>>>>>
>>>>> Regards,
>>>>> --
>>>>> Seb
>>>>>
>>
>


#9

Hi,

Done. It should be available in a few hours in all SF mirrors.

Regards,

···

--
Seb

Le 17/10/2012 12:09, Sebastien Vincent a �crit :

Hi,

I will do it today after work or tomorrow.

Regards,
--
Seb

Le mardi 16 octobre 2012, Daniel Pocock <daniel@pocock.com.au <mailto:daniel@pocock.com.au>> a �crit :
>
> I haven't seen any other feedback from Joachim, so I'm hoping it is OK
> to release again.
>
> I know it can be a pain updating and releasing autotools projects,
> remembering to update the version, tagging, etc.... that's why I
> collaborated on the creation of this script:
>
> http://sourceforge.net/projects/git2dist/
>
> It has been used for releasing other autotools projects (including
> ganglia and flactag).
>
> Please let me know if you find it helpful for turnserver
>
> On 12/10/12 10:48, Sebastien Vincent wrote:
>> I will let 2-3 days before releasing a new version if you or Joachim
>> have any other remarks.
>>
>> Regards,
>> --
>> Seb
>>
>> Le 12/10/2012 10:36, Daniel Pocock a �crit :
>>> Thanks for looking at this so quickly
>>>
>>> Do you have other pending changes, or if not, would it be too much
>>> trouble to release a 0.7.1 tarball that we can upload into Debian?
>>>
>>> On 12/10/12 10:33, Sebastien Vincent wrote:
>>>> Done in SVN revision 219.
>>>>
>>>> Regards,
>>>> --
>>>> Seb
>>>>
>>>> Le 12/10/2012 08:18, Sebastien Vincent a �crit :
>>>>> Hi Daniel,
>>>>>
>>>>> Le 11/10/2012 22:40, Daniel Pocock a �crit :
>>>>>> Joachim noticed that some RFC documents are included in turnserver
>>>>>> tarball
>>>>>>
>>>>>> Technically, it is not possible to distribute them because of the way
>>>>>> they are licensed, the reasons are explained here:
>>>>>>
>>>>>> http://wiki.debian.org/NonFreeIETFDocuments
>>>>>>
>>>>>> The can still be included in the source repository if necessary,
>>>>>> but we
>>>>>> need another release of the tarball without any RFCs inside.
>>>>>>
>>>>>> The quick solution is the delete them from the repository, but if that
>>>>>> is not desirable, I think this is the way to patch it:
>>>>>>
>>>>>> Makefile.am:
>>>>>>
>>>>>> - SUBDIRS = src man test
>>>>>> + SUBDIRS = src man test doc
>>>>>> - EXTRA_DIST = extra doc Doxyfile aminclude.am <http://aminclude.am> acinclude.m4
>>>>>> + EXTRA_DIST = extra Doxyfile aminclude.am <http://aminclude.am> acinclude.m4
>>>>>>
>>>>>> configure.ac <http://configure.ac>:
>>>>>>
>>>>>> AC_CONFIG_FILES([Makefile
>>>>>> + doc/Makefile
>>>>>> src/Makefile
>>>>>> man/Makefile
>>>>>> test/Makefile])
>>>>>>
>>>>>> and then create doc/Makefile.am:
>>>>>>
>>>>>> EXTRA_DIST = coding_style.txt doxygen-main.h
>>>>> The second solution sounds good. I will make the changes ASAP.
>>>>>
>>>>> Regards,
>>>>> --
>>>>> Seb
>>>>>
>>
>


#10

Hi Seb,

I notice the tarball still includes RFCs:

$ tar tjf ../turnserver_0.7.1.orig.tar.bz2 |grep doc
turnserver-0.7.1/doc/
turnserver-0.7.1/doc/doxygen-main.h
turnserver-0.7.1/doc/Makefile.in
turnserver-0.7.1/doc/rfc5766.txt
turnserver-0.7.1/doc/Makefile.am
turnserver-0.7.1/doc/rfc6062.txt
turnserver-0.7.1/doc/rfc6156.txt
turnserver-0.7.1/doc/rfc5389.txt
turnserver-0.7.1/doc/coding_style.txt

Are you using `make dist-bzip2' to create the tarball, or just tarring
up the directory from SVN?

`make dist-bzip2' gives me a .bz2 file without the RFCs:

svn co
https://turnserver.svn.sourceforge.net/svnroot/turnserver/tags/turnserver-0.7.1
turnserver
cd turnserver
autoreconf --install && ./configure && make dist-bzip2

$ tar tjf turnserver-0.7.1.tar.bz2 | grep doc
turnserver-0.7.1/doc/
turnserver-0.7.1/doc/coding_style.txt
turnserver-0.7.1/doc/Makefile.in
turnserver-0.7.1/doc/Makefile.am
turnserver-0.7.1/doc/doxygen-main.h

I did a diff of the tarballs and I notice that the `make dist' tarball
is missing some other stuff, LICENSE and LICENSE.OpenSSL, and having
`extra' in EXTRA_DIST (or any subdirectory for that matter) results in
it sucking up `.svn' directories.

I'd propose you just change this line in Makefile.am and then prepare a
0.7.2 using the `make dist-bzip2' method:

SUBDIRS = src man test doc extra
EXTRA_DIST = Doxyfile aminclude.am acinclude.m4 LICENSE LICENSE.OpenSSL

and adapting doc/Makefile.am into extra/Makefile.am

When you run

   tar tjf turnserver-0.7.2.tar.bz2

you should notice that the .svn directories are gone, the RFCs are gone
and the extra/* files should still be there.

Regards,

Daniel

···

On 17/10/12 18:38, Sebastien Vincent wrote:

Hi,

Done. It should be available in a few hours in all SF mirrors.

Regards,
--
Seb

Le 17/10/2012 12:09, Sebastien Vincent a �crit :

Hi,

I will do it today after work or tomorrow.

Regards,
--
Seb

Le mardi 16 octobre 2012, Daniel Pocock <daniel@pocock.com.au
<mailto:daniel@pocock.com.au>> a �crit :
>
>
> I haven't seen any other feedback from Joachim, so I'm hoping it is OK
> to release again.
>
> I know it can be a pain updating and releasing autotools projects,
> remembering to update the version, tagging, etc.... that's why I
> collaborated on the creation of this script:
>
> http://sourceforge.net/projects/git2dist/
>
> It has been used for releasing other autotools projects (including
> ganglia and flactag).
>
> Please let me know if you find it helpful for turnserver
>
>
>
>
>
> On 12/10/12 10:48, Sebastien Vincent wrote:
>> I will let 2-3 days before releasing a new version if you or Joachim
>> have any other remarks.
>>
>> Regards,
>> --
>> Seb
>>
>> Le 12/10/2012 10:36, Daniel Pocock a �crit :
>>> Thanks for looking at this so quickly
>>>
>>> Do you have other pending changes, or if not, would it be too much
>>> trouble to release a 0.7.1 tarball that we can upload into Debian?
>>>
>>>
>>>
>>> On 12/10/12 10:33, Sebastien Vincent wrote:
>>>> Done in SVN revision 219.
>>>>
>>>> Regards,
>>>> --
>>>> Seb
>>>>
>>>> Le 12/10/2012 08:18, Sebastien Vincent a �crit :
>>>>> Hi Daniel,
>>>>>
>>>>> Le 11/10/2012 22:40, Daniel Pocock a �crit :
>>>>>> Joachim noticed that some RFC documents are included in turnserver
>>>>>> tarball
>>>>>>
>>>>>> Technically, it is not possible to distribute them because of
the way
>>>>>> they are licensed, the reasons are explained here:
>>>>>>
>>>>>> http://wiki.debian.org/NonFreeIETFDocuments
>>>>>>
>>>>>> The can still be included in the source repository if necessary,
>>>>>> but we
>>>>>> need another release of the tarball without any RFCs inside.
>>>>>>
>>>>>> The quick solution is the delete them from the repository, but
if that
>>>>>> is not desirable, I think this is the way to patch it:
>>>>>>
>>>>>> Makefile.am:
>>>>>>
>>>>>> - SUBDIRS = src man test
>>>>>> + SUBDIRS = src man test doc
>>>>>> - EXTRA_DIST = extra doc Doxyfile aminclude.am
<http://aminclude.am> acinclude.m4
>>>>>> + EXTRA_DIST = extra Doxyfile aminclude.am
<http://aminclude.am> acinclude.m4
>>>>>>
>>>>>> configure.ac <http://configure.ac>:
>>>>>>
>>>>>> AC_CONFIG_FILES([Makefile
>>>>>> + doc/Makefile
>>>>>> src/Makefile
>>>>>> man/Makefile
>>>>>> test/Makefile])
>>>>>>
>>>>>> and then create doc/Makefile.am:
>>>>>>
>>>>>> EXTRA_DIST = coding_style.txt doxygen-main.h
>>>>> The second solution sounds good. I will make the changes ASAP.
>>>>>
>>>>> Regards,
>>>>> --
>>>>> Seb
>>>>>
>>
>