From: Ivan Vergiliev [mailto:email@example.com]
Sent: Donnerstag, 29. November 2012 16:05
To: Emil Ivov
Cc: firstname.lastname@example.org; Yana Stamcheva
Subject: [jitsi-dev] Re: [PATCH] Support message correction for messages with
smilies and newlines
I'm attaching a patch that fixes the issue for me. It's fairly trivial, we
just didn't escape all the HTML characters.
On Wed, Nov 28, 2012 at 8:07 PM, Ivan Vergiliev > <email@example.com> wrote:
Thanks for the nice bug report, I'll try to reproduce and fix this.
It was already on my todo-list, but it's been kinda full lately.
On Wed, Nov 28, 2012 at 7:58 PM, Emil Ivov <firstname.lastname@example.org> wrote:
Hey Ivan, Yana,
I think we introduced an issue with this one. I am occasionally seeing
html tags for my outgoing messages, especially when copying content
from a web page. Part of the text also seems duplicated.
Here's one example example, I wrote the following:
Here's one ref www.google.com/ipv6/statistics.html
And after sending it, appeared as:
statistics.html</A><PLAINTEXT>' style="color:#8e8e8e">Here's one ref
The remote party got it in the latter, scrambled form.
Note that the link "www.google.com/ipv6/statistics.html" was
text that I
copied from a web page so it probably went into the clipboard
formatting that was eventually transferred into Jitsi.
Do you think you could have a look?
On 19.11.12, 12:17, Yana Stamcheva wrote: > Hi Ivan, > > On Nov
14, 2012, at 1:21 AM, Ivan Vergiliev <email@example.com> wrote:
> >> Hey devs, Yana, >> >> I've attached a small patch to add
support for proper editing of messages with smilies and newline
characters, and a couple of small refactorings. It's implemented as we
discussed off-list - by saving the original message as an attribute to
the div tag and then simply retrieving it. >> >> It also fixes the
positioning of the cursor when editing a message - now it's displayed
after the last character. >> >> Sorry for the huge delay, but I kept
finding some small but annoying and hard to fix bugs. >> >> I hope
most things work fine now. > > The patch works perfectly for me and
I've just committed it in revision 10068. Thanks for the hard work!! >
> It's also ack-ed on our Team&Contributors page. > > Cheers, >
Yana > >> >> Cheers, >> Ivan >> <smilies.patch> > >