[jitsi-dev] [PATCH] Support for Chromium as well as Chrome during Linux Browser Opening


#1

Had this little change on a github pull request before I realised that wasn't your usual methodology. It's useful for those of us who use Chromium instead of chrome, as the executable's name is different. It's trivial, but in case it's really necessary I sent bluejimp/emil the contrib agreement.

···

---
.../java/sip/communicator/impl/browserlauncher/BrowserLauncherImpl.java | 1 +
1 file changed, 1 insertion(+)

diff --git a/src/net/java/sip/communicator/impl/browserlauncher/BrowserLauncherImpl.java b/src/net/java/sip/communicator/impl/browserlauncher/BrowserLauncherImpl.java
index c4ad992..0a0912d 100644
--- a/src/net/java/sip/communicator/impl/browserlauncher/BrowserLauncherImpl.java
+++ b/src/net/java/sip/communicator/impl/browserlauncher/BrowserLauncherImpl.java
@@ -60,6 +60,7 @@ else if (OSUtils.IS_WINDOWS)
                 = new String[]
                         {
                             "google-chrome",
+ "chromium-browser",
                             "firefox",
                             "iceweasel",
                             "opera",
--
1.8.4


#2

1. You intended this for Linux (Subject line of your email) but the code
says Windows (if (OSUtils.IS_WINDOWS)).
2. Why not just use xdg-open on Linux?

Regards,
Philipp

···

On Fri, 25 Oct 2013 10:22:31 -0500 Toby Pinder <Toby.Pinder@smithelectric.com> wrote:

Had this little change on a github pull request before I realised
that wasn't your usual methodology. It's useful for those of us who
use Chromium instead of chrome, as the executable's name is
different. It's trivial, but in case it's really necessary I sent
bluejimp/emil the contrib agreement.

---
.../java/sip/communicator/impl/browserlauncher/BrowserLauncherImpl.java
> 1 + 1 file changed, 1 insertion(+)

diff --git
a/src/net/java/sip/communicator/impl/browserlauncher/BrowserLauncherImpl.java
b/src/net/java/sip/communicator/impl/browserlauncher/BrowserLauncherImpl.java
index c4ad992..0a0912d 100644 ---
a/src/net/java/sip/communicator/impl/browserlauncher/BrowserLauncherImpl.java
+++
b/src/net/java/sip/communicator/impl/browserlauncher/BrowserLauncherImpl.java
@@ -60,6 +60,7 @@ else if (OSUtils.IS_WINDOWS) = new String[]
{ "google-chrome",
+ "chromium-browser",
                             "firefox",
                             "iceweasel",
                             "opera",


#3

My mistake, I was unclear on this.

···

-----Original Message-----
From: dev-bounces@jitsi.org [mailto:dev-bounces@jitsi.org] On Behalf Of Philipp Überbacher
Sent: 26 October 2013 10:25
To: dev@jitsi.org
Subject: Re: [jitsi-dev] [PATCH] Support for Chromium as well as Chrome during Linux Browser Opening

On Fri, 25 Oct 2013 10:22:31 -0500 Toby Pinder <Toby.Pinder@smithelectric.com> wrote:

Had this little change on a github pull request before I realised that
wasn't your usual methodology. It's useful for those of us who use
Chromium instead of chrome, as the executable's name is different.
It's trivial, but in case it's really necessary I sent bluejimp/emil
the contrib agreement.

---

.../java/sip/communicator/impl/browserlauncher/BrowserLauncherImpl.jav
a
> 1 + 1 file changed, 1 insertion(+)

diff --git
a/src/net/java/sip/communicator/impl/browserlauncher/BrowserLauncherIm
pl.java
b/src/net/java/sip/communicator/impl/browserlauncher/BrowserLauncherIm
pl.java
index c4ad992..0a0912d 100644 ---
a/src/net/java/sip/communicator/impl/browserlauncher/BrowserLauncherIm
pl.java
+++
b/src/net/java/sip/communicator/impl/browserlauncher/BrowserLauncherIm
pl.java @@ -60,6 +60,7 @@ else if (OSUtils.IS_WINDOWS) = new String[]
{ "google-chrome",
+ "chromium-browser",
                             "firefox",
                             "iceweasel",
                             "opera",

1. You intended this for Linux (Subject line of your email) but the code says Windows (if (OSUtils.IS_WINDOWS)).
2. Why not just use xdg-open on Linux?

Regards,
Philipp

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#4

Hello,

···

On 10/26/13 11:24 AM, Philipp �berbacher wrote:

On Fri, 25 Oct 2013 10:22:31 -0500 > Toby Pinder <Toby.Pinder@smithelectric.com> wrote:

Had this little change on a github pull request before I realised
that wasn't your usual methodology. It's useful for those of us who
use Chromium instead of chrome, as the executable's name is
different. It's trivial, but in case it's really necessary I sent
bluejimp/emil the contrib agreement.

---
.../java/sip/communicator/impl/browserlauncher/BrowserLauncherImpl.java
> 1 + 1 file changed, 1 insertion(+)

diff --git
a/src/net/java/sip/communicator/impl/browserlauncher/BrowserLauncherImpl.java
b/src/net/java/sip/communicator/impl/browserlauncher/BrowserLauncherImpl.java
index c4ad992..0a0912d 100644 ---
a/src/net/java/sip/communicator/impl/browserlauncher/BrowserLauncherImpl.java
+++
b/src/net/java/sip/communicator/impl/browserlauncher/BrowserLauncherImpl.java
@@ -60,6 +60,7 @@ else if (OSUtils.IS_WINDOWS) = new String[]
{ "google-chrome",
+ "chromium-browser",
                             "firefox",
                             "iceweasel",
                             "opera",

1. You intended this for Linux (Subject line of your email) but the code
says Windows (if (OSUtils.IS_WINDOWS)).

Actually the line is properly inserted in the final "else" clause, after
"else if (OSUtils.IS_WINDOWS)".

I've just committed this and added an acknowledgement on the
contributors page, sorry for the huge delay.

Regards,
Boris