[jitsi-dev] [PATCH] service.gui.NO_ONLINE_CONFERENCING_ACCOUNT is missing


#1

Hi,

This patch adds a missing language property, service.gui.NO_ONLINE_CONFERENCING_ACCOUNT, to resources.properties.

This property is used when the user selects the Tools > Create a conference call… option without having previously added an account which
supports conferencing. It's usage is specified in src.net.java.sip.communicator.impl.gui.main.menus.ToolsMenu.actionPerformed.

To repro the problem, simply wipe out the current jitsi account data, load Jitsi and click Tools -> Create a conference call… option. The user is then presented with an alert with the text saying 'null'.

The attached patch file was created using git diff > file.patch - if pull requests are easier now that Jitsi has moved to github, I can do that in the future.

Thanks,

Richard Whitehouse

richardwhiuk.conference.patch (1.08 KB)


#2

This patch adds a missing language property,
service.gui.NO_ONLINE_CONFERENCING_ACCOUNT, to resources.properties.

Thanks! I've added the missing resource.

The attached patch file was created using git diff > file.patch - if pull
requests are easier now that Jitsi has moved to github, I can do that in

the

future.

I'd be fine with pull requests.
Emil?

Thanks,
Richard Whitehouse

Ingo


#3

Sure. I'd just need Richard to scan and send me a signed copy of the BCA:

http://bluejimp.com/bca

Thanks for contributing, Richard!

Emil

···

On 02.05.13, 23:06, Ingo Bauersachs wrote:

This patch adds a missing language property,
service.gui.NO_ONLINE_CONFERENCING_ACCOUNT, to resources.properties.

Thanks! I've added the missing resource.

The attached patch file was created using git diff > file.patch - if pull
requests are easier now that Jitsi has moved to github, I can do that in

the

future.

I'd be fine with pull requests.
Emil?

--
https://jitsi.org