[jitsi-dev] [PATCH] Search bar tab issue


#1

Hello,

The contact list search bar seems eat Tab button key strokes and thus
prevents changing focus to an other control without using the mouse.

For instance in the "Invite contacts to call" dialog this is what I want
to be able to do:
1) Press 'a' (or some other character making a search)
2) Go down and mark a contact by pressing Arrow down
3) Press Tab to change focus to the "Add" button
4) Press Enter to have the contacts added

What is happening at 3) is that the Tab key does not switch focus to the
Add button but instead stays in the search bar making it impossible (?)
to only use the keyboard.

The problem seems to be that pressing the Tab key produces two key
events, one with key code VK_TAB and one with 0. The first is ignored by
ContactListSearchKeyDispatcher (as it should) but the one with 0 is
handled as an input to the search bar.

The attached patch intends to solve this by having the
ContactListSearchKeyDispatcher look at the key char and ignore the event
if it is for a Tab.

Best regards,
Markus

searchbar-tab-issue-patch1.txt (715 Bytes)


#2

Thanks Markus and sorry for the delay.
I applied and acked your contribution in r10343

Regards,
Ingo

···

-----Original Message-----
From: Markus Kilås [mailto:subjunctive.post@gmail.com]
Sent: Sonntag, 30. Dezember 2012 17:49
To: dev@jitsi.java.net
Subject: [jitsi-dev] [PATCH] Search bar tab issue
Hello,

The contact list search bar seems eat Tab button key strokes and thus
prevents changing focus to an other control without using the mouse.

For instance in the "Invite contacts to call" dialog this is what I want
to be able to do:
1) Press 'a' (or some other character making a search)
2) Go down and mark a contact by pressing Arrow down
3) Press Tab to change focus to the "Add" button
4) Press Enter to have the contacts added

What is happening at 3) is that the Tab key does not switch focus to the
Add button but instead stays in the search bar making it impossible (?)
to only use the keyboard.

The problem seems to be that pressing the Tab key produces two key
events, one with key code VK_TAB and one with 0. The first is ignored by
ContactListSearchKeyDispatcher (as it should) but the one with 0 is
handled as an input to the search bar.

The attached patch intends to solve this by having the
ContactListSearchKeyDispatcher look at the key char and ignore the event
if it is for a Tab.

Best regards,
Markus