[jitsi-dev] [PATCH] reconnectplugin bug ticket #1118


#1

Hi Guys!****

According to bug ticket #1118, Jitsi can not restore the status "on-line"
during network problems in several cases.****

It looks that the current XMPP account / provider hangs in the state
“REGISTERING”.****

In these cases, the provider’s icon is in the permanent rotation animation,
but nothing happens. The status won't be restored to online after an hour
or even after a day.****

The reconnect plugin does nothing, because the reconnection task of the
plugin is completed without any fails.

Our patch will produce a double check and will do the following:****

- Creation a new timer task for the confirmation of reconnection, which
will be created in the time of initialization of the standard reconnection
timer task.****

- After the “confirmation timeout” this task will check the provider’s
state.****

- If the provider is not still reconnected (in REGISTERED state), the
confirmation task will produce the unregister procedure. Then it will
initiate a reconnection from the scratch.****

- If the provider is successfully reconnects, the confirmation task will
end.****

** **

Also it adds two new options in the account connection settings, which are:*

ReconnectDelays.patch (35.8 KB)

···

***

- The maximum time delay of the reconnection. This option allows user to
change it manually. Currently it’s hardcoded for 300 seconds in the
reconnect plugin source code.****

- The Reconnect confirmation delay. Allows user to specify delay of the
reconnection confirmation.****

** **

Additionally:****

- Fixed the "null" error notification in the extended account registration
form.****

Currently, when the user attempts to create a new jabber account from the
"advanced" window, he gets a "null" error notification without any
description. This exception is catched and handled more accurately.
Desctiption of this exception is defined by string
“plugin.jabberaccregwizz.WRONG_CREATION_FORM=Failed to create a new account
via registration wizard. Please, use the simple form for this purpose.”

** **

All GUI strings has an English and Russian translations.

Best regards,
Semyon Baranov
mobile: +7 925 369 9878
skype: silex89
icq: 431469408


#2

Hi!

Is there any problems with this patch?
It fixes the bug, posted in issue tracker.

Thank You

···

---

From: Semen Baranov [mailto:sfbaranov@gmail.com]
Sent: Saturday, September 21, 2013 12:23 AM
To: dev@jitsi.org
Subject: [PATCH] reconnectplugin bug ticket #1118

Hi Guys!
According to bug ticket #1118, Jitsi can not restore the status "on-line"
during network problems in several cases.
It looks that the current XMPP account / provider hangs in the state
"REGISTERING".
In these cases, the provider's icon is in the permanent rotation animation,
but nothing happens. The status won't be restored to online after an hour or
even after a day.
The reconnect plugin does nothing, because the reconnection task of the
plugin is completed without any fails.

Our patch will produce a double check and will do the following:
- Creation a new timer task for the confirmation of reconnection, which will
be created in the time of initialization of the standard reconnection timer
task.
- After the "confirmation timeout" this task will check the provider's
state.
- If the provider is not still reconnected (in REGISTERED state), the
confirmation task will produce the unregister procedure. Then it will
initiate a reconnection from the scratch.
- If the provider is successfully reconnects, the confirmation task will
end.

Also it adds two new options in the account connection settings, which are:
- The maximum time delay of the reconnection. This option allows user to
change it manually. Currently it's hardcoded for 300 seconds in the
reconnect plugin source code.
- The Reconnect confirmation delay. Allows user to specify delay of the
reconnection confirmation.

Additionally:
- Fixed the "null" error notification in the extended account registration
form.
Currently, when the user attempts to create a new jabber account from the
"advanced" window, he gets a "null" error notification without any
description. This exception is catched and handled more accurately.
Desctiption of this exception is defined by string
"plugin.jabberaccregwizz.WRONG_CREATION_FORM=Failed to create a new account
via registration wizard. Please, use the simple form for this purpose."

All GUI strings has an English and Russian translations.

Best regards,
Semyon Baranov
mobile: +7 925 369 9878
skype: silex89
icq: 431469408


#3

Hi,

the reconnect plugin is delicate place cause we had a lot of problems and a
lot of tests and fixes and for a long time it is working fine.
I cannot find where the issue 1118 was discussed. Cause currently the issue
says that changing network does not reconnect, but I do not think this is
the case, cause seems working fine right now.
Can you explain in more detail when the problem occurs? Or give an easy
steps to reproduce.

Regards
Damian

···

On Thu, Sep 26, 2013 at 8:22 PM, Dmitry.Integral <dmitry.integral@gmail.com>wrote:

Hi!

Is there any problems with this patch?
It fixes the bug, posted in issue tracker.

Thank You

---

From: Semen Baranov [mailto:sfbaranov@gmail.com]
Sent: Saturday, September 21, 2013 12:23 AM
To: dev@jitsi.org
Subject: [PATCH] reconnectplugin bug ticket #1118

Hi Guys!
According to bug ticket #1118, Jitsi can not restore the status "on-line"
during network problems in several cases.
It looks that the current XMPP account / provider hangs in the state
"REGISTERING".
In these cases, the provider's icon is in the permanent rotation animation,
but nothing happens. The status won't be restored to online after an hour
or
even after a day.
The reconnect plugin does nothing, because the reconnection task of the
plugin is completed without any fails.

Our patch will produce a double check and will do the following:
- Creation a new timer task for the confirmation of reconnection, which
will
be created in the time of initialization of the standard reconnection timer
task.
- After the "confirmation timeout" this task will check the provider's
state.
- If the provider is not still reconnected (in REGISTERED state), the
confirmation task will produce the unregister procedure. Then it will
initiate a reconnection from the scratch.
- If the provider is successfully reconnects, the confirmation task will
end.

Also it adds two new options in the account connection settings, which are:
- The maximum time delay of the reconnection. This option allows user to
change it manually. Currently it's hardcoded for 300 seconds in the
reconnect plugin source code.
- The Reconnect confirmation delay. Allows user to specify delay of the
reconnection confirmation.

Additionally:
- Fixed the "null" error notification in the extended account registration
form.
Currently, when the user attempts to create a new jabber account from the
"advanced" window, he gets a "null" error notification without any
description. This exception is catched and handled more accurately.
Desctiption of this exception is defined by string
"plugin.jabberaccregwizz.WRONG_CREATION_FORM=Failed to create a new account
via registration wizard. Please, use the simple form for this purpose."

All GUI strings has an English and Russian translations.

Best regards,
Semyon Baranov
mobile: +7 925 369 9878
skype: silex89
icq: 431469408

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev