[jitsi-dev] [PATCH] Prefer GTK+ over Metal in XFCE, too


#1

Hello everyone!

The issue I ran into is that in my Linux XFCE Sun java 6 environment
Jitsi (both 2.2 and Git HEAD) start up using the Java metal theme,
despite the availability of the GTK+ look and feel.

From a look at the code my impression is that the responsible developer

thought of KDE but not of GTK-based environments. The attached patch
against Git HEAD works well for me, please consider application.

Best,

Sebastian

0001-Prefer-GTK-over-Metal-in-non-KDE-Linux-BSD-environme.patch (1.34 KB)


#2

Any comments? Shall I turn this into a Trac ticket?

Sebastian

···

On 24.06.2013 16:12, Sebastian Pipping wrote:

The issue I ran into is that in my Linux XFCE Sun java 6 environment
Jitsi (both 2.2 and Git HEAD) start up using the Java metal theme,
despite the availability of the GTK+ look and feel.

From a look at the code my impression is that the responsible developer
thought of KDE but not of GTK-based environments. The attached patch
against Git HEAD works well for me, please consider application.


#3

Thanks for sending this. You don't need to open a ticket however, it
seems to me that you are simply removing a check rather than extending
it to also cover your case. Was that a deliberate choice or did you
just look for the first thing that worked in your case?

Emil

···

On Wed, Jun 26, 2013 at 11:41 PM, Sebastian Pipping <sebastian@pipping.org> wrote:

On 24.06.2013 16:12, Sebastian Pipping wrote:

The issue I ran into is that in my Linux XFCE Sun java 6 environment
Jitsi (both 2.2 and Git HEAD) start up using the Java metal theme,
despite the availability of the GTK+ look and feel.

From a look at the code my impression is that the responsible developer
thought of KDE but not of GTK-based environments. The attached patch
against Git HEAD works well for me, please consider application.

Any comments? Shall I turn this into a Trac ticket?

Sebastian

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
https://jitsi.org FAX: +33.1.77.62.47.31


#4

Hello Emil,

nice to meet you!

Thanks for sending this. You don't need to open a ticket however, it
seems to me that you are simply removing a check rather than extending
it to also cover your case. Was that a deliberate choice or did you
just look for the first thing that worked in your case?

Deliberate. Commit 88f649f52ff7647b8a2932cb4beeb5a5c395e4c7 [1]
introduced GTK+ look and feel but restricted it to KDE at the same time.
If KDE users want GTK+ look, why would Gnome or XFCE users prefer
Metal? :slight_smile:

Best,

Sebastian

[1]
https://github.com/jitsi/jitsi/commit/88f649f52ff7647b8a2932cb4beeb5a5c395e4c7

···

On 26.06.2013 23:44, Emil Ivov wrote:


#5

Any news?

···

On 27.06.2013 01:14, Sebastian Pipping wrote:

Deliberate. Commit 88f649f52ff7647b8a2932cb4beeb5a5c395e4c7 [1]
introduced GTK+ look and feel but restricted it to KDE at the same time.
If KDE users want GTK+ look, why would Gnome or XFCE users prefer
Metal? :slight_smile:

[..]

[1]
https://github.com/jitsi/jitsi/commit/88f649f52ff7647b8a2932cb4beeb5a5c395e4c7

Thanks,

Sebastian


#6

Deliberate. Commit 88f649f52ff7647b8a2932cb4beeb5a5c395e4c7 [1]
introduced GTK+ look and feel but restricted it to KDE at the same time.
If KDE users want GTK+ look, why would Gnome or XFCE users prefer
Metal? :slight_smile:

[..]

[1]

https://github.com/jitsi/jitsi/commit/88f649f52ff7647b8a2932cb4beeb5a5c39
5e4c 7

I don't see a reason not to try this in the nightlies and revert it if we
receive complaints. It might even help with some other issues that appear
once in a while (the visible frame stuff for example).

Emil?

Thanks,
Sebastian

Ingo

···

On 27.06.2013 01:14, Sebastian Pipping wrote: