[jitsi-dev] [PATCH] Please allow empty messages without reporting an error


#1

Hi,

Please allow empty messages without reporting an error.

IRC sometimes sends empty lines, so I don't think it would be good if
this normal behavior would be reported as an error in popup
notifications. I'd like to modify the behavior as follows:
1. only show popup notification on non-null non-empty message
2. log error if message is null.
3. do nothing if message is empty.

Diff attached with suggested modification.

Kind regards,
Danny

allow-empty-message.diff (1010 Bytes)


#2

Committed.

From: dev-bounces@jitsi.org [mailto:dev-bounces@jitsi.org] On Behalf Of

Danny

van Heumen
Sent: Mittwoch, 19. März 2014 00:05
To: Jitsi Developers
Subject: [jitsi-dev] [PATCH] Please allow empty messages without reporting

an

···

-----Original Message-----
error
Hi,

Please allow empty messages without reporting an error.

IRC sometimes sends empty lines, so I don't think it would be good if
this normal behavior would be reported as an error in popup
notifications. I'd like to modify the behavior as follows:
1. only show popup notification on non-null non-empty message
2. log error if message is null.
3. do nothing if message is empty.

Diff attached with suggested modification.

Kind regards,
Danny