I've just committed and acked your patch on our team and contribution
page. Thanks for your work.
I just made some minor changes in your patch:
- there was an exception:
[java] java.lang.ClassCastException: java.lang.Long cannot be
cast to java.lang.Integer
[java] at java.lang.Integer.compareTo(Integer.java:37)
[java] at javax.swing.JSpinner.fireStateChanged(JSpinner.java:434)
[java] at javax.swing.JSpinner.setValue(JSpinner.java:329)
As the value was a delay and is supposed to be a not so long I made it int.
- In the config panel there was a java 1.6 only class
javax.swing.GroupLayout I removed it and made the form look like the
other advance config forms, check it out
- Little modifications on the code style there were a lot of packages
in the code like javax.swing.JLabel (not in the imports), maybe its
your ide that insert them but we prefer to simplify the code for easy
reading and avoid this. Also there were some code over the 80 column.
Most of these was only in the class DnsConfigPanel and also the
implements/extends and throw clauses in the class and method
- Some string improvementс.
- And I move setting the resolver to the lookup into the synchronized
block (as it was) to avoid using the resolver during resetting it,
this happens mostly when network has change its connected state.