Thanks for reviewing the changes!
I added the following tooltips:
- Your buddy has ended your private conversation. You should do the same -
For 'finished' session - the one with the red sign
- Your private conversation is not verified. Please authenticate your buddy
- For 'encrypted unverified' session - the one with the exclamation mark
- Your private conversation is verified - For 'enrypted verified' session -
the one with the green sign
In case you want to further modify them you should look for the
plugin.otr.menu.UNVERIFIED properties in
otr new icons.patch (45.1 KB)
On Fri, Nov 22, 2013 at 1:02 PM, Yana Stamcheva <email@example.com> wrote:
On 22 Nov 2013, at 09:42, Marin Dzhigarov <firstname.lastname@example.org> wrote:
> I'm sending you a patch that fixes the issue with the otr "locked
padlock" looking almost like the "unlocked" one.
> The patch also fixes a memory leak that I found with
OtrMetaContactButton not being disposed thus living forever and not
releasing any resources.
> Please review the patch and if you have any comments please post them
Thanks! I'm about to commit the patch and I wonder if you could also
change the tooltip of the padlock button, so that it matches the current
state. This way it would be more clear what is the meaning of the
exclamation mark and the red sign. What do you think?
> Thank you for your time!
> dev mailing list
> Unsubscribe instructions and other list options:
dev mailing list
Unsubscribe instructions and other list options: