[jitsi-dev] [PATCH] OTR for SIP


#1

Hello,

I was working on enabling OTR for SIP.

I'm sending you a patch for a review. Any comments will be appreciated.

Thanks in advance!

Regards,
Marin

otr-for-sip.patch (3.76 KB)


#2

Hello,

···

On 8/19/13 12:59 PM, Marin Dzhigarov wrote:

Hello,

I was working on enabling OTR for SIP.

I'm sending you a patch for a review. Any comments will be appreciated.

Looks good to me. Tiny remarks:

1. I think you should add yourself as an author in
OperationSetBasicInstantMessagingSipImpl.java

2. Some trailing whitespace added:
otr-for-sip.patch:58: trailing whitespace.
     *
otr-for-sip.patch:61: trailing whitespace.
     *
otr-for-sip.patch:68: trailing whitespace.

otr-for-sip.patch:77: trailing whitespace.

otr-for-sip.patch:85: trailing whitespace.

Regards,
Boris


#3

Committed and acked on the contributors page.

Regards,
Boris

···

On 8/19/13 12:59 PM, Marin Dzhigarov wrote:

Hello,

I was working on enabling OTR for SIP.

I'm sending you a patch for a review. Any comments will be appreciated.

Thanks in advance!

Regards,
Marin