[jitsi-dev] [PATCH] MUCService.isPrivate return values swapped

#1

Hi all,

I believe some return values might be swapped, but as always, correct me
if I'm wrong. CC'ed Hristo, I believe he might be familiar with this due
to the recent MUC UI changes.

I am loading a chatroom with 1 user (other than myself) and it shows up
without a contact list. Tracing through the code I reach a method
'ConferenceChatSession: boolean isContactListSupported()'. I believe
this is the point where is being determined whether or not to show this
column with chat room members.

MUCService.isPrivate(chatroom) is used to determine whether or not the
chatroom is "private".
The current implementation of this claims that:
- if there is one chat room member and the local user is it, then it is
not a private room,
- while if there's one user and it's someone else, the room is private.

So ... the return values are swapped(?)

Patch included.

Kind regards,
Danny

isPrivate-results-swapped.diff (683 Bytes)

#2
···

Hi,

  Did someone have a look at this modification?

  It seems fairly trivial, unless I misunderstood its intention.

  Thanks,

  Danny

  On 03/09/2014 10:35 PM, Danny van Heumen wrote:


Hi all,
I believe some return values might be swapped, but as always, correct me
if I'm wrong. CC'ed Hristo, I believe he might be familiar with this due
to the recent MUC UI changes.
I am loading a chatroom with 1 user (other than myself) and it shows up
without a contact list. Tracing through the code I reach a method
'ConferenceChatSession: boolean isContactListSupported()'. I believe
this is the point where is being determined whether or not to show this
column with chat room members.
MUCService.isPrivate(chatroom) is used to determine whether or not the
chatroom is "private".
The current implementation of this claims that:
- if there is one chat room member and the local user is it, then it is
not a private room,
- while if there's one user and it's someone else, the room is private.
So ... the return values are swapped(?)
Patch included.
Kind regards,
Danny


_______________________________________________
dev mailing list
Unsubscribe instructions and other list options:

dev@jitsi.orghttp://lists.jitsi.org/mailman/listinfo/dev

#3
···

Innocent reminder …

  I'm pretty sure that this particular patch wasn't committed yet.

(Another one got committed a few weeks ago, after the first
reminder.)

  On 03/09/2014 10:35 PM, Danny van Heumen wrote:


Hi all,
I believe some return values might be swapped, but as always, correct me
if I'm wrong. CC'ed Hristo, I believe he might be familiar with this due
to the recent MUC UI changes.
I am loading a chatroom with 1 user (other than myself) and it shows up
without a contact list. Tracing through the code I reach a method
'ConferenceChatSession: boolean isContactListSupported()'. I believe
this is the point where is being determined whether or not to show this
column with chat room members.
MUCService.isPrivate(chatroom) is used to determine whether or not the
chatroom is "private".
The current implementation of this claims that:
- if there is one chat room member and the local user is it, then it is
not a private room,
- while if there's one user and it's someone else, the room is private.
So ... the return values are swapped(?)
Patch included.
Kind regards,
Danny


_______________________________________________
dev mailing list
Unsubscribe instructions and other list options:

dev@jitsi.orghttp://lists.jitsi.org/mailman/listinfo/dev

#4

Sorry Danny, I currently have too much stuff around in the office to do non-office related work on Jitsi, but I hope I can take a look at it this weekend.

Freundliche Grüsse,
Ingo Bauersachs

-- Sent from my tablet

···

On 19.03.2014, at 21:47, "Danny van Heumen" <danny@dannyvanheumen.nl> wrote:

Hi,

Did someone have a look at this modification?
It seems fairly trivial, unless I misunderstood its intention.

Thanks,
Danny

On 03/09/2014 10:35 PM, Danny van Heumen wrote:
Hi all,

I believe some return values might be swapped, but as always, correct me
if I'm wrong. CC'ed Hristo, I believe he might be familiar with this due
to the recent MUC UI changes.

I am loading a chatroom with 1 user (other than myself) and it shows up
without a contact list. Tracing through the code I reach a method
'ConferenceChatSession: boolean isContactListSupported()'. I believe
this is the point where is being determined whether or not to show this
column with chat room members.

MUCService.isPrivate(chatroom) is used to determine whether or not the
chatroom is "private".
The current implementation of this claims that:
- if there is one chat room member and the local user is it, then it is
not a private room,
- while if there's one user and it's someone else, the room is private.

So ... the return values are swapped(?)

Patch included.

Kind regards,
Danny

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

#5

I thought Hristo might take care of it as it's in the chat room stuff. Could
you please create a pull request that I can merge? My local devenv is messed
up so patching would be more complicated right now.

Ingo

From: dev-bounces@jitsi.org [mailto:dev-bounces@jitsi.org] On Behalf Of

Danny

van Heumen
Sent: Sonntag, 13. April 2014 22:02
To: dev@jitsi.org
Subject: Re: [jitsi-dev] [PATCH] MUCService.isPrivate return values

swapped

Innocent reminder ...
I'm pretty sure that this particular patch wasn't committed yet. (Another

one

got committed a few weeks ago, after the first reminder.)

  Hi all,

  I believe some return values might be swapped, but as always,

correct

me if I'm wrong. CC'ed Hristo, I believe he might be familiar with this
due to the recent MUC UI changes.

  I am loading a chatroom with 1 user (other than myself) and it shows

up

  without a contact list. Tracing through the code I reach a method
  'ConferenceChatSession: boolean isContactListSupported()'. I believe
  this is the point where is being determined whether or not to show

this

  column with chat room members.

  MUCService.isPrivate(chatroom) is used to determine whether or not

the

  chatroom is "private". The current implementation of this claims

that:

  - if there is one chat room member and the local user is it, then it

is

  not a private room, - while if there's one user and it's someone

else,

the room is private.

  So ... the return values are swapped(?)

  Patch included.

  Kind regards,
  Danny

  _______________________________________________ dev mailing

list

···

-----Original Message-----
On 03/09/2014 10:35 PM, Danny van Heumen wrote:
  dev@jitsi.org <mailto:dev@jitsi.org> Unsubscribe instructions and
other list options: http://lists.jitsi.org/mailman/listinfo/dev

#6
···

Ah right, no prob. I just didn’t want
the message to go off the radar.

  Thanks,

  Danny

  On 03/19/2014 11:47 PM, Ingo Bauersachs wrote:

    Sorry Danny, I currently have too much stuff around in the

office to do non-office related work on Jitsi, but I hope I can
take a look at it this weekend.

Freundliche Grüsse,

Ingo Bauersachs

– Sent from my tablet

    On 19.03.2014, at 21:47, "Danny van Heumen" <danny@dannyvanheumen.nl        >

wrote:

      dev mailing list

      dev@jitsi.org

      Unsubscribe instructions and other list options:

      [http://lists.jitsi.org/mailman/listinfo/dev](http://lists.jitsi.org/mailman/listinfo/dev)


_______________________________________________
dev mailing list
Unsubscribe instructions and other list options:

Hi,

        Did someone have a look at this modification?

        It seems fairly trivial, unless I misunderstood its

intention.

        Thanks,

        Danny

        On 03/09/2014 10:35 PM, Danny van Heumen wrote:


Hi all,
I believe some return values might be swapped, but as always, correct me
if I'm wrong. CC'ed Hristo, I believe he might be familiar with this due
to the recent MUC UI changes.
I am loading a chatroom with 1 user (other than myself) and it shows up
without a contact list. Tracing through the code I reach a method
'ConferenceChatSession: boolean isContactListSupported()'. I believe
this is the point where is being determined whether or not to show this
column with chat room members.
MUCService.isPrivate(chatroom) is used to determine whether or not the
chatroom is "private".
The current implementation of this claims that:
- if there is one chat room member and the local user is it, then it is
not a private room,
- while if there's one user and it's someone else, the room is private.
So ... the return values are swapped(?)
Patch included.
Kind regards,
Danny


_______________________________________________
dev mailing list
Unsubscribe instructions and other list options:

dev@jitsi.orghttp://lists.jitsi.org/mailman/listinfo/dev
dev@jitsi.orghttp://lists.jitsi.org/mailman/listinfo/dev

#7

Pull-request created.

···

On 04/13/2014 10:10 PM, Ingo Bauersachs wrote:

I thought Hristo might take care of it as it's in the chat room stuff. Could
you please create a pull request that I can merge? My local devenv is messed
up so patching would be more complicated right now.

Ingo

-----Original Message-----
From: dev-bounces@jitsi.org [mailto:dev-bounces@jitsi.org] On Behalf Of

Danny

van Heumen
Sent: Sonntag, 13. April 2014 22:02
To: dev@jitsi.org
Subject: Re: [jitsi-dev] [PATCH] MUCService.isPrivate return values

swapped

Innocent reminder ...
I'm pretty sure that this particular patch wasn't committed yet. (Another

one

got committed a few weeks ago, after the first reminder.)

On 03/09/2014 10:35 PM, Danny van Heumen wrote:

  Hi all,

  I believe some return values might be swapped, but as always,

correct

me if I'm wrong. CC'ed Hristo, I believe he might be familiar with this
due to the recent MUC UI changes.

  I am loading a chatroom with 1 user (other than myself) and it shows

up

  without a contact list. Tracing through the code I reach a method
  'ConferenceChatSession: boolean isContactListSupported()'. I believe
  this is the point where is being determined whether or not to show

this

  column with chat room members.

  MUCService.isPrivate(chatroom) is used to determine whether or not

the

  chatroom is "private". The current implementation of this claims

that:

  - if there is one chat room member and the local user is it, then it

is

  not a private room, - while if there's one user and it's someone

else,

the room is private.

  So ... the return values are swapped(?)

  Patch included.

  Kind regards,
  Danny

  _______________________________________________ dev mailing

list

  dev@jitsi.org <mailto:dev@jitsi.org> Unsubscribe instructions and
other list options: http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev