[jitsi-dev] [PATCH] Message correction - don't show yellow background if contact does not support it


#1

Hey all, Yana,

This is just a small fix for what's in the subject - i.e. if the user
presses the UP arrow but the contact in the chat does not support message
correction, we still put the message to be corrected in the write area, but
don't display the yellow background so that it's clearer that this is a
resend and not an edit.

I also noticed some minor regressions probably due to the new interface
(which looks pretty nice, by the way - good job!), namely:
- the yellow background is not shown on already edited messages (this might
just as well be a resources problem on my side), and
- when editing a message for the second time, the message that's shown in
the write area is "old message (edited at ...)" instead of just "old
message".

I'll try to look into them as well.

Cheers,
Ivan

yellowBackground.diff (2.59 KB)


#2

Hi Ivan,

Hey all, Yana,

This is just a small fix for what's in the subject - i.e. if the user presses the UP arrow but the contact in the chat does not support message correction, we still put the message to be corrected in the write area, but don't display the yellow background so that it's clearer that this is a resend and not an edit.

Great! Thanks for taking care of this!

I'll try to apply it till the end of this week.

I also noticed some minor regressions probably due to the new interface (which looks pretty nice, by the way - good job!), namely:
- the yellow background is not shown on already edited messages (this might just as well be a resources problem on my side), and

Actually, we've decided to remove the yellow background from the conversation area and show edited messages in italic with the "edited at" text at the end.

- when editing a message for the second time, the message that's shown in the write area is "old message (edited at ...)" instead of just "old message".

Yep, I've noticed this one too. I'm currently preparing a commit that should resolve all these little problems and make the new chat theme more stable :slight_smile:

Thanks!
Yana

···

On Oct 1, 2012, at 11:55 PM, Ivan Vergiliev wrote:

I'll try to look into them as well.

Cheers,
Ivan
<yellowBackground.diff>


#3

Hi Ivan,

I've just committed your patch together with the fix of "edited at" appearing in the write area, when editing an already edited message, and some other fixes/improvements.

Something that is still a problem with message edition is the fact that smileys or image links would now disappear when we edit a message. I think this could be easily fixed by performing a "reverseProcessReplacements" before returning the message content in the ChatConversationPanel. I'm sharing my thoughts here in case you're interested in implementing this one :slight_smile:

Thanks again!
Yana

···

On Oct 2, 2012, at 12:11 AM, Yana Stamcheva <yana@jitsi.org> wrote:

Hi Ivan,

On Oct 1, 2012, at 11:55 PM, Ivan Vergiliev wrote:

Hey all, Yana,

This is just a small fix for what's in the subject - i.e. if the user presses the UP arrow but the contact in the chat does not support message correction, we still put the message to be corrected in the write area, but don't display the yellow background so that it's clearer that this is a resend and not an edit.

Great! Thanks for taking care of this!

I'll try to apply it till the end of this week.

I also noticed some minor regressions probably due to the new interface (which looks pretty nice, by the way - good job!), namely:
- the yellow background is not shown on already edited messages (this might just as well be a resources problem on my side), and

Actually, we've decided to remove the yellow background from the conversation area and show edited messages in italic with the "edited at" text at the end.

- when editing a message for the second time, the message that's shown in the write area is "old message (edited at ...)" instead of just "old message".

Yep, I've noticed this one too. I'm currently preparing a commit that should resolve all these little problems and make the new chat theme more stable :slight_smile:

Thanks!
Yana

I'll try to look into them as well.

Cheers,
Ivan
<yellowBackground.diff>


#4

Hi Yana,

Thanks for integrating and the rest of the bug fixes!

I had similar thoughts a while ago when I took a shot at that bug, but I
think I bumped into some Java peculiarities so I stopped. Anyway, I'll try
to look at it again in the next few days.

Ivan

···

On Wed, Oct 10, 2012 at 5:41 PM, Yana Stamcheva <yana@jitsi.org> wrote:

Hi Ivan,

I've just committed your patch together with the fix of "edited at"
appearing in the write area, when editing an already edited message, and
some other fixes/improvements.

Something that is still a problem with message edition is the fact that
smileys or image links would now disappear when we edit a message. I think
this could be easily fixed by performing a "reverseProcessReplacements"
before returning the message content in the ChatConversationPanel. I'm
sharing my thoughts here in case you're interested in implementing this one
:slight_smile:

Thanks again!
Yana

On Oct 2, 2012, at 12:11 AM, Yana Stamcheva <yana@jitsi.org> wrote:

> Hi Ivan,
>
> On Oct 1, 2012, at 11:55 PM, Ivan Vergiliev wrote:
>
>> Hey all, Yana,
>>
>> This is just a small fix for what's in the subject - i.e. if the user
presses the UP arrow but the contact in the chat does not support message
correction, we still put the message to be corrected in the write area, but
don't display the yellow background so that it's clearer that this is a
resend and not an edit.
>
> Great! Thanks for taking care of this!
>
> I'll try to apply it till the end of this week.
>
>>
>> I also noticed some minor regressions probably due to the new interface
(which looks pretty nice, by the way - good job!), namely:
>> - the yellow background is not shown on already edited messages (this
might just as well be a resources problem on my side), and
>
> Actually, we've decided to remove the yellow background from the
conversation area and show edited messages in italic with the "edited at"
text at the end.
>
>> - when editing a message for the second time, the message that's shown
in the write area is "old message (edited at ...)" instead of just "old
message".
>>
>
> Yep, I've noticed this one too. I'm currently preparing a commit that
should resolve all these little problems and make the new chat theme more
stable :slight_smile:
>
> Thanks!
> Yana
>
>> I'll try to look into them as well.
>>
>> Cheers,
>> Ivan
>> <yellowBackground.diff>
>