The following patch adds an option to the Jabber account editing
window that allows the change of the account password. It uses the
smack.AccountManager.changePassword() method, which in turn uses the
inband method described in XEP-077 .
A long awaited feature!
Applied, committed and acked!
The interface is a dialog box with just two fields for password and
password confirmation. After a successful change with the server, it
updates the locally stored password if there is one.
Any critique and comments will be appreciated.
I already mentioned offlist that your patch looks great. Good job!
I've applied a couple of minor changes ... not really worth mentioning
here but you'd need to update your local sandbox.
Particularly, I expect
the following parts to need to be discussed:
--The part which hides the the new option for gmail.com,
chat.facebook.com and talk.google.com accounts (since none of them
support password changes)
Right. We discussed this offlist and agreed to add a check that sends a
disco info request to the server (like the ones we use to query contact
capabilities) and verifies that it has support for 'jabber:iq:register'.
--The whole user interface
It's OK. We could add the password strength meter that we use for our
master password but it can wait.
It may also be worth using the password dialog that we generally use for
entering passwords. Alternately you could export the one that we use for
setting a master password and place it in util.
--The util package imported in
OperationSetChangePasswordJabberImpl.java (should it be
net.java.sip.communicator.util or org.jitsi.util?)
You got it right. The jabber bundle imports the
net.java.sip.communicator.util package so that's what you should use. We
should fix this in the future.
One more thing, in OperationSetChangePasswordJabberImpl.changePassword()
it would be worth making sure that the provider is signed in and
throwing an IllegalStateException if this is not the case.
I think the code is mostly straight forward and doesn't need much
explanation, but if you have any questions I'll be happy to explain.
Thanks again for a job well done!
On 03.08.12, 17:25, Boris Grozev wrote: