[jitsi-dev] [PATCH] Chat window menu bar can not be navigated using keyboard


#1

Hello,

When bringing up the menu bar in the chat window using Ctrl+F the key
pressed events are still being redispatched to the chat window making it
impossible to navigate the menu bar using the arrow keys.

The attached patch modifies the MainKeyDispatcher so that events are not
redispatched while the menubar is selected.

Best regards,
Markus

chatwindow-menubar-keyboard-issue1.txt (766 Bytes)


#2

Hi all,

Any comments on this one?

If there is no time to fix the bug now maybe we could register an issue
in JIRA so that it does not gets forgotten?

(I meant pressing Alt+F for opening the first menu)

Best regards,
Markus

···

On 2012-12-30 21:57, Markus Kilås wrote:

Hello,

When bringing up the menu bar in the chat window using Ctrl+F the key
pressed events are still being redispatched to the chat window making it
impossible to navigate the menu bar using the arrow keys.

The attached patch modifies the MainKeyDispatcher so that events are not
redispatched while the menubar is selected.

Best regards,
Markus


#3

Hi Markus,

Sorry for the delay! We've been quite busy lately.

Hello,

When bringing up the menu bar in the chat window using Ctrl+F the key
pressed events are still being redispatched to the chat window making it
impossible to navigate the menu bar using the arrow keys.

The attached patch modifies the MainKeyDispatcher so that events are not
redispatched while the menubar is selected.

Thanks for the patch! It's committed and ack-ed on our contributor's page.

The fix should be available in the next nightly build.

Cheers,
Yana

···

On Jan 19, 2013, at 10:23 AM, Markus Kilås <subjunctive.post@gmail.com> wrote:

On 2012-12-30 21:57, Markus Kilås wrote:

Best regards,
Markus

Hi all,

Any comments on this one?

If there is no time to fix the bug now maybe we could register an issue
in JIRA so that it does not gets forgotten?

(I meant pressing Alt+F for opening the first menu)

Best regards,
Markus


#4

Hi Markus,

Nice catch! Thanks for the patch!

Would it be a problem to make a slight modification and add a method in the ContactListContainer (which is already passed as a parameter), which checks if there's a selected menu currently. This is the way we are doing with other checks in the ContactListSearchKeyDispatcher, so I think it would be best to handle it this way.

Could you please submit a Pull Request for the patch?

Thanks!
Yana

···

On May 19, 2013, at 12:13 AM, Markus Kilås <subjunctive.post@gmail.com> wrote:

Hi,

Similar to the problem earlier with the chat window, the event
redispatching in the main window is interfering with the menu. In some
cases when an contact is selected and the menu is opened with Alt+F, a
key press on the arrow buttons are eaten up by the contact list instead
of changing menu item.

Attached is a patch solving the problem. It is also available on GitHub:
https://github.com/netmackan/jitsi/commit/baa5a905acb0d2f350c56ff1583a8c6bede08696

Best regards,
Markus

On 2013-01-19 13:05, Yana Stamcheva wrote:

Hi Markus,

Sorry for the delay! We've been quite busy lately.

On Jan 19, 2013, at 10:23 AM, Markus Kilås <subjunctive.post@gmail.com> wrote:

On 2012-12-30 21:57, Markus Kilås wrote:

Hello,

When bringing up the menu bar in the chat window using Ctrl+F the key
pressed events are still being redispatched to the chat window making it
impossible to navigate the menu bar using the arrow keys.

The attached patch modifies the MainKeyDispatcher so that events are not
redispatched while the menubar is selected.

Thanks for the patch! It's committed and ack-ed on our contributor's page.

The fix should be available in the next nightly build.

Cheers,
Yana

Best regards,
Markus

Hi all,

Any comments on this one?

If there is no time to fix the bug now maybe we could register an issue
in JIRA so that it does not gets forgotten?

(I meant pressing Alt+F for opening the first menu)

Best regards,
Markus

<main_window-menu-redispatch_issue-1.patch>_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#5

Hi Markus,

I just saw your git pull request. Thanks!

However did you see my comments below about creating a new isMenuSelected() in ContactListContainer, instead of passing the JMenuBar as a parameter? Do you disagree or you've missed them?

Thanks,
Yana

···

On May 19, 2013, at 7:16 PM, Yana Stamcheva <yana@jitsi.org> wrote:

Hi Markus,

Nice catch! Thanks for the patch!

Would it be a problem to make a slight modification and add a method in the ContactListContainer (which is already passed as a parameter), which checks if there's a selected menu currently. This is the way we are doing with other checks in the ContactListSearchKeyDispatcher, so I think it would be best to handle it this way.

Could you please submit a Pull Request for the patch?

Thanks!
Yana

On May 19, 2013, at 12:13 AM, Markus Kilås <subjunctive.post@gmail.com> wrote:

Hi,

Similar to the problem earlier with the chat window, the event
redispatching in the main window is interfering with the menu. In some
cases when an contact is selected and the menu is opened with Alt+F, a
key press on the arrow buttons are eaten up by the contact list instead
of changing menu item.

Attached is a patch solving the problem. It is also available on GitHub:
https://github.com/netmackan/jitsi/commit/baa5a905acb0d2f350c56ff1583a8c6bede08696

Best regards,
Markus

On 2013-01-19 13:05, Yana Stamcheva wrote:

Hi Markus,

Sorry for the delay! We've been quite busy lately.

On Jan 19, 2013, at 10:23 AM, Markus Kilås <subjunctive.post@gmail.com> wrote:

On 2012-12-30 21:57, Markus Kilås wrote:

Hello,

When bringing up the menu bar in the chat window using Ctrl+F the key
pressed events are still being redispatched to the chat window making it
impossible to navigate the menu bar using the arrow keys.

The attached patch modifies the MainKeyDispatcher so that events are not
redispatched while the menubar is selected.

Thanks for the patch! It's committed and ack-ed on our contributor's page.

The fix should be available in the next nightly build.

Cheers,
Yana

Best regards,
Markus

Hi all,

Any comments on this one?

If there is no time to fix the bug now maybe we could register an issue
in JIRA so that it does not gets forgotten?

(I meant pressing Alt+F for opening the first menu)

Best regards,
Markus

<main_window-menu-redispatch_issue-1.patch>_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#6

Hi Yana,

I think that it is a great idea. I have updated the patch/pull request
accordingly.

I have not been using GitHub before and didn't realize that all my
commits would end up in the request, so that is why there is also an
commit with an feature with a right click menu item for copying an
contacts address to the clip board. Let me know if I should try to split
out the two features in different requests somehow.

Best regards,
Markus

···

On 2013-05-19 23:03, Yana Stamcheva wrote:

Hi Markus,

I just saw your git pull request. Thanks!

However did you see my comments below about creating a new isMenuSelected() in ContactListContainer, instead of passing the JMenuBar as a parameter? Do you disagree or you've missed them?

Thanks,
Yana

On May 19, 2013, at 7:16 PM, Yana Stamcheva <yana@jitsi.org> wrote:

Hi Markus,

Nice catch! Thanks for the patch!

Would it be a problem to make a slight modification and add a method in the ContactListContainer (which is already passed as a parameter), which checks if there's a selected menu currently. This is the way we are doing with other checks in the ContactListSearchKeyDispatcher, so I think it would be best to handle it this way.

Could you please submit a Pull Request for the patch?

Thanks!
Yana

On May 19, 2013, at 12:13 AM, Markus Kil�s <subjunctive.post@gmail.com> wrote:

Hi,

Similar to the problem earlier with the chat window, the event
redispatching in the main window is interfering with the menu. In some
cases when an contact is selected and the menu is opened with Alt+F, a
key press on the arrow buttons are eaten up by the contact list instead
of changing menu item.

Attached is a patch solving the problem. It is also available on GitHub:
https://github.com/netmackan/jitsi/commit/baa5a905acb0d2f350c56ff1583a8c6bede08696

Best regards,
Markus

On 2013-01-19 13:05, Yana Stamcheva wrote:

Hi Markus,

Sorry for the delay! We've been quite busy lately.

On Jan 19, 2013, at 10:23 AM, Markus Kil�s <subjunctive.post@gmail.com> wrote:

On 2012-12-30 21:57, Markus Kil�s wrote:

Hello,

When bringing up the menu bar in the chat window using Ctrl+F the key
pressed events are still being redispatched to the chat window making it
impossible to navigate the menu bar using the arrow keys.

The attached patch modifies the MainKeyDispatcher so that events are not
redispatched while the menubar is selected.

Thanks for the patch! It's committed and ack-ed on our contributor's page.

The fix should be available in the next nightly build.

Cheers,
Yana

Best regards,
Markus

Hi all,

Any comments on this one?

If there is no time to fix the bug now maybe we could register an issue
in JIRA so that it does not gets forgotten?

(I meant pressing Alt+F for opening the first menu)

Best regards,
Markus

<main_window-menu-redispatch_issue-1.patch>_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#7

Hi Markus,

Thanks for the patch! It's now committed and ack-ed.

I had to add some javadoc comments and make the code fit our code convention, but otherwise it was just what I had in mind. Thanks!

Cheers,
Yana

···

On May 20, 2013, at 11:56 PM, Markus Kilås <subjunctive.post@gmail.com> wrote:

Hi Yana,

I think that it is a great idea. I have updated the patch/pull request
accordingly.

I have not been using GitHub before and didn't realize that all my
commits would end up in the request, so that is why there is also an
commit with an feature with a right click menu item for copying an
contacts address to the clip board. Let me know if I should try to split
out the two features in different requests somehow.

Best regards,
Markus

On 2013-05-19 23:03, Yana Stamcheva wrote:

Hi Markus,

I just saw your git pull request. Thanks!

However did you see my comments below about creating a new isMenuSelected() in ContactListContainer, instead of passing the JMenuBar as a parameter? Do you disagree or you've missed them?

Thanks,
Yana

On May 19, 2013, at 7:16 PM, Yana Stamcheva <yana@jitsi.org> wrote:

Hi Markus,

Nice catch! Thanks for the patch!

Would it be a problem to make a slight modification and add a method in the ContactListContainer (which is already passed as a parameter), which checks if there's a selected menu currently. This is the way we are doing with other checks in the ContactListSearchKeyDispatcher, so I think it would be best to handle it this way.

Could you please submit a Pull Request for the patch?

Thanks!
Yana

On May 19, 2013, at 12:13 AM, Markus Kilås <subjunctive.post@gmail.com> wrote:

Hi,

Similar to the problem earlier with the chat window, the event
redispatching in the main window is interfering with the menu. In some
cases when an contact is selected and the menu is opened with Alt+F, a
key press on the arrow buttons are eaten up by the contact list instead
of changing menu item.

Attached is a patch solving the problem. It is also available on GitHub:
https://github.com/netmackan/jitsi/commit/baa5a905acb0d2f350c56ff1583a8c6bede08696

Best regards,
Markus

On 2013-01-19 13:05, Yana Stamcheva wrote:

Hi Markus,

Sorry for the delay! We've been quite busy lately.

On Jan 19, 2013, at 10:23 AM, Markus Kilås <subjunctive.post@gmail.com> wrote:

On 2012-12-30 21:57, Markus Kilås wrote:

Hello,

When bringing up the menu bar in the chat window using Ctrl+F the key
pressed events are still being redispatched to the chat window making it
impossible to navigate the menu bar using the arrow keys.

The attached patch modifies the MainKeyDispatcher so that events are not
redispatched while the menubar is selected.

Thanks for the patch! It's committed and ack-ed on our contributor's page.

The fix should be available in the next nightly build.

Cheers,
Yana

Best regards,
Markus

Hi all,

Any comments on this one?

If there is no time to fix the bug now maybe we could register an issue
in JIRA so that it does not gets forgotten?

(I meant pressing Alt+F for opening the first menu)

Best regards,
Markus

<main_window-menu-redispatch_issue-1.patch>_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev