Nice catch! Thanks for the patch!
Would it be a problem to make a slight modification and add a method in the ContactListContainer (which is already passed as a parameter), which checks if there's a selected menu currently. This is the way we are doing with other checks in the ContactListSearchKeyDispatcher, so I think it would be best to handle it this way.
Could you please submit a Pull Request for the patch?
On May 19, 2013, at 12:13 AM, Markus Kilås <email@example.com> wrote:
Similar to the problem earlier with the chat window, the event
redispatching in the main window is interfering with the menu. In some
cases when an contact is selected and the menu is opened with Alt+F, a
key press on the arrow buttons are eaten up by the contact list instead
of changing menu item.
Attached is a patch solving the problem. It is also available on GitHub:
On 2013-01-19 13:05, Yana Stamcheva wrote:
Sorry for the delay! We've been quite busy lately.
On Jan 19, 2013, at 10:23 AM, Markus Kilås <firstname.lastname@example.org> wrote:
On 2012-12-30 21:57, Markus Kilås wrote:
When bringing up the menu bar in the chat window using Ctrl+F the key
pressed events are still being redispatched to the chat window making it
impossible to navigate the menu bar using the arrow keys.
The attached patch modifies the MainKeyDispatcher so that events are not
redispatched while the menubar is selected.
Thanks for the patch! It's committed and ack-ed on our contributor's page.
The fix should be available in the next nightly build.
Any comments on this one?
If there is no time to fix the bug now maybe we could register an issue
in JIRA so that it does not gets forgotten?
(I meant pressing Alt+F for opening the first menu)
dev mailing list
Unsubscribe instructions and other list options: