[jitsi-dev] [PATCH] Change for the filename format of the recorded call file


#1

Hello,

I talked with Emil and Ingo to add to the filename of the recorded call
file the username of the other participant of the call. All symbols from
the username which are different than digits, letters and dashes are
skipped. The maximum filename length is set to 64 symbols.

I'm attaching the patch.

Regards.

recorded_filename_format.patch (2.39 KB)


#2

Hey Hristo,

Thanks for the patch!

It's now part of revision 10442 and is ack-ed on our contributors page.

(more inline)

Hello,

I talked with Emil and Ingo to add to the filename of the recorded call
file the username of the other participant of the call. All symbols from
the username which are different than digits, letters and dashes are
skipped. The maximum filename length is set to 64 symbols.

Currently the @ is just skipped, which may result in a difficult to read
string. What would you say to replace the @ by a dash?

Cheers,
Yana

···

On Tue, Feb 5, 2013 at 8:34 PM, Hristo Terezov <hristoterezov@gmail.com>wrote:

I'm attaching the patch.

Regards.


#3

Hi Yana,

Thanks for adding my patch.

About the @ I can replace it with dash, no problem. We can even leave it in
the filename if you think it will be better.

Regards,
Hristo.

···

On Mon, Feb 11, 2013 at 11:08 AM, Yana Stamcheva <yana@jitsi.org> wrote:

Hey Hristo,

Thanks for the patch!

It's now part of revision 10442 and is ack-ed on our contributors page.

(more inline)

On Tue, Feb 5, 2013 at 8:34 PM, Hristo Terezov <hristoterezov@gmail.com>wrote:

Hello,

I talked with Emil and Ingo to add to the filename of the recorded call
file the username of the other participant of the call. All symbols from
the username which are different than digits, letters and dashes are
skipped. The maximum filename length is set to 64 symbols.

Currently the @ is just skipped, which may result in a difficult to read
string. What would you say to replace the @ by a dash?

Cheers,
Yana

I'm attaching the patch.

Regards.


#4

Hello,

I'm attaching a new patch. I have added '@' and '.' to allowed chars and
they won't be skipped in the filename.

Regards,
Hristo.

recorded_filename_format.txt (734 Bytes)

···

On Mon, Feb 11, 2013 at 11:19 AM, Hristo Terezov <hristoterezov@gmail.com>wrote:

Hi Yana,

Thanks for adding my patch.

About the @ I can replace it with dash, no problem. We can even leave it
in the filename if you think it will be better.

Regards,
Hristo.

On Mon, Feb 11, 2013 at 11:08 AM, Yana Stamcheva <yana@jitsi.org> wrote:

Hey Hristo,

Thanks for the patch!

It's now part of revision 10442 and is ack-ed on our contributors page.

(more inline)

On Tue, Feb 5, 2013 at 8:34 PM, Hristo Terezov <hristoterezov@gmail.com>wrote:

Hello,

I talked with Emil and Ingo to add to the filename of the recorded call
file the username of the other participant of the call. All symbols from
the username which are different than digits, letters and dashes are
skipped. The maximum filename length is set to 64 symbols.

Currently the @ is just skipped, which may result in a difficult to read
string. What would you say to replace the @ by a dash?

Cheers,
Yana

I'm attaching the patch.

Regards.