I have found a little (big?) bug in file
Thank you very much for the report!
While I agree with you that the code is technically incorrect and that
we should fix it, the binary committed in trunk is compiled without
_MBCS and without _UNICODE so it should practically function as
Does it sound OK to just commit the source code of your patch and not
modify the binary? I'm asking because the binary used to be
incorrectly reported as a virus by numerous anti-virus software
products and we had to contact each of them to ask them to fix their
false positives so the new binary might cause the warnings to reappear
(because we've updated our compilers to newer versions and they will
likely produce slightly different binaries).
in line 135
memcpy(str, "\\Outlook.exe", 12 * sizeof(TCHAR));
it should be
memcpy(str, _T("\\Outlook.exe"), 12 * sizeof(TCHAR));
otherwise memcpy copies wrong bytes and the subsequent
fileAttributes = GetFileAttributes(pathValue);
Are you compiling the binary yourself passing any of _MBCS and _UNICODE?
On Thu, May 5, 2011 at 3:42 PM, Davide Corda <firstname.lastname@example.org> wrote: