[jitsi-dev] OTR regressions


#1

Hey Marin, George,

Thank you both for your work on this.

I've noticed a couple of regressions with this:

1. The OTR padlock no longer has a a rollover state. It's as if it is frozen.

2. Trying to enable OTR for someone who doesn't have it (e.g. a
hangouts user) brings no output.

3. At one point I had Jitsi hit almost 100% on all four cores

4. (I believe this is an old one) Clicking on the OTR button doesn't
have an immediate effect to the user. The button should "give in" when
clicked. We shouldn't be waiting for the session to be established in
order to do this.

Marin, could you please have a look at those?

Thanks,
Emil

···

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
https://jitsi.org FAX: +33.1.77.62.47.31


#2

Oh and I forgot:

I am not seeing any way of authenticating buddies through SMP. I
thought we committed this ... did I somehow just dream about it?

Emil

···

On Sun, Nov 10, 2013 at 6:57 PM, Emil Ivov <emcho@jitsi.org> wrote:

Hey Marin, George,

Thank you both for your work on this.

I've noticed a couple of regressions with this:

1. The OTR padlock no longer has a a rollover state. It's as if it is frozen.

2. Trying to enable OTR for someone who doesn't have it (e.g. a
hangouts user) brings no output.

3. At one point I had Jitsi hit almost 100% on all four cores

4. (I believe this is an old one) Clicking on the OTR button doesn't
have an immediate effect to the user. The button should "give in" when
clicked. We shouldn't be waiting for the session to be established in
order to do this.

Marin, could you please have a look at those?

Thanks,
Emil

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
https://jitsi.org FAX: +33.1.77.62.47.31

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
https://jitsi.org FAX: +33.1.77.62.47.31


#3

Hello Emil,

Actually, everything that you mentioned are old problems since none of the
work me and George have done in the past weeks has been commited.

1. The OTR padlock no longer has a a rollover state. It's as if it is

frozen.

I don't remember the OTR padlock to ever had any rollover states.
When I try to rollover the padlock all I see is a "Start private
conversation" popup. It was always like that.
But do you want to add another padlock icon?

2. Trying to enable OTR for someone who doesn't have it (e.g. a

hangouts user) brings no output.

According to the OTR specification if Alice wishes to communicate to Bob
that she would like to use OTR, she sends a message containing the string
"?OTR" followed by an indication of what versions of OTR she is willing to
use with Bob. In Jitsi we send:

"*?OTRv2?<span style="font-weight: bold;">m.dzhigarov@jit.si
<m.dzhigarov1@jit.si> (Jabber) is trying to initiate an encrypted <a
href="http://en.wikipedia.org/wiki/Off-the-Record_Messaging
<http://en.wikipedia.org/wiki/Off-the-Record_Messaging>">Off-The-Record
conversation</a> with you. However, your software does not support
Off-The-Record messaging. For more information see <a
href="http://en.wikipedia.org/wiki/Off-the-Record_Messaging
<http://en.wikipedia.org/wiki/Off-the-Record_Messaging>">http://en.wikipedia.org/wiki/Off-the-Record_Messaging
<http://en.wikipedia.org/wiki/Off-the-Record_Messaging></a></span>*"

If the remote party does not support OTR obviously his chat client will not
be able to respond properly and inform Jitsi that OTR is not supported. In
this case I don't see what we can/should do.

3. At one point I had Jitsi hit almost 100% on all four cores

I will have a look. Can you send me any logs?

4. (I believe this is an old one) Clicking on the OTR button doesn't

have an immediate effect to the user. The button should "give in" when
clicked. We shouldn't be waiting for the session to be established in
order to do this.

If that's the case I believe that we would need an additional icon for he
lockpad that would indicate session establishment in progress.

Regards,
Marin

···

On Sun, Nov 10, 2013 at 7:57 PM, Emil Ivov <emcho@jitsi.org> wrote:

Hey Marin, George,

Thank you both for your work on this.

I've noticed a couple of regressions with this:

1. The OTR padlock no longer has a a rollover state. It's as if it is
frozen.

2. Trying to enable OTR for someone who doesn't have it (e.g. a
hangouts user) brings no output.

3. At one point I had Jitsi hit almost 100% on all four cores

4. (I believe this is an old one) Clicking on the OTR button doesn't
have an immediate effect to the user. The button should "give in" when
clicked. We shouldn't be waiting for the session to be established in
order to do this.

Marin, could you please have a look at those?

Thanks,
Emil

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
https://jitsi.org FAX: +33.1.77.62.47.31

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#4

It's not yet committed actually! Marin submitted a pull request (that
for some reason appeared in the jitsi commits mailing list) that should
be integrated next week after he fixes a few more details.

···

On 11/10/2013 07:00 PM, Emil Ivov wrote:

Oh and I forgot:

I am not seeing any way of authenticating buddies through SMP. I
thought we committed this ... did I somehow just dream about it?

Emil

On Sun, Nov 10, 2013 at 6:57 PM, Emil Ivov <emcho@jitsi.org> wrote:

Hey Marin, George,

Thank you both for your work on this.

I've noticed a couple of regressions with this:

1. The OTR padlock no longer has a a rollover state. It's as if it is frozen.

2. Trying to enable OTR for someone who doesn't have it (e.g. a
hangouts user) brings no output.

3. At one point I had Jitsi hit almost 100% on all four cores

4. (I believe this is an old one) Clicking on the OTR button doesn't
have an immediate effect to the user. The button should "give in" when
clicked. We shouldn't be waiting for the session to be established in
order to do this.

Marin, could you please have a look at those?

Thanks,
Emil

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
https://jitsi.org FAX: +33.1.77.62.47.31


#5

Hello Emil,

Actually, everything that you mentioned are old problems since none of the
work me and George have done in the past weeks has been commited.

Yes, George already mentioned that. I wasn't following last week's
commit messages very closely so apparently I got confused about what
got committed where.

1. The OTR padlock no longer has a a rollover state. It's as if it is
frozen.

I don't remember the OTR padlock to ever had any rollover states.
When I try to rollover the padlock all I see is a "Start private
conversation" popup. It was always like that.
But do you want to add another padlock icon?

It's not about a new icon (although that might be worth considering
for other reasons too). All icons in the chat window have a rollover
state generated by us. It looks like a highlight. I am not sure why
the OTR doesn't but that's a thing we should fix.

2. Trying to enable OTR for someone who doesn't have it (e.g. a
hangouts user) brings no output.

According to the OTR specification if Alice wishes to communicate to Bob
that she would like to use OTR, she sends a message containing the string
"?OTR" followed by an indication of what versions of OTR she is willing to
use with Bob. In Jitsi we send:

"?OTRv2?<span style="font-weight: bold;">m.dzhigarov@jit.si (Jabber) is
trying to initiate an encrypted <a
href="http://en.wikipedia.org/wiki/Off-the-Record_Messaging">Off-The-Record
conversation</a> with you. However, your software does not support
Off-The-Record messaging. For more information see <a
href="http://en.wikipedia.org/wiki/Off-the-Record_Messaging">http://en.wikipedia.org/wiki/Off-the-Record_Messaging</a></span>"

If the remote party does not support OTR obviously his chat client will not
be able to respond properly and inform Jitsi that OTR is not supported. In
this case I don't see what we can/should do.

I think you missed my point. Currently clicking on the OTR button has
*no* visible effect whatsoever. At the very least the button should at
least sink while you are pressing it. Ideally it would also give you
an indication that an attempt of establishment is in progress (e.g. a
progress wheel) and then you should obviously get an indication of the
end result as well, even when it failed. This doesn't currently happen
every time. You can try that with any hangouts contacts that you may
have in your roster.

3. At one point I had Jitsi hit almost 100% on all four cores

I will have a look. Can you send me any logs?

4. (I believe this is an old one) Clicking on the OTR button doesn't
have an immediate effect to the user. The button should "give in" when
clicked. We shouldn't be waiting for the session to be established in
order to do this.

If that's the case

Well ... it is :wink:

I believe that we would need an additional icon for he
lockpad that would indicate session establishment in progress.

We could indeed.

Emil

···

On Mon, Nov 11, 2013 at 9:12 AM, Marin Dzhigarov <marin@bluejimp.com> wrote:

Regards,
Marin

On Sun, Nov 10, 2013 at 7:57 PM, Emil Ivov <emcho@jitsi.org> wrote:

Hey Marin, George,

Thank you both for your work on this.

I've noticed a couple of regressions with this:

1. The OTR padlock no longer has a a rollover state. It's as if it is
frozen.

2. Trying to enable OTR for someone who doesn't have it (e.g. a
hangouts user) brings no output.

3. At one point I had Jitsi hit almost 100% on all four cores

4. (I believe this is an old one) Clicking on the OTR button doesn't
have an immediate effect to the user. The button should "give in" when
clicked. We shouldn't be waiting for the session to be established in
order to do this.

Marin, could you please have a look at those?

Thanks,
Emil

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
https://jitsi.org FAX: +33.1.77.62.47.31

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
https://jitsi.org FAX: +33.1.77.62.47.31


#6

Dear All,
I am very happy that a full functional OTR is already on the way - many
thanks and looking forward!

an (important?) user request for the padlock-icon:

i) currently the padlock "hook" opens and closes only with very little
distance, if one doesn´t look carefully it can be easily overseen that
it is not closed yet (especially if the contact was already
authenticated, so no color label is there)
Q: would it be possible to change the icon so that the hook "turns out
to the right" to make it easier visible (comparable to the icon in the
stable 1.0 version?

ii) the padlock currently shows only one color label (yellow for secure
but not authenticated)
Q: would it be possible to add color labels (or the whole padlock in
color) similar to the zRTP padlock for Audio/Video?
e.g:
opened+red: not secure chat
closed+yellow: secured but not authenticated
closed+green: secured and authenticated

thanks a lot!
MS

PGP.sig (489 Bytes)

···

On 11/11/13 10:12 AM, Marin Dzhigarov wrote:

Hello Emil,

Actually, everything that you mentioned are old problems since none of
the work me and George have done in the past weeks has been commited.

    1. The OTR padlock no longer has a a rollover state. It's as if it
    is frozen.

I don't remember the OTR padlock to ever had any rollover states.
When I try to rollover the padlock all I see is a "Start private
conversation" popup. It was always like that.
But do you want to add another padlock icon?

    2. Trying to enable OTR for someone who doesn't have it (e.g. a
    hangouts user) brings no output.

According to the OTR specification if Alice wishes to communicate to
Bob that she would like to use OTR, she sends a message containing the
string "?OTR" followed by an indication of what versions of OTR she is
willing to use with Bob. In Jitsi we send:

"/?OTRv2?<span style="font-weight: bold;">m.dzhigarov@jit.si
<mailto:m.dzhigarov1@jit.si> (Jabber) is trying to initiate an
encrypted <a
href="http://en.wikipedia.org/wiki/Off-the-Record_Messaging">Off-The-Record
conversation</a> with you. However, your software does not support
Off-The-Record messaging. For more information see <a
href="http://en.wikipedia.org/wiki/Off-the-Record_Messaging">http://en.wikipedia.org/wiki/Off-the-Record_Messaging</a></span>/"

If the remote party does not support OTR obviously his chat client
will not be able to respond properly and inform Jitsi that OTR is not
supported. In this case I don't see what we can/should do.

    3. At one point I had Jitsi hit almost 100% on all four cores

I will have a look. Can you send me any logs?

     4. (I believe this is an old one) Clicking on the OTR button doesn't
    have an immediate effect to the user. The button should "give in" when
    clicked. We shouldn't be waiting for the session to be established in
    order to do this.

If that's the case I believe that we would need an additional icon for
he lockpad that would indicate session establishment in progress.

Regards,
Marin

On Sun, Nov 10, 2013 at 7:57 PM, Emil Ivov <emcho@jitsi.org > <mailto:emcho@jitsi.org>> wrote:

    Hey Marin, George,

    Thank you both for your work on this.

    I've noticed a couple of regressions with this:

    1. The OTR padlock no longer has a a rollover state. It's as if it
    is frozen.

    2. Trying to enable OTR for someone who doesn't have it (e.g. a
    hangouts user) brings no output.

    3. At one point I had Jitsi hit almost 100% on all four cores

    4. (I believe this is an old one) Clicking on the OTR button doesn't
    have an immediate effect to the user. The button should "give in" when
    clicked. We shouldn't be waiting for the session to be established in
    order to do this.

    Marin, could you please have a look at those?

    Thanks,
    Emil

    --
    Emil Ivov, Ph.D. 67000 Strasbourg,
    Project Lead France
    Jitsi
    emcho@jitsi.org <mailto:emcho@jitsi.org>
     PHONE: +33.1.77.62.43.30 <tel:%2B33.1.77.62.43.30>
    https://jitsi.org FAX: +33.1.77.62.47.31
    <tel:%2B33.1.77.62.47.31>

    _______________________________________________
    dev mailing list
    dev@jitsi.org <mailto:dev@jitsi.org>
    Unsubscribe instructions and other list options:
    http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#7

Dear All,
I am very happy that a full functional OTR is already on the way - many
thanks and looking forward!

an (important?) user request for the padlock-icon:

i) currently the padlock "hook" opens and closes only with very little
distance, if one doesn´t look carefully it can be easily overseen that it is
not closed yet (especially if the contact was already authenticated, so no
color label is there)
Q: would it be possible to change the icon so that the hook "turns out to
the right" to make it easier visible (comparable to the icon in the stable
1.0 version?

Yes I agree there's an issue there. We'll try to improve this.

ii) the padlock currently shows only one color label (yellow for secure but
not authenticated)
Q: would it be possible to add color labels (or the whole padlock in color)
similar to the zRTP padlock for Audio/Video?
e.g:
opened+red: not secure chat
closed+yellow: secured but not authenticated
closed+green: secured and authenticated

Agreed again.

Emil

···

On Mon, Nov 11, 2013 at 9:36 AM, Mr.Smith <mr.smith476@gmail.com> wrote:

thanks a lot!
MS

On 11/11/13 10:12 AM, Marin Dzhigarov wrote:

Hello Emil,

Actually, everything that you mentioned are old problems since none of the
work me and George have done in the past weeks has been commited.

1. The OTR padlock no longer has a a rollover state. It's as if it is
frozen.

I don't remember the OTR padlock to ever had any rollover states.
When I try to rollover the padlock all I see is a "Start private
conversation" popup. It was always like that.
But do you want to add another padlock icon?

2. Trying to enable OTR for someone who doesn't have it (e.g. a
hangouts user) brings no output.

According to the OTR specification if Alice wishes to communicate to Bob
that she would like to use OTR, she sends a message containing the string
"?OTR" followed by an indication of what versions of OTR she is willing to
use with Bob. In Jitsi we send:

"?OTRv2?<span style="font-weight: bold;">m.dzhigarov@jit.si (Jabber) is
trying to initiate an encrypted <a
href="http://en.wikipedia.org/wiki/Off-the-Record_Messaging">Off-The-Record
conversation</a> with you. However, your software does not support
Off-The-Record messaging. For more information see <a
href="http://en.wikipedia.org/wiki/Off-the-Record_Messaging">http://en.wikipedia.org/wiki/Off-the-Record_Messaging</a></span>"

If the remote party does not support OTR obviously his chat client will not
be able to respond properly and inform Jitsi that OTR is not supported. In
this case I don't see what we can/should do.

3. At one point I had Jitsi hit almost 100% on all four cores

I will have a look. Can you send me any logs?

4. (I believe this is an old one) Clicking on the OTR button doesn't
have an immediate effect to the user. The button should "give in" when
clicked. We shouldn't be waiting for the session to be established in
order to do this.

If that's the case I believe that we would need an additional icon for he
lockpad that would indicate session establishment in progress.

Regards,
Marin

On Sun, Nov 10, 2013 at 7:57 PM, Emil Ivov <emcho@jitsi.org> wrote:

Hey Marin, George,

Thank you both for your work on this.

I've noticed a couple of regressions with this:

1. The OTR padlock no longer has a a rollover state. It's as if it is
frozen.

2. Trying to enable OTR for someone who doesn't have it (e.g. a
hangouts user) brings no output.

3. At one point I had Jitsi hit almost 100% on all four cores

4. (I believe this is an old one) Clicking on the OTR button doesn't
have an immediate effect to the user. The button should "give in" when
clicked. We shouldn't be waiting for the session to be established in
order to do this.

Marin, could you please have a look at those?

Thanks,
Emil

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
https://jitsi.org FAX: +33.1.77.62.47.31

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
https://jitsi.org FAX: +33.1.77.62.47.31


#8

Hello,

I made a pull request for the otr4j repo.

I added a new method to the OtrEngineListener interface. Signature:
sessionIsStarting(SessionID session); in order for applications to react
when a new session is about to start or more precisely, when
OtrEngine.startSession(). The reaction for example can be sending a message
to the user that initiating private conversation is in progress, or in
Jitsi's case - change the padlock icon to "loading padlock"

George, can you please review and merge the request when you have time for
this.

Thanks!

Regards,
Marin

···

On Mon, Nov 11, 2013 at 11:07 AM, Emil Ivov <emcho@jitsi.org> wrote:

On Mon, Nov 11, 2013 at 9:36 AM, Mr.Smith <mr.smith476@gmail.com> wrote:
> Dear All,
> I am very happy that a full functional OTR is already on the way - many
> thanks and looking forward!
>
> an (important?) user request for the padlock-icon:
>
> i) currently the padlock "hook" opens and closes only with very little
> distance, if one doesn´t look carefully it can be easily overseen that
it is
> not closed yet (especially if the contact was already authenticated, so
no
> color label is there)
> Q: would it be possible to change the icon so that the hook "turns out to
> the right" to make it easier visible (comparable to the icon in the
stable
> 1.0 version?

Yes I agree there's an issue there. We'll try to improve this.

> ii) the padlock currently shows only one color label (yellow for secure
but
> not authenticated)
> Q: would it be possible to add color labels (or the whole padlock in
color)
> similar to the zRTP padlock for Audio/Video?
> e.g:
> opened+red: not secure chat
> closed+yellow: secured but not authenticated
> closed+green: secured and authenticated

Agreed again.

Emil

> thanks a lot!
> MS
>
>
>
> On 11/11/13 10:12 AM, Marin Dzhigarov wrote:
>
> Hello Emil,
>
> Actually, everything that you mentioned are old problems since none of
the
> work me and George have done in the past weeks has been commited.
>
>> 1. The OTR padlock no longer has a a rollover state. It's as if it is
>> frozen.
>
>
> I don't remember the OTR padlock to ever had any rollover states.
> When I try to rollover the padlock all I see is a "Start private
> conversation" popup. It was always like that.
> But do you want to add another padlock icon?
>
>> 2. Trying to enable OTR for someone who doesn't have it (e.g. a
>> hangouts user) brings no output.
>
>
> According to the OTR specification if Alice wishes to communicate to Bob
> that she would like to use OTR, she sends a message containing the string
> "?OTR" followed by an indication of what versions of OTR she is willing
to
> use with Bob. In Jitsi we send:
>
> "?OTRv2?<span style="font-weight: bold;">m.dzhigarov@jit.si (Jabber) is
> trying to initiate an encrypted <a
> href="http://en.wikipedia.org/wiki/Off-the-Record_Messaging
">Off-The-Record
> conversation</a> with you. However, your software does not support
> Off-The-Record messaging. For more information see <a
> href="http://en.wikipedia.org/wiki/Off-the-Record_Messaging">
http://en.wikipedia.org/wiki/Off-the-Record_Messaging</a></span>"
>
> If the remote party does not support OTR obviously his chat client will
not
> be able to respond properly and inform Jitsi that OTR is not supported.
In
> this case I don't see what we can/should do.
>
>> 3. At one point I had Jitsi hit almost 100% on all four cores
>
>
> I will have a look. Can you send me any logs?
>
>> 4. (I believe this is an old one) Clicking on the OTR button doesn't
>> have an immediate effect to the user. The button should "give in" when
>> clicked. We shouldn't be waiting for the session to be established in
>> order to do this.
>
>
> If that's the case I believe that we would need an additional icon for he
> lockpad that would indicate session establishment in progress.
>
> Regards,
> Marin
>
>
> On Sun, Nov 10, 2013 at 7:57 PM, Emil Ivov <emcho@jitsi.org> wrote:
>>
>> Hey Marin, George,
>>
>> Thank you both for your work on this.
>>
>> I've noticed a couple of regressions with this:
>>
>> 1. The OTR padlock no longer has a a rollover state. It's as if it is
>> frozen.
>>
>> 2. Trying to enable OTR for someone who doesn't have it (e.g. a
>> hangouts user) brings no output.
>>
>> 3. At one point I had Jitsi hit almost 100% on all four cores
>>
>> 4. (I believe this is an old one) Clicking on the OTR button doesn't
>> have an immediate effect to the user. The button should "give in" when
>> clicked. We shouldn't be waiting for the session to be established in
>> order to do this.
>>
>> Marin, could you please have a look at those?
>>
>> Thanks,
>> Emil
>>
>> --
>> Emil Ivov, Ph.D. 67000 Strasbourg,
>> Project Lead France
>> Jitsi
>> emcho@jitsi.org PHONE: +33.1.77.62.43.30
>> https://jitsi.org FAX: +33.1.77.62.47.31
>>
>> _______________________________________________
>> dev mailing list
>> dev@jitsi.org
>> Unsubscribe instructions and other list options:
>> http://lists.jitsi.org/mailman/listinfo/dev
>
>
>
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev
>
>
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
https://jitsi.org FAX: +33.1.77.62.47.31

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev