[jitsi-dev] No return value from jawtrenderer library


#1

Hi all,
I'm building a rpm package for Jitsi from source and I tried to build native libraries too.
The JAWTRenderer library builds fine, but the check from rpmlint warn me about:

I: Program returns random data in a function
E: jitsi-test no-return-in-nonvoid-function [cc]
/usr/src/packages/BUILD/trunk-8737/src/native/jawtrenderer/net_java_sip_communicator_impl_neomedia_jmfext_media_renderer_video_JAWTRenderer.c:153

I: Program returns random data in a function
E: jitsi-test no-return-in-nonvoid-function [cc]
/usr/src/packages/BUILD/trunk-8737/src/native/jawtrenderer/net_java_sip_communicator_impl_neomedia_jmfext_media_renderer_video_JAWTRenderer.c:153

I looked into the file indicated and I found that when a condition match, directives won't allow the body of the function to be defined and so it's removed also the "return" instruction.
Maybe it's the case to use a "return null" or something more consistent to avoid dangerous behavior of the function.

Cheers,
Daniel


#2

I do not have the source code at hand right now so I will be able to look at
it next week at the earliest. If it is one of the Mac OS X-only functions,
it should be safe to return whatever default "zero" value is appropriate.