[jitsi-dev] Multipe chat windows


#1

Hey

Quoting Emil's comment [1]:

You seem to be using multiple windows though. We aren't really
supporting this mode any more. We should probably remove the
option to avoid further confusion.

I can't remember any discussion about the multi-window mode and even less
for not supporting it. It is essential for me and removing it would be a
show stopper as far as it concerns chats.
So what's the problem with it?

Ingo

[1] https://trac.jitsi.org/ticket/1057#comment:4


#2

Hey Ingo,

Hey

Quoting Emil's comment [1]:

You seem to be using multiple windows though. We aren't really
supporting this mode any more. We should probably remove the
option to avoid further confusion.

I can't remember any discussion about the multi-window mode and even less
for not supporting it.

Well there wasn't any. However I didn't think anyone I knew was
actually using it and we haven't debugged a single issue with it for
the past five years or so. I am actually quite surprised it is still
working.

It is essential for me and removing it would be a
show stopper as far as it concerns chats.

OK, so I guess this means it is actually mostly working in which case,
especially given that people seem to be finding it useful, I would be
willing to reconsider.

So what's the problem with it?

Right now there seems to be a problem with the registration of
external plugins (such as OTR and spellcheck).

That said in this specific case it is probably going to help us find
out why these buttons were disappearing even with the single chat
window, so it's not such a bad thing.

Cheers,
Emil

···

On Wed, Aug 21, 2013 at 9:47 PM, Ingo Bauersachs <ingo@jitsi.org> wrote:


#3

Hi Emil, Ingo,

Hey Ingo,

Hey

Quoting Emil's comment [1]:

You seem to be using multiple windows though. We aren't really
supporting this mode any more. We should probably remove the
option to avoid further confusion.

I can't remember any discussion about the multi-window mode and even less
for not supporting it.

Well there wasn't any. However I didn't think anyone I knew was
actually using it and we haven't debugged a single issue with it for
the past five years or so. I am actually quite surprised it is still
working.

It is essential for me and removing it would be a
show stopper as far as it concerns chats.

OK, so I guess this means it is actually mostly working in which case,
especially given that people seem to be finding it useful, I would be
willing to reconsider.

So what's the problem with it?

Right now there seems to be a problem with the registration of
external plugins (such as OTR and spellcheck).

That said in this specific case it is probably going to help us find
out why these buttons were disappearing even with the single chat
window, so it's not such a bad thing.

Cheers,
Emil

While I've been working with OTR plugin for Android I've noticed that
there is only one instance of button ever created so it looks like
it's not supposed to work with multiple windows at one time. If you
want I can take a look on those OTR problems they should not be that
hard to fix.

Now we have in OtrActivator:

bundleContext.registerService(
                PluginComponent.class.getName(),
                new OtrMetaContactButton(Container.CONTAINER_CHAT_TOOL_BAR),
                containerFilter);

OtrMetaContactButton is the padlock button in chat toolbar. It can
handle one contact at a time.

Regards,
Pawel

···

On Thu, Aug 22, 2013 at 1:08 PM, Emil Ivov <emcho@jitsi.org> wrote:

On Wed, Aug 21, 2013 at 9:47 PM, Ingo Bauersachs <ingo@jitsi.org> wrote:


#4

Once I was fixing such an issue, the problem was a memory leak of the chat
windows and the one instance of the plugin was added in the first window
and subsequent window instances do not show the plugin.
And it is normal when having multiple windows to miss those plugins. We
need to look all of those Plugins and make sure the component is created
once per parent component or somthing similar. I remember also that the
method creating the component was invoked just for some checks several time
before displaying the component and maybe because of this the component is
created only once.

Regards
damencho

···

On Thu, Aug 22, 2013 at 2:08 PM, Emil Ivov <emcho@jitsi.org> wrote:

That said in this specific case it is probably going to help us find
out why these buttons were disappearing even with the single chat
window, so it's not such a bad thing.