[jitsi-dev] Mis-aligned filmstrip


#1

Hi guys,

I've repackaged Jitsi-Meet, Jicofo and the Videobridge, and deployed that
on my XMPP server. It appears to work out well, apart from one oddity: the
filmstrip-videos appear to be overlapping.

It's likely a silly mistake on my end, but I can't figure out what's
causing it. Could someone give me a pointer?

The instance is running (without a valid TLS certificate) here:
https://xmpp.goodbytes.nl:7443/ofmeet/jitsi-meet/

Regards,

  Guus


#2

Hi,

I don't see anything obvious at the moment, seems so strange. Will
ping someone with more css and UI render knowledge to take a look :slight_smile:

Regards
damencho

···

On Tue, Apr 25, 2017 at 7:46 AM, Guus der Kinderen <guus.der.kinderen@gmail.com> wrote:

Hi guys,

I've repackaged Jitsi-Meet, Jicofo and the Videobridge, and deployed that on
my XMPP server. It appears to work out well, apart from one oddity: the
filmstrip-videos appear to be overlapping.

It's likely a silly mistake on my end, but I can't figure out what's causing
it. Could someone give me a pointer?

The instance is running (without a valid TLS certificate) here:
https://xmpp.goodbytes.nl:7443/ofmeet/jitsi-meet/

Regards,

  Guus

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#3

Hi,

Yana had checked and there are missing some css styles on the local
video. The thing is that those missing styles are javascript
calculated, not loaded from css.
We suspect it is some sort of race condition or something like that,
the time when these are calculated interface_config is missing.
Is it easier to add a print after this line:
https://github.com/jitsi/jitsi-meet/blob/a9bdde193da5d57cbbd4e8c89afebe6de71544a5/modules/UI/videolayout/Filmstrip.js#L215-L215,
Printing the value of availableHeight, is it available at loading time?
But anyway this is strange, cause this should not be we think, the
case when a second participant joins, interfaceConfig is already
loaded....
This is a strange one.

Regards
damencho

···

On Tue, Apr 25, 2017 at 10:24 AM, Damian Minkov <damencho@jitsi.org> wrote:

Hi,

I don't see anything obvious at the moment, seems so strange. Will
ping someone with more css and UI render knowledge to take a look :slight_smile:

Regards
damencho

On Tue, Apr 25, 2017 at 7:46 AM, Guus der Kinderen > <guus.der.kinderen@gmail.com> wrote:

Hi guys,

I've repackaged Jitsi-Meet, Jicofo and the Videobridge, and deployed that on
my XMPP server. It appears to work out well, apart from one oddity: the
filmstrip-videos appear to be overlapping.

It's likely a silly mistake on my end, but I can't figure out what's causing
it. Could someone give me a pointer?

The instance is running (without a valid TLS certificate) here:
https://xmpp.goodbytes.nl:7443/ofmeet/jitsi-meet/

Regards,

  Guus

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#4

That could be it. interface_config.js is not a file in my setup. It is a
servlet, that gets settings from a database. That might account for
latency, which could trigger the racing condition.

I think that the problem already occurs for the first participant - the
filmstrip often is a bit ... wonky.

···

On 25 April 2017 at 21:24, Damian Minkov <damencho@jitsi.org> wrote:

Hi,

Yana had checked and there are missing some css styles on the local
video. The thing is that those missing styles are javascript
calculated, not loaded from css.
We suspect it is some sort of race condition or something like that,
the time when these are calculated interface_config is missing.
Is it easier to add a print after this line:
https://github.com/jitsi/jitsi-meet/blob/a9bdde193da5d57cbbd4e8c89afebe
6de71544a5/modules/UI/videolayout/Filmstrip.js#L215-L215,
Printing the value of availableHeight, is it available at loading time?
But anyway this is strange, cause this should not be we think, the
case when a second participant joins, interfaceConfig is already
loaded....
This is a strange one.

Regards
damencho

On Tue, Apr 25, 2017 at 10:24 AM, Damian Minkov <damencho@jitsi.org> > wrote:
> Hi,
>
> I don't see anything obvious at the moment, seems so strange. Will
> ping someone with more css and UI render knowledge to take a look :slight_smile:
>
> Regards
> damencho
>
> On Tue, Apr 25, 2017 at 7:46 AM, Guus der Kinderen > > <guus.der.kinderen@gmail.com> wrote:
>> Hi guys,
>>
>> I've repackaged Jitsi-Meet, Jicofo and the Videobridge, and deployed
that on
>> my XMPP server. It appears to work out well, apart from one oddity: the
>> filmstrip-videos appear to be overlapping.
>>
>> It's likely a silly mistake on my end, but I can't figure out what's
causing
>> it. Could someone give me a pointer?
>>
>> The instance is running (without a valid TLS certificate) here:
>> https://xmpp.goodbytes.nl:7443/ofmeet/jitsi-meet/
>>
>> Regards,
>>
>> Guus
>>
>> _______________________________________________
>> dev mailing list
>> dev@jitsi.org
>> Unsubscribe instructions and other list options:
>> http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#5

So, I've added a print, as suggested. It is live now. It prints:

DEBUG DEBUG availableHeight is %s 120

... help?

···

On 25 April 2017 at 21:46, Guus der Kinderen <guus.der.kinderen@gmail.com> wrote:

That could be it. interface_config.js is not a file in my setup. It is a
servlet, that gets settings from a database. That might account for
latency, which could trigger the racing condition.

I think that the problem already occurs for the first participant - the
filmstrip often is a bit ... wonky.

On 25 April 2017 at 21:24, Damian Minkov <damencho@jitsi.org> wrote:

Hi,

Yana had checked and there are missing some css styles on the local
video. The thing is that those missing styles are javascript
calculated, not loaded from css.
We suspect it is some sort of race condition or something like that,
the time when these are calculated interface_config is missing.
Is it easier to add a print after this line:
https://github.com/jitsi/jitsi-meet/blob/a9bdde193da5d57cbbd
4e8c89afebe6de71544a5/modules/UI/videolayout/Filmstrip.js#L215-L215,
Printing the value of availableHeight, is it available at loading time?
But anyway this is strange, cause this should not be we think, the
case when a second participant joins, interfaceConfig is already
loaded....
This is a strange one.

Regards
damencho

On Tue, Apr 25, 2017 at 10:24 AM, Damian Minkov <damencho@jitsi.org> >> wrote:
> Hi,
>
> I don't see anything obvious at the moment, seems so strange. Will
> ping someone with more css and UI render knowledge to take a look :slight_smile:
>
> Regards
> damencho
>
> On Tue, Apr 25, 2017 at 7:46 AM, Guus der Kinderen >> > <guus.der.kinderen@gmail.com> wrote:
>> Hi guys,
>>
>> I've repackaged Jitsi-Meet, Jicofo and the Videobridge, and deployed
that on
>> my XMPP server. It appears to work out well, apart from one oddity: the
>> filmstrip-videos appear to be overlapping.
>>
>> It's likely a silly mistake on my end, but I can't figure out what's
causing
>> it. Could someone give me a pointer?
>>
>> The instance is running (without a valid TLS certificate) here:
>> https://xmpp.goodbytes.nl:7443/ofmeet/jitsi-meet/
>>
>> Regards,
>>
>> Guus
>>
>> _______________________________________________
>> dev mailing list
>> dev@jitsi.org
>> Unsubscribe instructions and other list options:
>> http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#6

I hate to press - but can anyone help me out with this misalignment? I
wouldn't know where to start...

- Guus

···

On 26 April 2017 at 14:47, Guus der Kinderen <guus.der.kinderen@gmail.com> wrote:

So, I've added a print, as suggested. It is live now. It prints:

DEBUG DEBUG availableHeight is %s 120

... help?

On 25 April 2017 at 21:46, Guus der Kinderen <guus.der.kinderen@gmail.com> > wrote:

That could be it. interface_config.js is not a file in my setup. It is a
servlet, that gets settings from a database. That might account for
latency, which could trigger the racing condition.

I think that the problem already occurs for the first participant - the
filmstrip often is a bit ... wonky.

On 25 April 2017 at 21:24, Damian Minkov <damencho@jitsi.org> wrote:

Hi,

Yana had checked and there are missing some css styles on the local
video. The thing is that those missing styles are javascript
calculated, not loaded from css.
We suspect it is some sort of race condition or something like that,
the time when these are calculated interface_config is missing.
Is it easier to add a print after this line:
https://github.com/jitsi/jitsi-meet/blob/a9bdde193da5d57cbbd
4e8c89afebe6de71544a5/modules/UI/videolayout/Filmstrip.js#L215-L215,
Printing the value of availableHeight, is it available at loading time?
But anyway this is strange, cause this should not be we think, the
case when a second participant joins, interfaceConfig is already
loaded....
This is a strange one.

Regards
damencho

On Tue, Apr 25, 2017 at 10:24 AM, Damian Minkov <damencho@jitsi.org> >>> wrote:
> Hi,
>
> I don't see anything obvious at the moment, seems so strange. Will
> ping someone with more css and UI render knowledge to take a look :slight_smile:
>
> Regards
> damencho
>
> On Tue, Apr 25, 2017 at 7:46 AM, Guus der Kinderen >>> > <guus.der.kinderen@gmail.com> wrote:
>> Hi guys,
>>
>> I've repackaged Jitsi-Meet, Jicofo and the Videobridge, and deployed
that on
>> my XMPP server. It appears to work out well, apart from one oddity:
the
>> filmstrip-videos appear to be overlapping.
>>
>> It's likely a silly mistake on my end, but I can't figure out what's
causing
>> it. Could someone give me a pointer?
>>
>> The instance is running (without a valid TLS certificate) here:
>> https://xmpp.goodbytes.nl:7443/ofmeet/jitsi-meet/
>>
>> Regards,
>>
>> Guus
>>
>> _______________________________________________
>> dev mailing list
>> dev@jitsi.org
>> Unsubscribe instructions and other list options:
>> http://lists.jitsi.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev