[jitsi-dev] localStorage and multiple settings


#1

Hi,

I'm still diving into jitsi-meet and lib-jitsi-meet code, and just sent a
PR (https://github.com/jitsi/lib-jitsi-meet/pull/12)

Multiple questions:
- why not just fail when there is no localStorage? (the fallback code has
subtle bug, do we have browser without localStorage but with webrtc ?)
- shouldn't we use sessionStorage for callStatsUserName? (we are storing
data and never cleaning up)
- is it normal to have multiple Settings modules? (maybe we should rename
one to ease debugging)

Regards
Etienne


#2

We want to keep the username between refreshes and closing of the browser. Otherwise we (or rather callstats) cannot detect for example a user that fails to join a conference and for that reason tries multiple times.

About the other questions -- I don't know.

Regards,
Boris

···

On 11/02/16 01:56, Etienne Champetier wrote:

Hi,

I'm still diving into jitsi-meet and lib-jitsi-meet code, and just sent
a PR (https://github.com/jitsi/lib-jitsi-meet/pull/12)

Multiple questions:
- why not just fail when there is no localStorage? (the fallback code
has subtle bug, do we have browser without localStorage but with webrtc ?)
- shouldn't we use sessionStorage for callStatsUserName? (we are storing
data and never cleaning up)


#3

Hi,

Hi,

I'm still diving into jitsi-meet and lib-jitsi-meet code, and just sent
a PR (https://github.com/jitsi/lib-jitsi-meet/pull/12)

Multiple questions:
- why not just fail when there is no localStorage? (the fallback code
has subtle bug, do we have browser without localStorage but with webrtc

?)

- shouldn't we use sessionStorage for callStatsUserName? (we are storing
data and never cleaning up)

We want to keep the username between refreshes and closing of the

browser. Otherwise we (or rather callstats) cannot detect for example a
user that fails to join a conference and for that reason tries multiple
times.

Does it need to be different for each conference?

···

Le 11 févr. 2016 17:54, "Boris Grozev" <boris@jitsi.org> a écrit :

On 11/02/16 01:56, Etienne Champetier wrote:

About the other questions -- I don't know.

Regards,
Boris

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#4

I don't think this is a requirement.

Regards,
Boris

···

On 11/02/16 12:08, Etienne Champetier wrote:

Hi,

Le 11 févr. 2016 17:54, "Boris Grozev" <boris@jitsi.org > <mailto:boris@jitsi.org>> a écrit :
>
> On 11/02/16 01:56, Etienne Champetier wrote:
>>
>> Hi,
>>
>> I'm still diving into jitsi-meet and lib-jitsi-meet code, and just sent
>> a PR (https://github.com/jitsi/lib-jitsi-meet/pull/12)
>>
>> Multiple questions:
>> - why not just fail when there is no localStorage? (the fallback code
>> has subtle bug, do we have browser without localStorage but with
webrtc ?)
>> - shouldn't we use sessionStorage for callStatsUserName? (we are storing
>> data and never cleaning up)
>
> We want to keep the username between refreshes and closing of the
browser. Otherwise we (or rather callstats) cannot detect for example a
user that fails to join a conference and for that reason tries multiple
times.

Does it need to be different for each conference?