[jitsi-dev] localStorage and multiple settings (authenticated conference bugs)


#1

Hi again,

Hi,

I'm still diving into jitsi-meet and lib-jitsi-meet code, and just sent a
PR (https://github.com/jitsi/lib-jitsi-meet/pull/12)

Multiple questions:
- why not just fail when there is no localStorage? (the fallback code has
subtle bug, do we have browser without localStorage but with webrtc ?)
- shouldn't we use sessionStorage for callStatsUserName? (we are storing
data and never cleaning up)
- is it normal to have multiple Settings modules? (maybe we should rename
one to ease debugging)

Regards
Etienne

My PR doesn't fix it all, jicofo check if machineuid (jitsiMeetId) in
session == machineuid,
but in browser jitsiMeetId is stored per room (in localStorage), and
sessionId is stored globally (in localStorage),
so when you switch room you keep same sessionId but change machineuid

Also we always keep same sessionId as it's in localStorage and not
sessionStorage

I see in this commit
https://github.com/jitsi/lib-jitsi-meet/commit/e5ee21b19b5527996da748f746d3f8edc78a7702
that @damencho removed email and language, but not displayName ?

I also see some request to "/http-bind?room=zsefsfsfs?room=undefined" (the
request with the authenticated user), maybe caused by
https://github.com/champtar/jitsi-meet/commit/b4b9160fcb7468953a50eabd58cdd25149d1664a

Is someone looking into authenticated conference in the jitsi team? (there
is at least 2 other users affected on the user mailing list)

Regards
Etienne

ยทยทยท

2016-02-11 8:56 GMT+01:00 Etienne Champetier <champetier.etienne@gmail.com>: