[jitsi-dev] Little patch for "operation not supported" and a question


#1

Hello, my name is Jose Sanchez, I am new at this list. First of all I want to say that I don't know very much about sip-communicator, I have been using it for a couple of months but I am not an expert.

The thing is that I received an "Operation not supported" when I called using sip-communicator to other sip-communicator and asterisk as a server in the middle with the mediatype "text" extension enabled. This happens using the plugin for SIP.

It seems that sip-communicator only supports AUDIO and VIDEO mediatypes. In order to make possible this connection I had to made a tiny modification to your code to silently discard those text messages.

Attached to this email you can find the patch, I hope that it will be useful for somebody. It is also possible modify the code to add a conversation window instead of just discarding the text mediatype.

Now a little question: I am having some troubles with the H263p and H264 codecs. For me, H263p does not work (I tested the "trunk" version of this Friday, maybe another version will work?) and H264 seems to have some issues with some hardware-based phones, I have tried several things but the video always has some problems with movement. Is the codec that you use implementing all the "functions"/features?, the problem seems to be at decoding the video, so it seems that the codec is not able to decode properly the frames (unless is a keyframe) Does anyone knows where to find more (internal) information about these codecs?.

I have also seen that in Windows Vista you have an issue obtaining the local IP address. I have commented that piece of code and it seems to work now. Do you have a bugzilla or only the "issues" mail list?

Thank you and excuse me if my simple patch does not follow your code guidelines.

sip-text.patch (1.87 KB)


#2

Now a little question: I am having some troubles with the H263p and H264
codecs. For me, H263p does not work (I tested the "trunk" version of this
Friday, maybe another version will work?) and H264 seems to have some issues
with some hardware-based phones, I have tried several things but the video
always has some problems with movement. Is the codec that you use
implementing all the "functions"/features?, the problem seems to be at
decoding the video, so it seems that the codec is not able to decode
properly the frames (unless is a keyframe) Does anyone knows where to find
more (internal) information about these codecs?.

SIP Communicator implements H.263/4 using FFmpeg. The respective
source code on the side of SIP Communicator can be found in
src/net/java/sip/communicator/impl/neomedia/codec/video. As to FFmpeg,
please refer to http://ffmpeg.org/.

I have also seen that in Windows Vista you have an issue obtaining the local
IP address. I have commented that piece of code and it seems to work now. Do
you have a bugzilla or only the "issues" mail list?

http://www.sip-communicator.org/index.php/Development/BugsAndIssues

Please note the IMPORTANT there: "Please, do not create or modify
tickets in the issue tracker before discussing them on our dev mailing
list. Thanks a million!"

···

On Mon, Feb 28, 2011 at 12:45 PM, Jose Sanchez <jose@serhost.com> wrote:


#3

Hey Jose,

Sorry for replying that late.

Please see inline.

На 28.02.11 11:45, Jose Sanchez написа:

Hello, my name is Jose Sanchez, I am new at this list. First of all I
want to say that I don't know very much about sip-communicator, I have
been using it for a couple of months but I am not an expert.

The thing is that I received an "Operation not supported" when I called
using sip-communicator to other sip-communicator and asterisk as a
server in the middle with the mediatype "text" extension enabled. This
happens using the plugin for SIP.

It seems that sip-communicator only supports AUDIO and VIDEO
mediatypes.

It does indeed.

In order to make possible this connection I had to made a
tiny modification to your code to silently discard those text messages.

Attached to this email you can find the patch, I hope that it will be
useful for somebody.

Thanks! Simply discarding the media type however is not exactly the
right way to handle media types we don't support. We should let the
other party know that we are rejecting the corresponding stream:

RFC 3264 Section 6:

   To reject an offered
   stream, the port number in the corresponding stream in the answer
   MUST be set to zero. Any media formats listed are ignored. At least
   one MUST be present, as specified by SDP.

Would you be interested in adding this modification to your patch?

Otherwise could you please open an issue and we'll handle it as time
permits?

Thanks,
Emil

···

It is also possible modify the code to add a
conversation window instead of just discarding the text mediatype.

Now a little question: I am having some troubles with the H263p and
H264 codecs. For me, H263p does not work (I tested the "trunk" version
of this Friday, maybe another version will work?) and H264 seems to have
some issues with some hardware-based phones, I have tried several things
but the video always has some problems with movement. Is the codec that
you use implementing all the "functions"/features?, the problem seems to
be at decoding the video, so it seems that the codec is not able to
decode properly the frames (unless is a keyframe) Does anyone knows
where to find more (internal) information about these codecs?.

I have also seen that in Windows Vista you have an issue obtaining the
local IP address. I have commented that piece of code and it seems to
work now. Do you have a bugzilla or only the "issues" mail list?

Thank you and excuse me if my simple patch does not follow your code
guidelines.

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31


#4

Hey Jose,

На 06.03.11 17:48, Emil Ivov написа:

Thanks! Simply discarding the media type however is not exactly the
right way to handle media types we don't support. We should let the
other party know that we are rejecting the corresponding stream:

r8345 and build 3336 should be fixing the issue.

Thanks for reporting it!
Emil

···

RFC 3264 Section 6:

   To reject an offered
   stream, the port number in the corresponding stream in the answer
   MUST be set to zero. Any media formats listed are ignored. At least
   one MUST be present, as specified by SDP.

Would you be interested in adding this modification to your patch?

Otherwise could you please open an issue and we'll handle it as time
permits?

Thanks,
Emil

It is also possible modify the code to add a
conversation window instead of just discarding the text mediatype.

Now a little question: I am having some troubles with the H263p and
H264 codecs. For me, H263p does not work (I tested the "trunk" version
of this Friday, maybe another version will work?) and H264 seems to have
some issues with some hardware-based phones, I have tried several things
but the video always has some problems with movement. Is the codec that
you use implementing all the "functions"/features?, the problem seems to
be at decoding the video, so it seems that the codec is not able to
decode properly the frames (unless is a keyframe) Does anyone knows
where to find more (internal) information about these codecs?.

I have also seen that in Windows Vista you have an issue obtaining the
local IP address. I have commented that piece of code and it seems to
work now. Do you have a bugzilla or only the "issues" mail list?

Thank you and excuse me if my simple patch does not follow your code
guidelines.

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31