Hi,
I am preparing a patch for including all certificates sent by the server
in the X509CertificatePanel. See attached screenshots with before and
after pictures.
A new tree view is added where the different certificates in the chain
can be selected. Note: My changes only affects what's inside the
scrollpane / certificate area and not other parts of the dialog.
Any comments?
Regards,
Markus
Hey
I am preparing a patch for including all certificates sent by the server
in the X509CertificatePanel. See attached screenshots with before and
after pictures.
This is great! Much appreciated!
A new tree view is added where the different certificates in the chain
can be selected. Note: My changes only affects what's inside the
scrollpane / certificate area and not other parts of the dialog.Any comments?
Do you think it would be possible to separate the tree-view a bit better
from the actual content? Right now, I think it's not clear at first sight
that you can actually select the different nodes. Maybe putting the tree
outside of the scroll pane would already accomplish this.
(My first idea for this was to use a tab panel and a tab for each cert, but
the tree is actually better.)
Regards,
Markus
Ingo
Hey
I am preparing a patch for including all certificates sent by the server
in the X509CertificatePanel. See attached screenshots with before and
after pictures.This is great! Much appreciated!
A new tree view is added where the different certificates in the chain
can be selected. Note: My changes only affects what's inside the
scrollpane / certificate area and not other parts of the dialog.Any comments?
Do you think it would be possible to separate the tree-view a bit better
from the actual content? Right now, I think it's not clear at first sight
that you can actually select the different nodes. Maybe putting the tree
outside of the scroll pane would already accomplish this.(My first idea for this was to use a tab panel and a tab for each cert, but
the tree is actually better.)
Yes, I was briefly considering putting the tree outside the scroll pane.
Problem is that the scrollpane is implemented in the dialog and not in
the X509CertificatePanel. However, maybe that could simply be refactored
so it is moved into the X509CertificatePanel. That way the tree view
could be put north of it. I will look into it.
Cheers,
Markus
On 2014-05-02 17:40, Ingo Bauersachs wrote:
Regards,
MarkusIngo
_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev
Hey
I am preparing a patch for including all certificates sent by the server
in the X509CertificatePanel. See attached screenshots with before and
after pictures.This is great! Much appreciated!
A new tree view is added where the different certificates in the chain
can be selected. Note: My changes only affects what's inside the
scrollpane / certificate area and not other parts of the dialog.Any comments?
Do you think it would be possible to separate the tree-view a bit better
from the actual content? Right now, I think it's not clear at first sight
that you can actually select the different nodes. Maybe putting the tree
outside of the scroll pane would already accomplish this.(My first idea for this was to use a tab panel and a tab for each cert, but
the tree is actually better.)Yes, I was briefly considering putting the tree outside the scroll pane.
Problem is that the scrollpane is implemented in the dialog and not in
the X509CertificatePanel. However, maybe that could simply be refactored
so it is moved into the X509CertificatePanel. That way the tree view
could be put north of it. I will look into it.
Now in the attached screenshot the scrollpane is only around the
certificate content pane and the tree with the certificate chain is
displayed with a border around.
There is also a proper margin around the certificate panel.
Regards,
Markus
On 2014-05-02 17:52, Markus Kil�s wrote:
On 2014-05-02 17:40, Ingo Bauersachs wrote:
Cheers,
MarkusRegards,
MarkusIngo
_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev
Now in the attached screenshot the scrollpane is only around the
certificate content pane and the tree with the certificate chain is
displayed with a border around.
There is also a proper margin around the certificate panel.
That's great! Looking forward to your pull request.
Regards,
Markus
Ingo
Now in the attached screenshot the scrollpane is only around the
certificate content pane and the tree with the certificate chain is
displayed with a border around.
There is also a proper margin around the certificate panel.That's great! Looking forward to your pull request.
The certificate panel changes depends on the changes I made earlier for
displaying the TLS information in the Account Info frame which doesn't
seem to have been merged yet:
https://github.com/jitsi/jitsi/pull/26
I'll have to wait for that one before submitting the pull request.
Cheers,
Markus
On 2014-05-10 19:57, Ingo Bauersachs wrote:
Regards,
MarkusIngo
_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev
Now in the attached screenshot the scrollpane is only around the
certificate content pane and the tree with the certificate chain is
displayed with a border around.
There is also a proper margin around the certificate panel.That's great! Looking forward to your pull request.
The certificate panel changes depends on the changes I made earlier for
displaying the TLS information in the Account Info frame which doesn't
seem to have been merged yet: https://github.com/jitsi/jitsi/pull/26I'll have to wait for that one before submitting the pull request.
Emil: can you please comment on the screenshots?
https://github.com/jitsi/jitsi/pull/26#discussion_r11798860
Markus: Can you please rebase the pull-request against the current master?
Cheers,
Markus
Ingo
On 2014-05-10 19:57, Ingo Bauersachs wrote:
Talked with Yana and she'd rather avoid the tabs. Can we just add that at the bottom of the existing list? It also seems like many of the options can be grouped in a single line.
Markus, thanks for your contribution and thanks Ingo for shepherding it!
Emil
On 16.05.14, 23:30, Ingo Bauersachs wrote:
On 2014-05-10 19:57, Ingo Bauersachs wrote:
Now in the attached screenshot the scrollpane is only around the
certificate content pane and the tree with the certificate chain is
displayed with a border around.
There is also a proper margin around the certificate panel.That's great! Looking forward to your pull request.
The certificate panel changes depends on the changes I made earlier for
displaying the TLS information in the Account Info frame which doesn't
seem to have been merged yet: https://github.com/jitsi/jitsi/pull/26I'll have to wait for that one before submitting the pull request.
Emil: can you please comment on the screenshots?
https://github.com/jitsi/jitsi/pull/26#discussion_r11798860
Emil: can you please comment on the screenshots?
https://github.com/jitsi/jitsi/pull/26#discussion_r11798860Talked with Yana and she'd rather avoid the tabs. Can we just add that
at the bottom of the existing list? It also seems like many of the
options can be grouped in a single line.
What's the issue with tabs? There's an apply button which suggests that most
of the stuff there should be editable (at least if the server supports it).
Mixing contact/account details with connection info seems weird.
What about putting it into a separate window, to be opened by a menu entry
below "Help"? Could even be in the main windows' help menu too:
Help
Connection details -> Account 1
-> Account 2
...
Markus, thanks for your contribution and thanks Ingo for shepherding it!
Emil
Ingo
Emil: can you please comment on the screenshots?
https://github.com/jitsi/jitsi/pull/26#discussion_r11798860Talked with Yana and she'd rather avoid the tabs. Can we just add that
at the bottom of the existing list? It also seems like many of the
options can be grouped in a single line.What's the issue with tabs?
Mostly aesthetic I guess. Makes the GUI look busy. (Yes I realise this is subjective but if we agree that Yana is the GUI Tzar then we could possibly defer this to her judgement)
There's an apply button which suggests that most
of the stuff there should be editable (at least if the server supports it).
Well ... apply would apply what's appliable (i.e. editable) ... but I do see why this makes you uncomfortable.
Mixing contact/account details with connection info seems weird.
This bothers me less than the above actually, and besides, they are both in the smae window that pops when opening "account info" so, tabs or not, we are still mixing it.
What about putting it into a separate window, to be opened by a menu entry
below "Help"? Could even be in the main windows' help menu too:Help
Connection details -> Account 1
-> Account 2
...
This would work for me. I just think I'd rather have this in Tools than Help ... but I won't insist.
Emil
On 18.05.14, 01:33, Ingo Bauersachs wrote:
Markus, thanks for your contribution and thanks Ingo for shepherding it!
Emil
Ingo
_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev
(My Office365 somehow didn't want to accept Emil's mail from the list...)
Emil: can you please comment on the screenshots?
https://github.com/jitsi/jitsi/pull/26#discussion_r11798860Talked with Yana and she'd rather avoid the tabs. Can we just add that
at the bottom of the existing list? It also seems like many of the
options can be grouped in a single line.What's the issue with tabs?
Mostly aesthetic I guess. Makes the GUI look busy. (Yes I realise this
is subjective but if we agree that Yana is the GUI Tzar then we could
possibly defer this to her judgement)There's an apply button which suggests that most
of the stuff there should be editable (at least if the server supports
it).
Well ... apply would apply what's appliable (i.e. editable) ... but I do
see why this makes you uncomfortable.Mixing contact/account details with connection info seems weird.
This bothers me less than the above actually, and besides, they are both
in the smae window that pops when opening "account info" so, tabs or
not, we are still mixing it.What about putting it into a separate window, to be opened by a menu
entry
below "Help"? Could even be in the main windows' help menu too:
Help
Connection details -> Account 1
-> Account 2
...This would work for me. I just think I'd rather have this in Tools than
Help ... but I won't insist.
Markus, what do you think: Creating a new window that is basically the same
as the current account details, to be opened through Tools->Connection
information.
No tabs, no mixing with account settings/apply, no submenus, less
modification of existing code.
Emil
Ingo
On 18.05.14, 01:33, Ingo Bauersachs wrote:
(My Office365 somehow didn't want to accept Emil's mail from the list...)
Emil: can you please comment on the screenshots?
https://github.com/jitsi/jitsi/pull/26#discussion_r11798860Talked with Yana and she'd rather avoid the tabs. Can we just add that
at the bottom of the existing list? It also seems like many of the
options can be grouped in a single line.What's the issue with tabs?
Mostly aesthetic I guess. Makes the GUI look busy. (Yes I realise this
is subjective but if we agree that Yana is the GUI Tzar then we could
possibly defer this to her judgement)There's an apply button which suggests that most
of the stuff there should be editable (at least if the server supportsit).
Well ... apply would apply what's appliable (i.e. editable) ... but I do
see why this makes you uncomfortable.Mixing contact/account details with connection info seems weird.
This bothers me less than the above actually, and besides, they are both
in the smae window that pops when opening "account info" so, tabs or
not, we are still mixing it.What about putting it into a separate window, to be opened by a menu
entry
below "Help"? Could even be in the main windows' help menu too:
Help
Connection details -> Account 1
-> Account 2
...This would work for me. I just think I'd rather have this in Tools than
Help ... but I won't insist.Markus, what do you think: Creating a new window that is basically the same
as the current account details, to be opened through Tools->Connection
information.No tabs, no mixing with account settings/apply, no submenus, less
modification of existing code.
Yes, that sounds much more like the correct design.
// Markus
On 2014-05-18 21:19, Ingo Bauersachs wrote:
On 18.05.14, 01:33, Ingo Bauersachs wrote:
Emil
Ingo
_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev
(My Office365 somehow didn't want to accept Emil's mail from the list...)
Emil: can you please comment on the screenshots?
https://github.com/jitsi/jitsi/pull/26#discussion_r11798860Talked with Yana and she'd rather avoid the tabs. Can we just add that
at the bottom of the existing list? It also seems like many of the
options can be grouped in a single line.What's the issue with tabs?
Mostly aesthetic I guess. Makes the GUI look busy. (Yes I realise this
is subjective but if we agree that Yana is the GUI Tzar then we could
possibly defer this to her judgement)There's an apply button which suggests that most
of the stuff there should be editable (at least if the server supportsit).
Well ... apply would apply what's appliable (i.e. editable) ... but I do
see why this makes you uncomfortable.Mixing contact/account details with connection info seems weird.
This bothers me less than the above actually, and besides, they are both
in the smae window that pops when opening "account info" so, tabs or
not, we are still mixing it.What about putting it into a separate window, to be opened by a menu
entry
below "Help"? Could even be in the main windows' help menu too:
Help
Connection details -> Account 1
-> Account 2
...This would work for me. I just think I'd rather have this in Tools than
Help ... but I won't insist.Markus, what do you think: Creating a new window that is basically the same
as the current account details, to be opened through Tools->Connection
information.No tabs, no mixing with account settings/apply, no submenus, less
modification of existing code.Yes, that sounds much more like the correct design.
// Markus
I have now submitted a new pull request where the connection information
is displayed in its own frame as suggested:
https://github.com/jitsi/jitsi/pull/32
// Markus
On 2014-05-18 21:25, Markus Kil�s wrote:
On 2014-05-18 21:19, Ingo Bauersachs wrote:
On 18.05.14, 01:33, Ingo Bauersachs wrote:
Emil
Ingo
_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev
Thanks Markus! Always appreciated!
Now that Ingo is off we'd just need to find someone to review that. Yana, would you have time to have a look? Anyoen else?
On 30.05.14, 19:28, Markus Kil�s wrote:
On 2014-05-18 21:25, Markus Kil�s wrote:
On 2014-05-18 21:19, Ingo Bauersachs wrote:
(My Office365 somehow didn't want to accept Emil's mail from the list...)
On 18.05.14, 01:33, Ingo Bauersachs wrote:
Emil: can you please comment on the screenshots?
https://github.com/jitsi/jitsi/pull/26#discussion_r11798860Talked with Yana and she'd rather avoid the tabs. Can we just add that
at the bottom of the existing list? It also seems like many of the
options can be grouped in a single line.What's the issue with tabs?
Mostly aesthetic I guess. Makes the GUI look busy. (Yes I realise this
is subjective but if we agree that Yana is the GUI Tzar then we could
possibly defer this to her judgement)There's an apply button which suggests that most
of the stuff there should be editable (at least if the server supportsit).
Well ... apply would apply what's appliable (i.e. editable) ... but I do
see why this makes you uncomfortable.Mixing contact/account details with connection info seems weird.
This bothers me less than the above actually, and besides, they are both
in the smae window that pops when opening "account info" so, tabs or
not, we are still mixing it.What about putting it into a separate window, to be opened by a menu
entry
below "Help"? Could even be in the main windows' help menu too:
Help
Connection details -> Account 1
-> Account 2
...This would work for me. I just think I'd rather have this in Tools than
Help ... but I won't insist.Markus, what do you think: Creating a new window that is basically the same
as the current account details, to be opened through Tools->Connection
information.No tabs, no mixing with account settings/apply, no submenus, less
modification of existing code.Yes, that sounds much more like the correct design.
// Markus
I have now submitted a new pull request where the connection information
is displayed in its own frame as suggested:
https://github.com/jitsi/jitsi/pull/32// Markus
Emil
Ingo
_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev
Hey
I can get online from time to time, and Markus' code looks fine in the diff
on Github. However, I don't have a dev env with me, so if someone could just
do a test build, then I think it can be merged.
Btw: an easy way to do that is to checkout the pull request using Git:
https://help.github.com/articles/checking-out-pull-requests-locally
Ingo
-----Original Message-----
From: dev-bounces@jitsi.org [mailto:dev-bounces@jitsi.org] On Behalf Of Emil
Ivov
Sent: Samstag, 31. Mai 2014 15:29
To: dev@jitsi.org
Subject: Re: [jitsi-dev] List all certificates in X509CertificatePanel
Thanks Markus! Always appreciated!
Now that Ingo is off we'd just need to find someone to review that.
Yana, would you have time to have a look? Anyoen else?
On 30.05.14, 19:28, Markus Kilås wrote:
On 2014-05-18 21:25, Markus Kilås wrote:
On 2014-05-18 21:19, Ingo Bauersachs wrote:
(My Office365 somehow didn't want to accept Emil's mail from the
list...)On 18.05.14, 01:33, Ingo Bauersachs wrote:
Emil: can you please comment on the screenshots?
https://github.com/jitsi/jitsi/pull/26#discussion_r11798860Talked with Yana and she'd rather avoid the tabs. Can we just add
that at the bottom of the existing list? It also seems like many
of the options can be grouped in a single line.What's the issue with tabs?
Mostly aesthetic I guess. Makes the GUI look busy. (Yes I realise
this is subjective but if we agree that Yana is the GUI Tzar then
we could possibly defer this to her judgement)There's an apply button which suggests that most of the stuff
there should be editable (at least if the server supportsit).
Well ... apply would apply what's appliable (i.e. editable) ... but
I do see why this makes you uncomfortable.Mixing contact/account details with connection info seems weird.
This bothers me less than the above actually, and besides, they are
both in the smae window that pops when opening "account info" so,
tabs or not, we are still mixing it.What about putting it into a separate window, to be opened by a
menuentry
below "Help"? Could even be in the main windows' help menu too:
Help
Connection details -> Account 1
-> Account 2
...This would work for me. I just think I'd rather have this in Tools
than Help ... but I won't insist.Markus, what do you think: Creating a new window that is basically
the same as the current account details, to be opened through
Tools->Connection information.No tabs, no mixing with account settings/apply, no submenus, less
modification of existing code.Yes, that sounds much more like the correct design.
// Markus
I have now submitted a new pull request where the connection
information is displayed in its own frame as suggested:
https://github.com/jitsi/jitsi/pull/32// Markus
Emil
Ingo
_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev
Hi,
the changes have been merged, committed and acked.
Thanks
damencho
On Sat, May 31, 2014 at 11:03 AM, Ingo Bauersachs <ingo@jitsi.org> wrote:
Hey
I can get online from time to time, and Markus' code looks fine in the diff
on Github. However, I don't have a dev env with me, so if someone could just
do a test build, then I think it can be merged.Btw: an easy way to do that is to checkout the pull request using Git:
https://help.github.com/articles/checking-out-pull-requests-locallyIngo
-----Original Message-----
From: dev-bounces@jitsi.org [mailto:dev-bounces@jitsi.org] On Behalf Of Emil
Ivov
Sent: Samstag, 31. Mai 2014 15:29
To: dev@jitsi.org
Subject: Re: [jitsi-dev] List all certificates in X509CertificatePanelThanks Markus! Always appreciated!
Now that Ingo is off we'd just need to find someone to review that.
Yana, would you have time to have a look? Anyoen else?On 30.05.14, 19:28, Markus Kilås wrote:
On 2014-05-18 21:25, Markus Kilås wrote:
On 2014-05-18 21:19, Ingo Bauersachs wrote:
(My Office365 somehow didn't want to accept Emil's mail from the
list...)On 18.05.14, 01:33, Ingo Bauersachs wrote:
Emil: can you please comment on the screenshots?
https://github.com/jitsi/jitsi/pull/26#discussion_r11798860Talked with Yana and she'd rather avoid the tabs. Can we just add
that at the bottom of the existing list? It also seems like many
of the options can be grouped in a single line.What's the issue with tabs?
Mostly aesthetic I guess. Makes the GUI look busy. (Yes I realise
this is subjective but if we agree that Yana is the GUI Tzar then
we could possibly defer this to her judgement)There's an apply button which suggests that most of the stuff
there should be editable (at least if the server supportsit).
Well ... apply would apply what's appliable (i.e. editable) ... but
I do see why this makes you uncomfortable.Mixing contact/account details with connection info seems weird.
This bothers me less than the above actually, and besides, they are
both in the smae window that pops when opening "account info" so,
tabs or not, we are still mixing it.What about putting it into a separate window, to be opened by a
menuentry
below "Help"? Could even be in the main windows' help menu too:
Help
Connection details -> Account 1
-> Account 2
...This would work for me. I just think I'd rather have this in Tools
than Help ... but I won't insist.Markus, what do you think: Creating a new window that is basically
the same as the current account details, to be opened through
Tools->Connection information.No tabs, no mixing with account settings/apply, no submenus, less
modification of existing code.Yes, that sounds much more like the correct design.
// Markus
I have now submitted a new pull request where the connection
information is displayed in its own frame as suggested:
https://github.com/jitsi/jitsi/pull/32// Markus
Emil
Ingo
_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev
Hi,
Has anyone had time to do a test build yet?
Cheers,
Marku
On 2014-05-31 10:03, Ingo Bauersachs wrote:
Hey
I can get online from time to time, and Markus' code looks fine in the diff
on Github. However, I don't have a dev env with me, so if someone could just
do a test build, then I think it can be merged.Btw: an easy way to do that is to checkout the pull request using Git:
https://help.github.com/articles/checking-out-pull-requests-locallyIngo
-----Original Message-----
From: dev-bounces@jitsi.org [mailto:dev-bounces@jitsi.org] On Behalf Of Emil
Ivov
Sent: Samstag, 31. Mai 2014 15:29
To: dev@jitsi.org
Subject: Re: [jitsi-dev] List all certificates in X509CertificatePanelThanks Markus! Always appreciated!
Now that Ingo is off we'd just need to find someone to review that.
Yana, would you have time to have a look? Anyoen else?On 30.05.14, 19:28, Markus Kil�s wrote:
On 2014-05-18 21:25, Markus Kil�s wrote:
On 2014-05-18 21:19, Ingo Bauersachs wrote:
(My Office365 somehow didn't want to accept Emil's mail from the
list...)On 18.05.14, 01:33, Ingo Bauersachs wrote:
Emil: can you please comment on the screenshots?
https://github.com/jitsi/jitsi/pull/26#discussion_r11798860Talked with Yana and she'd rather avoid the tabs. Can we just add
that at the bottom of the existing list? It also seems like many
of the options can be grouped in a single line.What's the issue with tabs?
Mostly aesthetic I guess. Makes the GUI look busy. (Yes I realise
this is subjective but if we agree that Yana is the GUI Tzar then
we could possibly defer this to her judgement)There's an apply button which suggests that most of the stuff
there should be editable (at least if the server supportsit).
Well ... apply would apply what's appliable (i.e. editable) ... but
I do see why this makes you uncomfortable.Mixing contact/account details with connection info seems weird.
This bothers me less than the above actually, and besides, they are
both in the smae window that pops when opening "account info" so,
tabs or not, we are still mixing it.What about putting it into a separate window, to be opened by a
menuentry
below "Help"? Could even be in the main windows' help menu too:
Help
Connection details -> Account 1
-> Account 2
...This would work for me. I just think I'd rather have this in Tools
than Help ... but I won't insist.Markus, what do you think: Creating a new window that is basically
the same as the current account details, to be opened through
Tools->Connection information.No tabs, no mixing with account settings/apply, no submenus, less
modification of existing code.Yes, that sounds much more like the correct design.
// Markus
I have now submitted a new pull request where the connection
information is displayed in its own frame as suggested:
https://github.com/jitsi/jitsi/pull/32// Markus
Emil
Ingo
_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev
Hi,
It is in the repo. Check out latest nightly.
Regards
damencho
On Jul 11, 2014 7:22 PM, "Markus Kilås" <subjunctive.post@gmail.com> wrote:
Hi,
Has anyone had time to do a test build yet?
Cheers,
MarkuOn 2014-05-31 10:03, Ingo Bauersachs wrote:
> Hey
>
> I can get online from time to time, and Markus' code looks fine in the
diff
> on Github. However, I don't have a dev env with me, so if someone could
just
> do a test build, then I think it can be merged.
>
> Btw: an easy way to do that is to checkout the pull request using Git:
> https://help.github.com/articles/checking-out-pull-requests-locally
>
> Ingo
>
> -----Original Message-----
> From: dev-bounces@jitsi.org [mailto:dev-bounces@jitsi.org] On Behalf Of
Emil
> Ivov
> Sent: Samstag, 31. Mai 2014 15:29
> To: dev@jitsi.org
> Subject: Re: [jitsi-dev] List all certificates in X509CertificatePanel
>
> Thanks Markus! Always appreciated!
>
> Now that Ingo is off we'd just need to find someone to review that.
> Yana, would you have time to have a look? Anyoen else?
>
> On 30.05.14, 19:28, Markus Kilås wrote:
>> On 2014-05-18 21:25, Markus Kilås wrote:
>>> On 2014-05-18 21:19, Ingo Bauersachs wrote:
>>>> (My Office365 somehow didn't want to accept Emil's mail from the
>>>> list...)
>>>>
>>>>> On 18.05.14, 01:33, Ingo Bauersachs wrote:
>>>>>>>> Emil: can you please comment on the screenshots?
>>>>>>>> https://github.com/jitsi/jitsi/pull/26#discussion_r11798860
>>>>>>> Talked with Yana and she'd rather avoid the tabs. Can we just add
>>>>>>> that at the bottom of the existing list? It also seems like many
>>>>>>> of the options can be grouped in a single line.
>>>>>> What's the issue with tabs?
>>>>> Mostly aesthetic I guess. Makes the GUI look busy. (Yes I realise
>>>>> this is subjective but if we agree that Yana is the GUI Tzar then
>>>>> we could possibly defer this to her judgement)
>>>>>
>>>>>> There's an apply button which suggests that most of the stuff
>>>>>> there should be editable (at least if the server supports
>>>> it).
>>>>> Well ... apply would apply what's appliable (i.e. editable) ... but
>>>>> I do see why this makes you uncomfortable.
>>>>>
>>>>>> Mixing contact/account details with connection info seems weird.
>>>>> This bothers me less than the above actually, and besides, they are
>>>>> both in the smae window that pops when opening "account info" so,
>>>>> tabs or not, we are still mixing it.
>>>>>
>>>>>> What about putting it into a separate window, to be opened by a
>>>>>> menu
>>>> entry
>>>>>> below "Help"? Could even be in the main windows' help menu too:
>>>>>> Help
>>>>>> Connection details -> Account 1
>>>>>> -> Account 2
>>>>>> ...
>>>>>>
>>>>> This would work for me. I just think I'd rather have this in Tools
>>>>> than Help ... but I won't insist.
>>>> Markus, what do you think: Creating a new window that is basically
>>>> the same as the current account details, to be opened through
>>>> Tools->Connection information.
>>>>
>>>> No tabs, no mixing with account settings/apply, no submenus, less
>>>> modification of existing code.
>>> Yes, that sounds much more like the correct design.
>>>
>>> // Markus
>>
>> I have now submitted a new pull request where the connection
>> information is displayed in its own frame as suggested:
>> https://github.com/jitsi/jitsi/pull/32
>>
>> // Markus
>>
>>>
>>>>> Emil
>>>> Ingo
>>>>
>>>>
>>>> _______________________________________________
>>>> dev mailing list
>>>> dev@jitsi.org
>>>> Unsubscribe instructions and other list options:
>>>> http://lists.jitsi.org/mailman/listinfo/dev
>>
>>
>> _______________________________________________
>> dev mailing list
>> dev@jitsi.org
>> Unsubscribe instructions and other list options:
>> http://lists.jitsi.org/mailman/listinfo/dev
>>
>
> --
> https://jitsi.org
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev
>
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev
>_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev
I think Damian has merged the changes into master about a week ago? (But not via the pull request, can you or Damian please close it?)
Freundliche Grüsse,
Ingo Bauersachs
-- sent from my mobile
Le 11.07.2014 à 23:22, "Markus Kilås" <subjunctive.post@gmail.com> a écrit :
Hi,
Has anyone had time to do a test build yet?
Cheers,
MarkuOn 2014-05-31 10:03, Ingo Bauersachs wrote:
HeyI can get online from time to time, and Markus' code looks fine in the diff
on Github. However, I don't have a dev env with me, so if someone could just
do a test build, then I think it can be merged.Btw: an easy way to do that is to checkout the pull request using Git:
https://help.github.com/articles/checking-out-pull-requests-locallyIngo
-----Original Message-----
From: dev-bounces@jitsi.org [mailto:dev-bounces@jitsi.org] On Behalf Of Emil
Ivov
Sent: Samstag, 31. Mai 2014 15:29
To: dev@jitsi.org
Subject: Re: [jitsi-dev] List all certificates in X509CertificatePanelThanks Markus! Always appreciated!
Now that Ingo is off we'd just need to find someone to review that.
Yana, would you have time to have a look? Anyoen else?On 30.05.14, 19:28, Markus Kilås wrote:
On 2014-05-18 21:25, Markus Kilås wrote:
On 2014-05-18 21:19, Ingo Bauersachs wrote:
(My Office365 somehow didn't want to accept Emil's mail from the
list...)On 18.05.14, 01:33, Ingo Bauersachs wrote:
Emil: can you please comment on the screenshots?
https://github.com/jitsi/jitsi/pull/26#discussion_r11798860Talked with Yana and she'd rather avoid the tabs. Can we just add
that at the bottom of the existing list? It also seems like many
of the options can be grouped in a single line.What's the issue with tabs?
Mostly aesthetic I guess. Makes the GUI look busy. (Yes I realise
this is subjective but if we agree that Yana is the GUI Tzar then
we could possibly defer this to her judgement)There's an apply button which suggests that most of the stuff
there should be editable (at least if the server supportsit).
Well ... apply would apply what's appliable (i.e. editable) ... but
I do see why this makes you uncomfortable.Mixing contact/account details with connection info seems weird.
This bothers me less than the above actually, and besides, they are
both in the smae window that pops when opening "account info" so,
tabs or not, we are still mixing it.What about putting it into a separate window, to be opened by a
menuentry
below "Help"? Could even be in the main windows' help menu too:
Help
Connection details -> Account 1
-> Account 2
...This would work for me. I just think I'd rather have this in Tools
than Help ... but I won't insist.Markus, what do you think: Creating a new window that is basically
the same as the current account details, to be opened through
Tools->Connection information.No tabs, no mixing with account settings/apply, no submenus, less
modification of existing code.Yes, that sounds much more like the correct design.
// Markus
I have now submitted a new pull request where the connection
information is displayed in its own frame as suggested:
https://github.com/jitsi/jitsi/pull/32// Markus
Emil
Ingo
_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev
Hi,
It is in the repo. Check out latest nightly.
Great, thanks!
Cheers,
Markus
On 2014-07-11 18:59, Damian Minkov wrote:
Regards
damenchoOn Jul 11, 2014 7:22 PM, "Markus Kil�s" <subjunctive.post@gmail.com > <mailto:subjunctive.post@gmail.com>> wrote:
Hi,
Has anyone had time to do a test build yet?
Cheers,
MarkuOn 2014-05-31 10:03, Ingo Bauersachs wrote:
> Hey
>
> I can get online from time to time, and Markus' code looks fine in
the diff
> on Github. However, I don't have a dev env with me, so if someone
could just
> do a test build, then I think it can be merged.
>
> Btw: an easy way to do that is to checkout the pull request using Git:
> https://help.github.com/articles/checking-out-pull-requests-locally
>
> Ingo
>
> -----Original Message-----
> From: dev-bounces@jitsi.org <mailto:dev-bounces@jitsi.org>
[mailto:dev-bounces@jitsi.org <mailto:dev-bounces@jitsi.org>] On
Behalf Of Emil
> Ivov
> Sent: Samstag, 31. Mai 2014 15:29
> To: dev@jitsi.org <mailto:dev@jitsi.org>
> Subject: Re: [jitsi-dev] List all certificates in X509CertificatePanel
>
> Thanks Markus! Always appreciated!
>
> Now that Ingo is off we'd just need to find someone to review that.
> Yana, would you have time to have a look? Anyoen else?
>
> On 30.05.14, 19:28, Markus Kil�s wrote:
>> On 2014-05-18 21:25, Markus Kil�s wrote:
>>> On 2014-05-18 21:19, Ingo Bauersachs wrote:
>>>> (My Office365 somehow didn't want to accept Emil's mail from the
>>>> list...)
>>>>
>>>>> On 18.05.14, 01:33, Ingo Bauersachs wrote:
>>>>>>>> Emil: can you please comment on the screenshots?
>>>>>>>> https://github.com/jitsi/jitsi/pull/26#discussion_r11798860
>>>>>>> Talked with Yana and she'd rather avoid the tabs. Can we
just add
>>>>>>> that at the bottom of the existing list? It also seems like many
>>>>>>> of the options can be grouped in a single line.
>>>>>> What's the issue with tabs?
>>>>> Mostly aesthetic I guess. Makes the GUI look busy. (Yes I realise
>>>>> this is subjective but if we agree that Yana is the GUI Tzar then
>>>>> we could possibly defer this to her judgement)
>>>>>
>>>>>> There's an apply button which suggests that most of the stuff
>>>>>> there should be editable (at least if the server supports
>>>> it).
>>>>> Well ... apply would apply what's appliable (i.e. editable)
... but
>>>>> I do see why this makes you uncomfortable.
>>>>>
>>>>>> Mixing contact/account details with connection info seems weird.
>>>>> This bothers me less than the above actually, and besides,
they are
>>>>> both in the smae window that pops when opening "account info" so,
>>>>> tabs or not, we are still mixing it.
>>>>>
>>>>>> What about putting it into a separate window, to be opened by a
>>>>>> menu
>>>> entry
>>>>>> below "Help"? Could even be in the main windows' help menu too:
>>>>>> Help
>>>>>> Connection details -> Account 1
>>>>>> -> Account 2
>>>>>> ...
>>>>>>
>>>>> This would work for me. I just think I'd rather have this in Tools
>>>>> than Help ... but I won't insist.
>>>> Markus, what do you think: Creating a new window that is basically
>>>> the same as the current account details, to be opened through
>>>> Tools->Connection information.
>>>>
>>>> No tabs, no mixing with account settings/apply, no submenus, less
>>>> modification of existing code.
>>> Yes, that sounds much more like the correct design.
>>>
>>> // Markus
>>
>> I have now submitted a new pull request where the connection
>> information is displayed in its own frame as suggested:
>> https://github.com/jitsi/jitsi/pull/32
>>
>> // Markus
>>
>>>
>>>>> Emil
>>>> Ingo
>>>>
>>>>
>>>> _______________________________________________
>>>> dev mailing list
>>>> dev@jitsi.org <mailto:dev@jitsi.org>
>>>> Unsubscribe instructions and other list options:
>>>> http://lists.jitsi.org/mailman/listinfo/dev
>>
>>
>> _______________________________________________
>> dev mailing list
>> dev@jitsi.org <mailto:dev@jitsi.org>
>> Unsubscribe instructions and other list options:
>> http://lists.jitsi.org/mailman/listinfo/dev
>>
>
> --
> https://jitsi.org
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org <mailto:dev@jitsi.org>
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev
>
>
> _______________________________________________
> dev mailing list
> dev@jitsi.org <mailto:dev@jitsi.org>
> Unsubscribe instructions and other list options:
> http://lists.jitsi.org/mailman/listinfo/dev
>_______________________________________________
dev mailing list
dev@jitsi.org <mailto:dev@jitsi.org>
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev