[jitsi-dev] [libjitsi] VPXDecoder sets TIME_UKNOWN on the output buffer (#28)


#1

On lines 170 and 220, the output buffer has its timestamp set to Buffer.TIME_UNKNOWN or -1 instead of simply copying the input buffer timestamp or using the PTS or DTS from the native decoder.

https://github.com/jitsi/libjitsi/blob/master/src/org/jitsi/impl/neomedia/codec/video/vp8/VPXDecoder.java

Setting this value to unknown causes issues for implementers wanting to re-encode or use the frames in follow up processing.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/issues/28


#2

Is there a way to get the pts out of the vpx native code after the decode occurs? I looked, but I don't understand C++ very well.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/issues/28#issuecomment-67743621


#3

That's a good catch!

The native decoder, as we use it, is not aware of frames' timestamps at all.

I think that we should copy the input Buffer's timestamp in VPXDecoder, as you suggest. I don't think I had a specific reason not to do it in the first place, I was probably just following the the h264 implementation.
@lyubomir, do you see any reason not to change this for both VP8 and H264?

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/issues/28#issuecomment-67859915


#4

Thanks Boris, I'm sure that I'm probably not using libjitsi in the same way as others (on the server) or they just don't report what they see. This library makes my life a lot easier and if I can help out, I will.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/issues/28#issuecomment-67862706


#5

Closed #28.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/issues/28#event-360048096


#6

Fixed with merging PR #31

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/issues/28#issuecomment-122902163