[jitsi-dev] [libjitsi] Uses the real RTT for send-side bandwidth estimation. (#89)


#1

You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/libjitsi/pull/89

-- Commit Summary --

  * Uses the real RTT for send-side bandwidth estimation.

-- File Changes --

    M src/org/jitsi/impl/neomedia/rtp/sendsidebandwidthestimation/SendSideBandwidthEstimation.java (8)

-- Patch Links --

https://github.com/jitsi/libjitsi/pull/89.patch
https://github.com/jitsi/libjitsi/pull/89.diff

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/89


#2

     {
- //FIXME: the RTT from MediaStreamStats is wrong (always 2^16).
- return 100;
+ long rtt = mediaStream.getMediaStreamStats().getRttMs();

Can we add some logging here to catch suspicious RTTs : `rtt =< 0 || rtt >= 1000`?

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/89/files#r54007442


#3

     {
- //FIXME: the RTT from MediaStreamStats is wrong (always 2^16).
- return 100;
+ long rtt = mediaStream.getMediaStreamStats().getRttMs();

Yes, added. Thanks!

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/89/files#r54008535


#4

Merged #89.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/89#event-564379342