[jitsi-dev] [libjitsi] Use fixed Random seed values and a latch for test consistency. (#96)


#1

Communicate that testing is happening and differentiate test outcomes.

Tried a couple of fixed seed values that would still exercise the
tests but complete in under a minute on my machine.

Test consistently passes and in a reasonable amount of time.

Formatting.

This PR is a replacement for https://github.com/jitsi/libjitsi/pull/77 (when force pushing updates to that branch, all the comments disappeared).
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/libjitsi/pull/96

-- Commit Summary --

  * Use fixed Random seed values and a latch for test consistency.

-- File Changes --

    M test/org/jitsi/sctp4j/SctpTransferTest.java (96)
    M test/org/jitsi/sctp4j/TestLink.java (22)

-- Patch Links --

https://github.com/jitsi/libjitsi/pull/96.patch
https://github.com/jitsi/libjitsi/pull/96.diff

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/96


#2

Can one of the admins verify this patch?

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/96#issuecomment-191945311


#3

@ibauersachs Was the formatting from https://github.com/jitsi/libjitsi/pull/77 only about braces and then I did too much reformatting? I now realize should have asked which formatting was in violation, but I figured you all are very busy.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/96#issuecomment-205771064


#4

Not sure anymore, at first glance now I just saw braces. Here's a link to the convention: https://jitsi.org/Documentation/CodeConvention.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/96#issuecomment-205779651


#5

Merged #96.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/96#event-623208974