[jitsi-dev] [libjitsi] Use boncycastle version 1.51 (1.54 fails to compile) (#72)


#1

Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/libjitsi/pull/72

-- Commit Summary --

  * Use boncycastle version 1.51 (1.54 fails to compile)

-- File Changes --

    M pom.xml (2)

-- Patch Links --

https://github.com/jitsi/libjitsi/pull/72.patch
https://github.com/jitsi/libjitsi/pull/72.diff

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/72


#2

I'm using BC 1.53 and it seems to work just fine; my 2 cents.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/72#issuecomment-170248660


#3

We're actually building bouncycastle from this branch https://github.com/gpolitis/bc-java because it contains a fix required for Firefox support. So, in order to switch to 1.53 we need to merge the changes from upstream into the aforementioned branch, build the library and push to our GH maven repository.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/72#issuecomment-170983962


#4

Actually @damencho just brought to my attention that DTLS version negotiation is supposed to be fixed in BouncyCastle 1.4. We need to test this new version against the bridge, and eventually switch to that if no other problem arises.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/72#issuecomment-170986451


#5

I ve a patch to fix the build failure, i ll sens et tomorrow (it's on my work PC)

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/72#issuecomment-171061069


#6

Here is my patch. I'm using bouncy castle 1.54 in all jitsi's projects and i can join a room with firefox nightly (is it a good enough test?)

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/72#issuecomment-171205216


#7

Just tested bc 1.54 in:
libjitsi
jitsi-videobridge (using above libjitsi)
jicofo (using above libjitsi)

These three on the jitsi-meet server, Abrowser 43.0.4 (Firefox) Trisquel GNU/Linux had successful video chat with Firefox 43.0.4 on another operating system.

Tests with jitsi client to jitsi client over videobridge were unsuccessful but that may have been due to other factors.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/72#issuecomment-181146325


#8

@gpolitis Any reason not to merge this?

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/72#issuecomment-189921773


#9

If we merge this, libjitsi will depend on 1.54 and jitsi-videobridge and jicofo on 1.51-jitsi-1. Since 1.54 has fixed DTLS negotiation, I don't see a reason why not to use 1.54 everywhere but maybe I'm missing something?

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/72#issuecomment-190013702


#10

Maybe we should update bc in jitsi-universe

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/72#issuecomment-190071188


#11

Can one of the admins verify this patch?

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/72#issuecomment-191945334


#12

Merged #72.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/72#event-616230243