[jitsi-dev] [libjitsi] RTCP termination refactoring. (#58)


#1

You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/libjitsi/pull/58

-- Commit Summary --

  * Refactors RTCP termination.
  * Updates Javadoc: An RTCPTerminationStrategy is not necessarily owned by a MediaStream.
  * Remove unused imports.
  * Updates fmj@104 (Makes the RTCPTransmitter replaceable).
  * Avoid unnecessary new object creation for each RTCP packet that is processed.
  * Updates Javadoc.
  * Fixes compiler warning.
  * Don't break RTCP statistics.
  * MAX_RTCP_REPORT_BLOCKS_ARRAY should not be static.
  * - Avoid unnecessary new object creation for each RTCP packet that is processed.
  * Adds TODO.

-- File Changes --

    M lib/fmj.jar (0)
    M src/org/jitsi/impl/neomedia/MediaStreamImpl.java (89)
    M src/org/jitsi/impl/neomedia/SSRCFactoryImpl.java (2)
    D src/org/jitsi/impl/neomedia/rtcp/termination/strategies/AbstractRTCPTerminationStrategy.java (186)
    M src/org/jitsi/impl/neomedia/rtcp/termination/strategies/BasicRTCPTerminationStrategy.java (1131)
    D src/org/jitsi/impl/neomedia/rtcp/termination/strategies/FeedbackCacheUpdater.java (109)
    D src/org/jitsi/impl/neomedia/rtcp/termination/strategies/HighestQualityRTCPTerminationStrategy.java (165)
    M src/org/jitsi/impl/neomedia/rtcp/termination/strategies/MaxThroughputRTCPTerminationStrategy.java (187)
    A src/org/jitsi/impl/neomedia/rtcp/termination/strategies/MediaStreamRTCPTerminationStrategy.java (44)
    M src/org/jitsi/impl/neomedia/rtcp/termination/strategies/MinThroughputRTCPTerminationStrategy.java (183)
    M src/org/jitsi/impl/neomedia/rtcp/termination/strategies/PassthroughRTCPTerminationStrategy.java (29)
    D src/org/jitsi/impl/neomedia/rtcp/termination/strategies/ReceiverFeedbackFilter.java (104)
    M src/org/jitsi/impl/neomedia/rtcp/termination/strategies/SilentBridgeRTCPTerminationStrategy.java (28)
    M src/org/jitsi/impl/neomedia/rtp/StreamRTPManager.java (49)
    D src/org/jitsi/impl/neomedia/rtp/translator/DelegatingRTCPReportBuilder.java (129)
    M src/org/jitsi/impl/neomedia/rtp/translator/Payload.java (12)
    A src/org/jitsi/impl/neomedia/rtp/translator/RTCPTransmitterFactoryImpl.java (29)
    A src/org/jitsi/impl/neomedia/rtp/translator/RTCPTransmitterImpl.java (175)
    M src/org/jitsi/impl/neomedia/rtp/translator/RTPTranslatorImpl.java (132)
    M src/org/jitsi/impl/neomedia/rtp/translator/StreamRTPManagerDesc.java (7)
    D src/org/jitsi/impl/neomedia/transform/rtcp/NullRTCPPacketTransformer.java (45)
    D src/org/jitsi/impl/neomedia/transform/rtcp/RTCPTerminationTransformEngine.java (178)
    M src/org/jitsi/service/neomedia/MediaStream.java (31)
    M src/org/jitsi/service/neomedia/RTCPTerminationStrategy.java (47)
    M src/org/jitsi/service/neomedia/RTPTranslator.java (30)
    D src/org/jitsi/service/neomedia/Transformer.java (41)
    A src/org/jitsi/service/neomedia/TransmissionFailedException.java (28)
    M src/org/jitsi/util/function/RTCPGenerator.java (2)

-- Patch Links --

https://github.com/jitsi/libjitsi/pull/58.patch
https://github.com/jitsi/libjitsi/pull/58.diff

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/58


#2

LGTM

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/58#issuecomment-140399540


#3

Merged #58.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/58#event-409876095