[jitsi-dev] [libjitsi] Packet queue (#115)


#1

You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/libjitsi/pull/115

-- Commit Summary --

  * Adds RawPacketQueue.
  * Adds QueueStatistics to some of our packet queues.
  * Uses RateStatistics from ice4j.
  * Adds a missing header.

-- File Changes --

    M pom.xml (2)
    M src/org/jitsi/impl/neomedia/RTPConnectorOutputStream.java (30)
    D src/org/jitsi/impl/neomedia/rtp/remotebitrateestimator/RateStatistics.java (123)
    M src/org/jitsi/impl/neomedia/rtp/remotebitrateestimator/RemoteBitrateEstimatorSingleStream.java (1)
    M src/org/jitsi/impl/neomedia/rtp/translator/OutputDataStreamImpl.java (26)
    M src/org/jitsi/impl/neomedia/rtp/translator/PushSourceStreamImpl.java (26)
    A src/org/jitsi/util/RawPacketQueue.java (105)

-- Patch Links --

https://github.com/jitsi/libjitsi/pull/115.patch
https://github.com/jitsi/libjitsi/pull/115.diff

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/115


#2

@@ -55,7 +55,7 @@
     <dependency>
       <groupId>${project.groupId}</groupId>
       <artifactId>ice4j</artifactId>
- <version>1.0-20160310.155819-18</version>
+ <version>1.0-SNAPSHOT</version>

this was probably just for dev?

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/115/files/ccdb19bcf8c1d5c4797ea185535251573d6cfaf6#r57213732


#3

@@ -55,7 +55,7 @@
     <dependency>
       <groupId>${project.groupId}</groupId>
       <artifactId>ice4j</artifactId>
- <version>1.0-20160310.155819-18</version>
+ <version>1.0-SNAPSHOT</version>

Yes. The file has to be updated with the new snapshot version before merging (should have mentioned that in the PR comment).

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/115/files/ccdb19bcf8c1d5c4797ea185535251573d6cfaf6#r57225609


#4

@@ -768,11 +768,19 @@ public long getOutputBitrate(long now)
          */
         final Thread sendThread;

+ QueueStatistics queueStats = null;

missing JavaDocs ? also why does it have "package private" access level ? Just asking...

···


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/115/files/85bd9a65f818890778387028bc47447a1ab6af2a..6090b1783588a3ea0ea4ef79bb8b0b9019eceb1e#r57334202


#5

@@ -768,11 +768,19 @@ public long getOutputBitrate(long now)
          */
         final Thread sendThread;

+ QueueStatistics queueStats = null;

Added javadoc. I didn't use the "private" keyword, because these are members of a private inner class, so they cannot be accessed from the outside (unless I am missing something).

···


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/115/files/85bd9a65f818890778387028bc47447a1ab6af2a..6090b1783588a3ea0ea4ef79bb8b0b9019eceb1e#r57339901


#6

Merged #115.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/115#event-601952351